Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624024 > unrolled thread

[PATCH] remove return statement

Back to article view | Back to linux.kernel

Contents

  [PATCH] remove return statement surenderpolsani <surenderpolsani@gmail.com> - 2017-04-15 07:10 +0200
    Re: [PATCH] remove return statement Joe Perches <joe@perches.com> - 2017-04-15 07:20 +0200

#1624024 — [PATCH] remove return statement

staging : rtl8188e : remove return in void function

kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: surenderpolsani <surenderpolsani@gmail.com>
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..6db0e19 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -165,7 +165,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
 	/*  Check GPIO to determine current RF on/off and Pbc status. */
 	/*  Check Hardware Radio ON/OFF or not */
-	return;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

[toc] | [next] | [standalone]

#1624025

On Sat, 2017-04-15 at 10:35 +0530, surenderpolsani wrote:
> staging : rtl8188e : remove return in void function

Your patch subject isn't correct.

It should be something like:

Subject: [PATCH] staging: rtl8188e: Remove void function return

> kernel coding style doesn't allow the return statement
> in void function.
[]
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
[]
> @@ -165,7 +165,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
>  skip_dm:
>  	/*  Check GPIO to determine current RF on/off and Pbc status. */
>  	/*  Check Hardware Radio ON/OFF or not */
> -	return;

And the comments?
Are those supposed to be reminders of code to write?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web