Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1624013 > unrolled thread
| Started by | frowand.list@gmail.com |
|---|---|
| First post | 2017-04-15 06:00 +0200 |
| Last post | 2017-04-15 06:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/4] of: be consistent in form of file mode frowand.list@gmail.com - 2017-04-15 06:00 +0200
Re: [PATCH 3/4] of: be consistent in form of file mode Frank Rowand <frowand.list@gmail.com> - 2017-04-15 06:10 +0200
| From | frowand.list@gmail.com |
|---|---|
| Date | 2017-04-15 06:00 +0200 |
| Subject | [PATCH 3/4] of: be consistent in form of file mode |
| Message-ID | <twn2p-1DE-9@gated-at.bofh.it> |
From: Frank Rowand <frank.rowand@sony.com> checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand <frank.rowand@sony.com> --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 197946615503..4a8bd9623140 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -168,7 +168,7 @@ int __of_add_property_sysfs(struct device_node *np, struct property *pp) sysfs_bin_attr_init(&pp->attr); pp->attr.attr.name = safe_name(&np->kobj, pp->name); - pp->attr.attr.mode = secure ? S_IRUSR : S_IRUGO; + pp->attr.attr.mode = secure ? 0400 : 0444; pp->attr.size = secure ? 0 : pp->length; pp->attr.read = of_node_property_read; -- Frank Rowand <frank.rowand@sony.com>
[toc] | [next] | [standalone]
| From | Frank Rowand <frowand.list@gmail.com> |
|---|---|
| Date | 2017-04-15 06:10 +0200 |
| Message-ID | <twnc5-1VT-5@gated-at.bofh.it> |
| In reply to | #1624013 |
Adding Stephen. On 04/14/17 20:55, frowand.list@gmail.com wrote: > From: Frank Rowand <frank.rowand@sony.com> > > checkpatch whined about using S_IRUGO instead of octal equivalent > when adding phandle sysfs code, so used octal in that patch. > Change other instances of the S_* constants in the same file to > the octal form. > > Signed-off-by: Frank Rowand <frank.rowand@sony.com> > --- > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 197946615503..4a8bd9623140 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -168,7 +168,7 @@ int __of_add_property_sysfs(struct device_node *np, struct property *pp) > > sysfs_bin_attr_init(&pp->attr); > pp->attr.attr.name = safe_name(&np->kobj, pp->name); > - pp->attr.attr.mode = secure ? S_IRUSR : S_IRUGO; > + pp->attr.attr.mode = secure ? 0400 : 0444; > pp->attr.size = secure ? 0 : pp->length; > pp->attr.read = of_node_property_read; > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web