Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1623863 > unrolled thread
| Started by | Andreas Färber <afaerber@suse.de> |
|---|---|
| First post | 2017-04-14 21:10 +0200 |
| Last post | 2017-04-18 07:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] arm64: dts: allwinner: pine64: Add remaining UART aliases Andreas Färber <afaerber@suse.de> - 2017-04-14 21:10 +0200
Re: [PATCH] arm64: dts: allwinner: pine64: Add remaining UART aliases Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-18 07:40 +0200
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2017-04-14 21:10 +0200 |
| Subject | [PATCH] arm64: dts: allwinner: pine64: Add remaining UART aliases |
| Message-ID | <tweLw-4WH-11@gated-at.bofh.it> |
Enabling uart2 node currently leads to a /dev/ttyS1 device, with ttyS0..4
always present, causing confusion on the user's part.
dtc cannot resolve an overlay's &uart2 reference for strings, only for
phandles, so it would need to hardcode the full node path.
Avoid this and enforce reliable numbering by adding serialX aliases for:
UART1 - on Wifi/BT connector
UART2 - on Pi-2 connector
UART3 - on Euler connector
UART4 - on Euler connector
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index c680ed385da3..db6c0f36999e 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -52,6 +52,10 @@
aliases {
serial0 = &uart0;
+ serial1 = &uart1;
+ serial2 = &uart2;
+ serial3 = &uart3;
+ serial4 = &uart4;
};
chosen {
--
2.10.2
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-04-18 07:40 +0200 |
| Message-ID | <txu1Q-2go-11@gated-at.bofh.it> |
| In reply to | #1623863 |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Apr 14, 2017 at 09:08:04PM +0200, Andreas Färber wrote: > Enabling uart2 node currently leads to a /dev/ttyS1 device, with ttyS0..4 > always present, causing confusion on the user's part. > > dtc cannot resolve an overlay's &uart2 reference for strings, only for > phandles, so it would need to hardcode the full node path. > > Avoid this and enforce reliable numbering by adding serialX aliases for: > > UART1 - on Wifi/BT connector > UART2 - on Pi-2 connector > UART3 - on Euler connector > UART4 - on Euler connector > > Signed-off-by: Andreas Färber <afaerber@suse.de> Applied, thanks Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web