Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1624147 > unrolled thread

Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks Nicolai Stange <nicstange@gmail.com> - 2017-04-16 04:50 +0200
    Re: [PATCH] microblaze/timer: set ->min_delta_ticks and  ->max_delta_ticks Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-04-16 11:50 +0200

#1624147 — Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks

Hello Daniel,

On Fri, Apr 07 2017, Daniel Lezcano wrote:

> On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote:
>> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
>> index 999066192715..545ccd46edb3 100644
>> --- a/arch/microblaze/kernel/timer.c
>> +++ b/arch/microblaze/kernel/timer.c
>> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void)
>>  				clockevent_xilinx_timer.shift);
>>  	clockevent_xilinx_timer.max_delta_ns =
>>  		clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer);
>> +	clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
>
> Can you take the opportunity to fix the type (unsigned long) ?

Hmm, I personally think that it'd be better to leave the u32 there as it
corresponds to the hardware's counter width?

clockevent_delta2ns()' latch argument has been of type unsigned long
from the beginning and this might indicate that at least this
driver's original author followed this line of reasoning...

OTOH, I think that u32 is equivalent to unsigned long on microblaze, so
it doesn't matter much.

Does the above convince you or do you still want the

  -	clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
  +	clockevent_xilinx_timer.max_delta_ticks = ~0UL;

change?


Thanks,

Nicolai

[toc] | [next] | [standalone]

#1624231 — Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks

On Sun, Apr 16, 2017 at 04:47:11AM +0200, Nicolai Stange wrote:
> Hello Daniel,
> 
> On Fri, Apr 07 2017, Daniel Lezcano wrote:
> 
> > On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote:
> >> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c
> >> index 999066192715..545ccd46edb3 100644
> >> --- a/arch/microblaze/kernel/timer.c
> >> +++ b/arch/microblaze/kernel/timer.c
> >> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void)
> >>  				clockevent_xilinx_timer.shift);
> >>  	clockevent_xilinx_timer.max_delta_ns =
> >>  		clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer);
> >> +	clockevent_xilinx_timer.max_delta_ticks = (u32)~0;
> >
> > Can you take the opportunity to fix the type (unsigned long) ?
> 
> Hmm, I personally think that it'd be better to leave the u32 there as it
> corresponds to the hardware's counter width?
> 
> clockevent_delta2ns()' latch argument has been of type unsigned long
> from the beginning and this might indicate that at least this
> driver's original author followed this line of reasoning...
> 
> OTOH, I think that u32 is equivalent to unsigned long on microblaze, so
> it doesn't matter much.
> 
> Does the above convince you or do you still want the

Yeah, I was nitpicking.

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web