Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621922 > unrolled thread
| Started by | Chao Yu <yuchao0@huawei.com> |
|---|---|
| First post | 2017-04-12 10:40 +0200 |
| Last post | 2017-04-12 22:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/3] f2fs: shrink blk plug region Chao Yu <yuchao0@huawei.com> - 2017-04-12 10:40 +0200
Re: [PATCH 2/3] f2fs: shrink blk plug region Jaegeuk Kim <jaegeuk@kernel.org> - 2017-04-12 22:00 +0200
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Date | 2017-04-12 10:40 +0200 |
| Subject | Re: [PATCH 2/3] f2fs: shrink blk plug region |
| Message-ID | <tvlYJ-2ed-3@gated-at.bofh.it> |
Hi Jaegeuk,
Just reminding, miss merging this patch? :)
Thanks,
On 2017/3/27 18:14, Chao Yu wrote:
> Don't use blk plug covering area where there won't be any IOs being issued.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/segment.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index c1a03b0857f9..57a81f9c8c14 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -848,9 +848,8 @@ static int issue_discard_thread(void *data)
> if (kthread_should_stop())
> return 0;
>
> - blk_start_plug(&plug);
> -
> mutex_lock(&dcc->cmd_lock);
> + blk_start_plug(&plug);
> list_for_each_entry_safe(dc, tmp, pend_list, list) {
> f2fs_bug_on(sbi, dc->state != D_PREP);
>
> @@ -860,6 +859,7 @@ static int issue_discard_thread(void *data)
> if (iter++ > DISCARD_ISSUE_RATE)
> break;
> }
> + blk_finish_plug(&plug);
>
> list_for_each_entry_safe(dc, tmp, wait_list, list) {
> if (dc->state == D_DONE)
> @@ -867,8 +867,6 @@ static int issue_discard_thread(void *data)
> }
> mutex_unlock(&dcc->cmd_lock);
>
> - blk_finish_plug(&plug);
> -
> iter = 0;
> congestion_wait(BLK_RW_SYNC, HZ/50);
>
>
[toc] | [next] | [standalone]
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-04-12 22:00 +0200 |
| Message-ID | <tvwAN-l5-1@gated-at.bofh.it> |
| In reply to | #1621922 |
On 04/12, Chao Yu wrote:
> Hi Jaegeuk,
>
> Just reminding, miss merging this patch? :)
Yup, merged. ;)
>
> Thanks,
>
> On 2017/3/27 18:14, Chao Yu wrote:
> > Don't use blk plug covering area where there won't be any IOs being issued.
> >
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fs/f2fs/segment.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> > index c1a03b0857f9..57a81f9c8c14 100644
> > --- a/fs/f2fs/segment.c
> > +++ b/fs/f2fs/segment.c
> > @@ -848,9 +848,8 @@ static int issue_discard_thread(void *data)
> > if (kthread_should_stop())
> > return 0;
> >
> > - blk_start_plug(&plug);
> > -
> > mutex_lock(&dcc->cmd_lock);
> > + blk_start_plug(&plug);
> > list_for_each_entry_safe(dc, tmp, pend_list, list) {
> > f2fs_bug_on(sbi, dc->state != D_PREP);
> >
> > @@ -860,6 +859,7 @@ static int issue_discard_thread(void *data)
> > if (iter++ > DISCARD_ISSUE_RATE)
> > break;
> > }
> > + blk_finish_plug(&plug);
> >
> > list_for_each_entry_safe(dc, tmp, wait_list, list) {
> > if (dc->state == D_DONE)
> > @@ -867,8 +867,6 @@ static int issue_discard_thread(void *data)
> > }
> > mutex_unlock(&dcc->cmd_lock);
> >
> > - blk_finish_plug(&plug);
> > -
> > iter = 0;
> > congestion_wait(BLK_RW_SYNC, HZ/50);
> >
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web