Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1622462 > unrolled thread

Re: [PATCH -next] imx7: fix Kconfig warning and build errors

Started byFabio Estevam <festevam@gmail.com>
First post2017-04-12 20:30 +0200
Last post2017-04-12 22:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH -next] imx7: fix Kconfig warning and build errors Fabio Estevam <festevam@gmail.com> - 2017-04-12 20:30 +0200
    Re: [PATCH -next] imx7: fix Kconfig warning and build errors Randy Dunlap <rdunlap@infradead.org> - 2017-04-12 21:30 +0200
      Re: [PATCH -next] imx7: fix Kconfig warning and build errors Fabio Estevam <festevam@gmail.com> - 2017-04-12 22:00 +0200

#1622462 — Re: [PATCH -next] imx7: fix Kconfig warning and build errors

FromFabio Estevam <festevam@gmail.com>
Date2017-04-12 20:30 +0200
SubjectRe: [PATCH -next] imx7: fix Kconfig warning and build errors
Message-ID<tvvbH-7UV-5@gated-at.bofh.it>
On Wed, Apr 12, 2017 at 3:22 PM, Randy Dunlap <rdunlap@infradead.org> wrote:

> --- linux-next-20170412.orig/drivers/soc/imx/Kconfig
> +++ linux-next-20170412/drivers/soc/imx/Kconfig
> @@ -2,6 +2,7 @@ menu "i.MX SoC drivers"
>
>  config IMX7_PM_DOMAINS
>         bool "i.MX7 PM domains"
> +       depends on PM
>         select PM_GENERIC_DOMAINS

Could this be:

select PM_GENERIC_DOMAINS if PM instead?

[toc] | [next] | [standalone]


#1622497

FromRandy Dunlap <rdunlap@infradead.org>
Date2017-04-12 21:30 +0200
Message-ID<tvw7L-64-7@gated-at.bofh.it>
In reply to#1622462
On 04/12/17 11:26, Fabio Estevam wrote:
> On Wed, Apr 12, 2017 at 3:22 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> --- linux-next-20170412.orig/drivers/soc/imx/Kconfig
>> +++ linux-next-20170412/drivers/soc/imx/Kconfig
>> @@ -2,6 +2,7 @@ menu "i.MX SoC drivers"
>>
>>  config IMX7_PM_DOMAINS
>>         bool "i.MX7 PM domains"
>> +       depends on PM
>>         select PM_GENERIC_DOMAINS
> 
> Could this be:
> 
> select PM_GENERIC_DOMAINS if PM instead?
> 

You want IMX7_PM_DOMAINS to be built without having
PM_GENERIC_DOMAINS enabled?

On x86, your suggestion works for me... because of this
in drivers/soc/Makefile:

obj-$(CONFIG_ARCH_MXC)		+= imx/

and I don't have CONFIG_ARCH_MXC, so the gpc* binaries are
not being built at all.  This might be a small bug.


-- 
~Randy

[toc] | [prev] | [next] | [standalone]


#1622504

FromFabio Estevam <festevam@gmail.com>
Date2017-04-12 22:00 +0200
Message-ID<tvwAN-l5-3@gated-at.bofh.it>
In reply to#1622497
On Wed, Apr 12, 2017 at 4:24 PM, Randy Dunlap <rdunlap@infradead.org> wrote:

> You want IMX7_PM_DOMAINS to be built without having
> PM_GENERIC_DOMAINS enabled?
>
> On x86, your suggestion works for me... because of this
> in drivers/soc/Makefile:
>
> obj-$(CONFIG_ARCH_MXC)          += imx/
>
> and I don't have CONFIG_ARCH_MXC, so the gpc* binaries are
> not being built at all.  This might be a small bug.

Just tested your patch with imx_v6_v7_defconfig + manually doing
CONFIG_PM=n  and it does fix the build error, thanks:

Tested-by: Fabio Estevam <fabio.estevam@nxp.com>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web