Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621075 > unrolled thread

[PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi"

Back to article view | Back to linux.kernel

Contents

  [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using  hid-rmi" Jiri Kosina <jikos@kernel.org> - 2017-04-11 11:30 +0200
    Re: [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using  hid-rmi" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-04-11 11:40 +0200
    Re: [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using  hid-rmi" Jiri Kosina <jikos@kernel.org> - 2017-04-12 15:00 +0200

#1621075 — [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi"

From: Jiri Kosina <jkosina@suse.cz>

This reverts commit 279967a65b320d174a507498aea7d44db3fee7f4.

Multiple regressions [1] [2] [3] have been reported. The hid-rmi
support would have to fixed and redone in 4.11+.

[1] http://lkml.kernel.org/r/b79b88c8-770a-13f6-5668-c3a94254e5e0@gmail.com
[2] http://lkml.kernel.org/r/375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com
[3] https://bugzilla.kernel.org/show_bug.cgi?id=195287

Reported-by: Cameron Gutman <aicommander@gmail.com>
Reported-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Reported-by: Lorenzo J. Lucchini <ljlbox@tiscali.it>
Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/hid/hid-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 86bbd8a1fd4a..d162f0dc76e3 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -819,8 +819,7 @@ static int hid_scan_report(struct hid_device *hid)
 		hid->group = HID_GROUP_WACOM;
 		break;
 	case USB_VENDOR_ID_SYNAPTICS:
-		if (hid->group == HID_GROUP_GENERIC ||
-		    hid->group == HID_GROUP_MULTITOUCH_WIN_8)
+		if (hid->group == HID_GROUP_GENERIC)
 			if ((parser->scan_flags & HID_SCAN_FLAG_VENDOR_SPECIFIC)
 			    && (parser->scan_flags & HID_SCAN_FLAG_GD_POINTER))
 				/*
-- 
Jiri Kosina
SUSE Labs

[toc] | [next] | [standalone]

#1621093

On Apr 11 2017 or thereabouts, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
> 
> This reverts commit 279967a65b320d174a507498aea7d44db3fee7f4.
> 
> Multiple regressions [1] [2] [3] have been reported. The hid-rmi
> support would have to fixed and redone in 4.11+.
> 
> [1] http://lkml.kernel.org/r/b79b88c8-770a-13f6-5668-c3a94254e5e0@gmail.com
> [2] http://lkml.kernel.org/r/375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com
> [3] https://bugzilla.kernel.org/show_bug.cgi?id=195287
> 
> Reported-by: Cameron Gutman <aicommander@gmail.com>
> Reported-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> Reported-by: Lorenzo J. Lucchini <ljlbox@tiscali.it>
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---

Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>  drivers/hid/hid-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 86bbd8a1fd4a..d162f0dc76e3 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -819,8 +819,7 @@ static int hid_scan_report(struct hid_device *hid)
>  		hid->group = HID_GROUP_WACOM;
>  		break;
>  	case USB_VENDOR_ID_SYNAPTICS:
> -		if (hid->group == HID_GROUP_GENERIC ||
> -		    hid->group == HID_GROUP_MULTITOUCH_WIN_8)
> +		if (hid->group == HID_GROUP_GENERIC)
>  			if ((parser->scan_flags & HID_SCAN_FLAG_VENDOR_SPECIFIC)
>  			    && (parser->scan_flags & HID_SCAN_FLAG_GD_POINTER))
>  				/*
> -- 
> Jiri Kosina
> SUSE Labs
> 

[toc] | [prev] | [next] | [standalone]

#1622121

On Tue, 11 Apr 2017, Jiri Kosina wrote:

> From: Jiri Kosina <jkosina@suse.cz>
> 
> This reverts commit 279967a65b320d174a507498aea7d44db3fee7f4.

Now in Linus' tree as 84379d83d8e.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web