Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621778 > unrolled thread
| Started by | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| First post | 2017-04-12 06:50 +0200 |
| Last post | 2017-04-12 10:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 1/3] mfd: max8998: Remove CONFIG_OF around max8998_dt_match Florian Fainelli <f.fainelli@gmail.com> - 2017-04-12 06:50 +0200
Re: [PATCH v2 1/3] mfd: max8998: Remove CONFIG_OF around max8998_dt_match Lee Jones <lee.jones@linaro.org> - 2017-04-12 10:00 +0200
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-04-12 06:50 +0200 |
| Subject | [PATCH v2 1/3] mfd: max8998: Remove CONFIG_OF around max8998_dt_match |
| Message-ID | <tvioa-8sz-7@gated-at.bofh.it> |
A subsequent patch is going to make of_match_node() an inline stub when
CONFIG_OF is disabled which will properly take care of having the compiler
eliminate the variable. To avoid more #ifdef/#else, just always make the match
table available.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/mfd/max8998.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
index 4c33b8063bc3..372f681ec1bb 100644
--- a/drivers/mfd/max8998.c
+++ b/drivers/mfd/max8998.c
@@ -129,14 +129,12 @@ int max8998_update_reg(struct i2c_client *i2c, u8 reg, u8 val, u8 mask)
}
EXPORT_SYMBOL(max8998_update_reg);
-#ifdef CONFIG_OF
static const struct of_device_id max8998_dt_match[] = {
{ .compatible = "maxim,max8998", .data = (void *)TYPE_MAX8998 },
{ .compatible = "national,lp3974", .data = (void *)TYPE_LP3974 },
{ .compatible = "ti,lp3974", .data = (void *)TYPE_LP3974 },
{},
};
-#endif
/*
* Only the common platform data elements for max8998 are parsed here from the
--
2.9.3
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-04-12 10:00 +0200 |
| Subject | Re: [PATCH v2 1/3] mfd: max8998: Remove CONFIG_OF around max8998_dt_match |
| Message-ID | <tvlm2-1MB-13@gated-at.bofh.it> |
| In reply to | #1621778 |
On Tue, 11 Apr 2017, Florian Fainelli wrote:
> A subsequent patch is going to make of_match_node() an inline stub when
> CONFIG_OF is disabled which will properly take care of having the compiler
> eliminate the variable. To avoid more #ifdef/#else, just always make the match
> table available.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/mfd/max8998.c | 2 --
> 1 file changed, 2 deletions(-)
If it works, great!
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index 4c33b8063bc3..372f681ec1bb 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -129,14 +129,12 @@ int max8998_update_reg(struct i2c_client *i2c, u8 reg, u8 val, u8 mask)
> }
> EXPORT_SYMBOL(max8998_update_reg);
>
> -#ifdef CONFIG_OF
> static const struct of_device_id max8998_dt_match[] = {
> { .compatible = "maxim,max8998", .data = (void *)TYPE_MAX8998 },
> { .compatible = "national,lp3974", .data = (void *)TYPE_LP3974 },
> { .compatible = "ti,lp3974", .data = (void *)TYPE_LP3974 },
> {},
> };
> -#endif
>
> /*
> * Only the common platform data elements for max8998 are parsed here from the
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web