Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1621816 > unrolled thread

[tip:perf/core] perf annotate: Use stripped line instead of raw disassemble line

Started bytip-bot for Taeung Song <tipbot@zytor.com>
First post2017-04-12 07:50 +0200
Last post2017-04-12 07:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [tip:perf/core] perf annotate: Use stripped line instead of raw  disassemble line tip-bot for Taeung Song <tipbot@zytor.com> - 2017-04-12 07:50 +0200

#1621816 — [tip:perf/core] perf annotate: Use stripped line instead of raw disassemble line

Fromtip-bot for Taeung Song <tipbot@zytor.com>
Date2017-04-12 07:50 +0200
Subject[tip:perf/core] perf annotate: Use stripped line instead of raw disassemble line
Message-ID<tvjke-Bv-15@gated-at.bofh.it>
Commit-ID:  986a5bc028a84d487c354a529730b48682d1fb41
Gitweb:     http://git.kernel.org/tip/986a5bc028a84d487c354a529730b48682d1fb41
Author:     Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Sat, 8 Apr 2017 09:52:25 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 11 Apr 2017 16:22:23 -0300

perf annotate: Use stripped line instead of raw disassemble line

When parsing disassemble lines for source line number, use a stripped
line instead of raw line.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1491612748-1605-3-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/annotate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 204790d..30498a2 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1159,8 +1159,8 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
 	parsed_line = rtrim(line);
 
 	/* /filename:linenr ? Save line number and ignore. */
-	if (regexec(&file_lineno, line, 2, match, 0) == 0) {
-		*line_nr = atoi(line + match[1].rm_so);
+	if (regexec(&file_lineno, parsed_line, 2, match, 0) == 0) {
+		*line_nr = atoi(parsed_line + match[1].rm_so);
 		return 0;
 	}
 

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web