Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1620573 > unrolled thread

Re: [PATCH] kbuild: use -Oz instead of -Os when using clang

Started byMatthias Kaehlcke <mka@chromium.org>
First post2017-04-10 20:10 +0200
Last post2017-04-12 22:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] kbuild: use -Oz instead of -Os when using clang Matthias Kaehlcke <mka@chromium.org> - 2017-04-10 20:10 +0200
    Re: [PATCH] kbuild: use -Oz instead of -Os when using clang Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-12 05:40 +0200
      Re: [PATCH] kbuild: use -Oz instead of -Os when using clang Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-12 22:40 +0200

#1620573 — Re: [PATCH] kbuild: use -Oz instead of -Os when using clang

FromMatthias Kaehlcke <mka@chromium.org>
Date2017-04-10 20:10 +0200
SubjectRe: [PATCH] kbuild: use -Oz instead of -Os when using clang
Message-ID<tuLVh-4hB-47@gated-at.bofh.it>
Hi Masahiro,

El Fri, Mar 31, 2017 at 02:57:43AM +0900 Masahiro Yamada ha dit:

> 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit:
> >
> >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> >> > This generates smaller resulting object code when compiled with clang.
> >> >
> >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> >> > ---
> >> >  Makefile | 3 ++-
> >> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/Makefile b/Makefile
> >> > index b2faa9319372..66bcdbf58371 100644
> >> > --- a/Makefile
> >> > +++ b/Makefile
> >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS       += $(call cc-option,-fdata-sections,)
> >> >  endif
> >> >
> >> >  ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
> >> > -KBUILD_CFLAGS  += -Os $(call cc-disable-warning,maybe-uninitialized,)
> >> > +KBUILD_CFLAGS  += $(call cc-option,-Oz,-Os)
> >> > +KBUILD_CFLAGS  += $(call cc-disable-warning,maybe-uninitialized,)
> >> >  else
> >> >  ifdef CONFIG_PROFILE_ALL_BRANCHES
> >> >  KBUILD_CFLAGS  += -O2 $(call cc-disable-warning,maybe-uninitialized,)
> >> >
> >>
> >>
> >>
> >> This is the same as the following commit in LLVMLinux
> >> except Author/Signed-off-by.
> >>
> >> Who should the authorship really belong to?
> >
> > (this time without html, sorry for the noise)
> >
> > It should belong to Behan, I missed to add a 'From' tag, sorry about
> > that. Should I resend with the tag or can you fix it when applying the
> > patch?
> 
> 
> No need to re-send it.  I can fixup it manually.

I couldn't locate this patch in your tree, has it been picked up?

Thanks

Matthias

[toc] | [next] | [standalone]


#1621768

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-04-12 05:40 +0200
Message-ID<tvhip-7Kt-1@gated-at.bofh.it>
In reply to#1620573
Hi Matthias,


2017-04-11 3:08 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> Hi Masahiro,
>
> El Fri, Mar 31, 2017 at 02:57:43AM +0900 Masahiro Yamada ha dit:
>
>> 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
>> > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit:
>> >
>> >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
>> >> > This generates smaller resulting object code when compiled with clang.
>> >> >
>> >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> >> > ---
>> >> >  Makefile | 3 ++-
>> >> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/Makefile b/Makefile
>> >> > index b2faa9319372..66bcdbf58371 100644
>> >> > --- a/Makefile
>> >> > +++ b/Makefile
>> >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS       += $(call cc-option,-fdata-sections,)
>> >> >  endif
>> >> >
>> >> >  ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
>> >> > -KBUILD_CFLAGS  += -Os $(call cc-disable-warning,maybe-uninitialized,)
>> >> > +KBUILD_CFLAGS  += $(call cc-option,-Oz,-Os)
>> >> > +KBUILD_CFLAGS  += $(call cc-disable-warning,maybe-uninitialized,)
>> >> >  else
>> >> >  ifdef CONFIG_PROFILE_ALL_BRANCHES
>> >> >  KBUILD_CFLAGS  += -O2 $(call cc-disable-warning,maybe-uninitialized,)
>> >> >
>> >>
>> >>
>> >>
>> >> This is the same as the following commit in LLVMLinux
>> >> except Author/Signed-off-by.
>> >>
>> >> Who should the authorship really belong to?
>> >
>> > (this time without html, sorry for the noise)
>> >
>> > It should belong to Behan, I missed to add a 'From' tag, sorry about
>> > that. Should I resend with the tag or can you fix it when applying the
>> > patch?
>>
>>
>> No need to re-send it.  I can fixup it manually.
>
> I couldn't locate this patch in your tree, has it been picked up?
>


I will pick this up shortly.  Sorry for the delay.



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]


#1622536

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2017-04-12 22:40 +0200
Message-ID<tvxdw-UY-7@gated-at.bofh.it>
In reply to#1621768
2017-04-12 12:38 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Matthias,
>
>
> 2017-04-11 3:08 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
>> Hi Masahiro,
>>
>> El Fri, Mar 31, 2017 at 02:57:43AM +0900 Masahiro Yamada ha dit:
>>
>>> 2017-03-31 1:41 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
>>> > El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit:
>>> >
>>> >> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
>>> >> > This generates smaller resulting object code when compiled with clang.
>>> >> >
>>> >> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>>> >> > ---
>>> >> >  Makefile | 3 ++-
>>> >> >  1 file changed, 2 insertions(+), 1 deletion(-)
>>> >> >
>>> >> > diff --git a/Makefile b/Makefile
>>> >> > index b2faa9319372..66bcdbf58371 100644
>>> >> > --- a/Makefile
>>> >> > +++ b/Makefile
>>> >> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS       += $(call cc-option,-fdata-sections,)
>>> >> >  endif
>>> >> >
>>> >> >  ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
>>> >> > -KBUILD_CFLAGS  += -Os $(call cc-disable-warning,maybe-uninitialized,)
>>> >> > +KBUILD_CFLAGS  += $(call cc-option,-Oz,-Os)
>>> >> > +KBUILD_CFLAGS  += $(call cc-disable-warning,maybe-uninitialized,)
>>> >> >  else
>>> >> >  ifdef CONFIG_PROFILE_ALL_BRANCHES
>>> >> >  KBUILD_CFLAGS  += -O2 $(call cc-disable-warning,maybe-uninitialized,)
>>> >> >
>>> >>
>>> >>
>>> >>
>>> >> This is the same as the following commit in LLVMLinux
>>> >> except Author/Signed-off-by.
>>> >>
>>> >> Who should the authorship really belong to?
>>> >
>>> > (this time without html, sorry for the noise)
>>> >
>>> > It should belong to Behan, I missed to add a 'From' tag, sorry about
>>> > that. Should I resend with the tag or can you fix it when applying the
>>> > patch?
>>>
>>>
>>> No need to re-send it.  I can fixup it manually.
>>
>> I couldn't locate this patch in your tree, has it been picked up?
>>
>
>
> I will pick this up shortly.  Sorry for the delay.
>


Applied to linux-kbuild/kbuild.  Thanks!



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web