Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621699 > unrolled thread

[PATCH] kernel/irq: Limit validation of cpumask_var_t to CONFIG_CPUMASK_OFFSTACK=y

Back to article view | Back to linux.kernel

Contents

  [PATCH] kernel/irq: Limit validation of cpumask_var_t to CONFIG_CPUMASK_OFFSTACK=y Matthias Kaehlcke <mka@chromium.org> - 2017-04-12 02:00 +0200
    Re: [PATCH] kernel/irq: Limit validation of cpumask_var_t to  CONFIG_CPUMASK_OFFSTACK=y Thomas Gleixner <tglx@linutronix.de> - 2017-04-12 09:30 +0200
      Re: [PATCH] kernel/irq: Limit validation of cpumask_var_t to  CONFIG_CPUMASK_OFFSTACK=y Matthias Kaehlcke <mka@chromium.org> - 2017-04-12 18:50 +0200

#1621699 — [PATCH] kernel/irq: Limit validation of cpumask_var_t to CONFIG_CPUMASK_OFFSTACK=y

With CONFIG_CPUMASK_OFFSTACK=y cpumask_var_t is a struct cpumask
pointer, otherwise a struct cpumask array with a single element.

irq_thread_check_affinity() validates the cpumask_var_t field in the
interrupt descriptor by checking if it is not NULL. This works for
both CONFIG_CPUMASK_OFFSTACK=y/n, however clang raises the following
warning with CONFIG_CPUMASK_OFFSTACK=n:

kernel/irq/manage.c:839:28: error: address of array
'desc->irq_common_data.affinity' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]

To get rid of the warning only validate the cpumask_var_t field when
CONFIG_CPUMASK_OFFSTACK=y.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 kernel/irq/manage.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index a4afe5cc5af1..5d38fe85122b 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -848,14 +848,14 @@ irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)
 	}
 
 	raw_spin_lock_irq(&desc->lock);
-	/*
-	 * This code is triggered unconditionally. Check the affinity
-	 * mask pointer. For CPU_MASK_OFFSTACK=n this is optimized out.
-	 */
-	if (desc->irq_common_data.affinity)
-		cpumask_copy(mask, desc->irq_common_data.affinity);
-	else
+
+#ifdef CONFIG_CPUMASK_OFFSTACK
+	if (!desc->irq_common_data.affinity)
 		valid = false;
+	else
+#endif
+	cpumask_copy(mask, desc->irq_common_data.affinity);
+
 	raw_spin_unlock_irq(&desc->lock);
 
 	if (valid)
-- 
2.12.2.715.g7642488e1d-goog

[toc] | [next] | [standalone]

#1621874 — Re: [PATCH] kernel/irq: Limit validation of cpumask_var_t to CONFIG_CPUMASK_OFFSTACK=y

On Tue, 11 Apr 2017, Matthias Kaehlcke wrote:
> With CONFIG_CPUMASK_OFFSTACK=y cpumask_var_t is a struct cpumask
> pointer, otherwise a struct cpumask array with a single element.
> 
> irq_thread_check_affinity() validates the cpumask_var_t field in the
> interrupt descriptor by checking if it is not NULL. This works for
> both CONFIG_CPUMASK_OFFSTACK=y/n, however clang raises the following
> warning with CONFIG_CPUMASK_OFFSTACK=n:
> 
> kernel/irq/manage.c:839:28: error: address of array
> 'desc->irq_common_data.affinity' will always evaluate to 'true'
> [-Werror,-Wpointer-bool-conversion]
> 
> To get rid of the warning only validate the cpumask_var_t field when
> CONFIG_CPUMASK_OFFSTACK=y.

This ifdeffery is horrible. Can you please create a helper inline
cpumask_available() or something like that which hides this in a header
file. The irq code is probably not the only place which does this.

Thanks,

	tglx

[toc] | [prev] | [next] | [standalone]

#1622337 — Re: [PATCH] kernel/irq: Limit validation of cpumask_var_t to CONFIG_CPUMASK_OFFSTACK=y

Hi Thomas,

El Wed, Apr 12, 2017 at 09:23:58AM +0200 Thomas Gleixner ha dit:

> On Tue, 11 Apr 2017, Matthias Kaehlcke wrote:
> > With CONFIG_CPUMASK_OFFSTACK=y cpumask_var_t is a struct cpumask
> > pointer, otherwise a struct cpumask array with a single element.
> > 
> > irq_thread_check_affinity() validates the cpumask_var_t field in the
> > interrupt descriptor by checking if it is not NULL. This works for
> > both CONFIG_CPUMASK_OFFSTACK=y/n, however clang raises the following
> > warning with CONFIG_CPUMASK_OFFSTACK=n:
> > 
> > kernel/irq/manage.c:839:28: error: address of array
> > 'desc->irq_common_data.affinity' will always evaluate to 'true'
> > [-Werror,-Wpointer-bool-conversion]
> > 
> > To get rid of the warning only validate the cpumask_var_t field when
> > CONFIG_CPUMASK_OFFSTACK=y.
> 
> This ifdeffery is horrible. Can you please create a helper inline
> cpumask_available() or something like that which hides this in a header
> file. The irq code is probably not the only place which does this.

Thanks for your comments, I'll rework the patch to use a helper
instead.

Cheers

Matthias

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web