Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621614 > unrolled thread
| Started by | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| First post | 2017-04-11 23:00 +0200 |
| Last post | 2017-04-12 16:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Florian Fainelli <f.fainelli@gmail.com> - 2017-04-11 23:00 +0200
Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-12 16:30 +0200
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-04-11 23:00 +0200 |
| Subject | Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY |
| Message-ID | <tvb3k-3yo-31@gated-at.bofh.it> |
On 04/11/2017 01:52 PM, Vivien Didelot wrote: > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, > which is true by default. > > DSA drivers without legacy support don't need the probe function as well > as driver registration helpers anymore, so remove their definitions if > CONFIG_NET_DSA_LEGACY is disabled. > > NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support. BCM_SF2 is not dependent on legacy support since it got converted to the new API in the past few months. You may want to generate your patch with git format-patch -M to help detect renames/code movements. Thanks for doing this! -- Florian
[toc] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-04-12 16:30 +0200 |
| Message-ID | <tvrrs-5xT-7@gated-at.bofh.it> |
| In reply to | #1621614 |
Hi Florian,
Florian Fainelli <f.fainelli@gmail.com> writes:
> On 04/11/2017 01:52 PM, Vivien Didelot wrote:
>> This patch moves as is the legacy DSA code from dsa.c to legacy.c,
>> except the few shared symbols which remain in dsa.c.
>>
>> Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled,
>> which is true by default.
>>
>> DSA drivers without legacy support don't need the probe function as well
>> as driver registration helpers anymore, so remove their definitions if
>> CONFIG_NET_DSA_LEGACY is disabled.
>>
>> NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support.
>
> BCM_SF2 is not dependent on legacy support since it got converted to the
> new API in the past few months.
Oops, my bad. Fixing it.
> You may want to generate your patch with git format-patch -M to help
> detect renames/code movements.
I used --find-copies-harder -C for easier review but I can use -M.
Thanks,
Vivien
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web