Groups > linux.kernel > #1620781 > unrolled thread

Re: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart

Started by	Bart Van Assche <Bart.VanAssche@sandisk.com>
First post	2017-04-11 01:50 +0200
Last post	2017-04-14 01:20 +0200
Articles	2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

  Re: [PATCH] block-mq: set both block queue and hardware queue restart  bit for restart Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-04-11 01:50 +0200
    RE: [PATCH] block-mq: set both block queue and hardware queue restart  bit for restart Long Li <longli@microsoft.com> - 2017-04-14 01:20 +0200

#1620781 — Re: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart

From	Bart Van Assche <Bart.VanAssche@sandisk.com>
Date	2017-04-11 01:50 +0200
Subject	Re: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart
Message-ID	<tuReh-7C4-3@gated-at.bofh.it>

On Thu, 2017-04-06 at 04:21 +0000, KY Srinivasan wrote:
> > -----Original Message-----
> > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> > Sent: Wednesday, April 5, 2017 8:46 PM
> > To: linux-kernel@vger.kernel.org; linux-block@vger.kernel.org; Long Li
> > <longli@microsoft.com>; axboe@kernel.dk
> > Cc: Stephen Hemminger <sthemmin@microsoft.com>; KY Srinivasan
> > <kys@microsoft.com>
> > Subject: Re: [PATCH] block-mq: set both block queue and hardware queue
> > restart bit for restart
> > 
> > On Thu, 2017-04-06 at 03:38 +0000, Long Li wrote:
> > > > -----Original Message-----
> > > > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> > > > 
> > > > Please drop this patch. I'm working on a better solution.
> > > 
> > > Thank you. Looking forward to your patch.
> > 
> > Hello Long,
> > 
> > It would help if you could share the name of the block or SCSI driver with
> > which you ran into that lockup and also if you could share the name of the
> > I/O scheduler used in your test.
> 
> The tests that indicated the issue were run Hyper-V. The driver is storvsc_drv.c
> The I/O scheduler was I think noop.

Hello Long and K.Y.,

Thank you for the feedback. Can you repeat your test with kernel v4.11-rc6? The
patches that went into the block layer for v4.11-rc6 should be sufficient to fix
this:

$ PAGER= git log --format=short v4.11-rc5..v4.11-rc6 block include/linux/blk*  
commit 6d8c6c0f97ad8a3517c42b179c1dc8e77397d0e2
Author: Bart Van Assche <bart.vanassche@sandisk.com>

    blk-mq: Restart a single queue if tag sets are shared

commit 7587a5ae7eef0439f7be31f1b5959af062bbc5ec
Author: Bart Van Assche <bart.vanassche@sandisk.com>

    blk-mq: Introduce blk_mq_delay_run_hw_queue()

commit ebe8bddb6e30d7a02775b9972099271fc5910f37
Author: Omar Sandoval <osandov@fb.com>

    blk-mq: remap queues when adding/removing hardware queues

commit 54d5329d425650fafaf90660a139c771d2d49cae
Author: Omar Sandoval <osandov@fb.com>

    blk-mq-sched: fix crash in switch error path

commit 93252632e828da3e90241a1c0e766556abf71598
Author: Omar Sandoval <osandov@fb.com>

    blk-mq-sched: set up scheduler tags when bringing up new queues

commit 6917ff0b5bd4139e08a3f3146529dcb3b95ba7a6
Author: Omar Sandoval <osandov@fb.com>

    blk-mq-sched: refactor scheduler initialization

commit 81380ca10778b99dce98940cfc993214712df335
Author: Omar Sandoval <osandov@fb.com>

    blk-mq: use the right hctx when getting a driver tag fails

commit ac77a0c463c1d7d659861f7b6d1261970dd3282a
Author: Minchan Kim <minchan@kernel.org>

    block: do not put mq context in blk_mq_alloc_request_hctx

Bart.

[toc] | [next] | [standalone]

#1623416

From	Long Li <longli@microsoft.com>
Date	2017-04-14 01:20 +0200
Message-ID	<tvWbT-1xv-3@gated-at.bofh.it>
In reply to	#1620781


> -----Original Message-----
> From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> Sent: Monday, April 10, 2017 4:48 PM
> To: linux-kernel@vger.kernel.org; linux-block@vger.kernel.org; KY Srinivasan
> <kys@microsoft.com>; Long Li <longli@microsoft.com>; axboe@kernel.dk
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH] block-mq: set both block queue and hardware queue
> restart bit for restart
> 
> On Thu, 2017-04-06 at 04:21 +0000, KY Srinivasan wrote:
> > > -----Original Message-----
> > > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> > > Sent: Wednesday, April 5, 2017 8:46 PM
> > > To: linux-kernel@vger.kernel.org; linux-block@vger.kernel.org; Long
> > > Li <longli@microsoft.com>; axboe@kernel.dk
> > > Cc: Stephen Hemminger <sthemmin@microsoft.com>; KY Srinivasan
> > > <kys@microsoft.com>
> > > Subject: Re: [PATCH] block-mq: set both block queue and hardware
> > > queue restart bit for restart
> > >
> > > On Thu, 2017-04-06 at 03:38 +0000, Long Li wrote:
> > > > > -----Original Message-----
> > > > > From: Bart Van Assche [mailto:Bart.VanAssche@sandisk.com]
> > > > >
> > > > > Please drop this patch. I'm working on a better solution.
> > > >
> > > > Thank you. Looking forward to your patch.
> > >
> > > Hello Long,
> > >
> > > It would help if you could share the name of the block or SCSI
> > > driver with which you ran into that lockup and also if you could
> > > share the name of the I/O scheduler used in your test.
> >
> > The tests that indicated the issue were run Hyper-V. The driver is
> > storvsc_drv.c The I/O scheduler was I think noop.
> 
> Hello Long and K.Y.,
> 
> Thank you for the feedback. Can you repeat your test with kernel v4.11-rc6?
> The patches that went into the block layer for v4.11-rc6 should be sufficient
> to fix
> this:
> 
> $ PAGER= git log --format=short v4.11-rc5..v4.11-rc6 block include/linux/blk*
> commit 6d8c6c0f97ad8a3517c42b179c1dc8e77397d0e2
> Author: Bart Van Assche <bart.vanassche@sandisk.com>
> 
>     blk-mq: Restart a single queue if tag sets are shared
> 
> commit 7587a5ae7eef0439f7be31f1b5959af062bbc5ec
> Author: Bart Van Assche <bart.vanassche@sandisk.com>
> 
>     blk-mq: Introduce blk_mq_delay_run_hw_queue()
> 
> commit ebe8bddb6e30d7a02775b9972099271fc5910f37
> Author: Omar Sandoval <osandov@fb.com>
> 
>     blk-mq: remap queues when adding/removing hardware queues
> 
> commit 54d5329d425650fafaf90660a139c771d2d49cae
> Author: Omar Sandoval <osandov@fb.com>
> 
>     blk-mq-sched: fix crash in switch error path
> 
> commit 93252632e828da3e90241a1c0e766556abf71598
> Author: Omar Sandoval <osandov@fb.com>
> 
>     blk-mq-sched: set up scheduler tags when bringing up new queues
> 
> commit 6917ff0b5bd4139e08a3f3146529dcb3b95ba7a6
> Author: Omar Sandoval <osandov@fb.com>
> 
>     blk-mq-sched: refactor scheduler initialization
> 
> commit 81380ca10778b99dce98940cfc993214712df335
> Author: Omar Sandoval <osandov@fb.com>
> 
>     blk-mq: use the right hctx when getting a driver tag fails
> 
> commit ac77a0c463c1d7d659861f7b6d1261970dd3282a
> Author: Minchan Kim <minchan@kernel.org>
> 
>     block: do not put mq context in blk_mq_alloc_request_hctx
> 
> Bart.

Thank you. We are doing tests. I will update on the results.

Long

[toc] | [prev] | [standalone]

csiph-web

Re: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart

Contents

#1620781 — Re: [PATCH] block-mq: set both block queue and hardware queue restart bit for restart

#1623416