Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623185 > unrolled thread

[PATCH 0/4] selftests: Fix trivial nitpicks

Started bySeongJae Park <sj38.park@gmail.com>
First post2017-04-13 19:00 +0200
Last post2017-04-14 01:50 +0200
Articles 9 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/4] selftests: Fix trivial nitpicks SeongJae Park <sj38.park@gmail.com> - 2017-04-13 19:00 +0200
    [PATCH 2/4] selftests/Makefile: Add missed PHONY targets SeongJae Park <sj38.park@gmail.com> - 2017-04-13 19:00 +0200
      Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets Shuah Khan <shuah@kernel.org> - 2017-04-14 00:10 +0200
        Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets SeongJae Park <sj38.park@gmail.com> - 2017-04-14 01:50 +0200
    [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment SeongJae Park <sj38.park@gmail.com> - 2017-04-13 19:00 +0200
      Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment Shuah Khan <shuah@kernel.org> - 2017-04-14 00:10 +0200
        Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment SeongJae Park <sj38.park@gmail.com> - 2017-04-14 01:40 +0200
          [PATCH v2] selftests/Makefile: Add missed closing `"` in comment SeongJae Park <sj38.park@gmail.com> - 2017-04-14 01:50 +0200
          [PATCH v2] selftests/Makefile: Add missed PHONY targets SeongJae Park <sj38.park@gmail.com> - 2017-04-14 01:50 +0200

#1623185 — [PATCH 0/4] selftests: Fix trivial nitpicks

FromSeongJae Park <sj38.park@gmail.com>
Date2017-04-13 19:00 +0200
Subject[PATCH 0/4] selftests: Fix trivial nitpicks
Message-ID<tvQg9-5H7-7@gated-at.bofh.it>
This patchset fixes trivial nitpicks under selftests.

SeongJae Park (4):
  selftests/Makefile: Add missed closing `"` in comment
  selftests/Makefile: Add missed PHONY targets
  selftests/vm/run_vmtests: Polish output text
  selftests/vm/run_vmtests: Fix wrong comment

 tools/testing/selftests/Makefile       |  4 ++--
 tools/testing/selftests/vm/run_vmtests | 26 +++++++++++++-------------
 2 files changed, 15 insertions(+), 15 deletions(-)

-- 
2.12.0

[toc] | [next] | [standalone]

#1623187 — [PATCH 2/4] selftests/Makefile: Add missed PHONY targets

FromSeongJae Park <sj38.park@gmail.com>
Date2017-04-13 19:00 +0200
Subject[PATCH 2/4] selftests/Makefile: Add missed PHONY targets
Message-ID<tvQg9-5H7-11@gated-at.bofh.it>
In reply to#1623185
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 395ab296c084..26ce4f7168be 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -133,4 +133,4 @@ clean:
 		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;
 
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
-- 
2.12.0

[toc] | [prev] | [next] | [standalone]

#1623382 — Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets

FromShuah Khan <shuah@kernel.org>
Date2017-04-14 00:10 +0200
SubjectRe: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets
Message-ID<tvV6a-P8-25@gated-at.bofh.it>
In reply to#1623187
On 04/13/2017 10:56 AM, SeongJae Park wrote:
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
>  tools/testing/selftests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 395ab296c084..26ce4f7168be 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -133,4 +133,4 @@ clean:
>  		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
>  	done;
>  
> -.PHONY: install
> +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
> 

Missing changelog - please add and resend.

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1623438 — Re: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets

FromSeongJae Park <sj38.park@gmail.com>
Date2017-04-14 01:50 +0200
SubjectRe: [PATCH 2/4] selftests/Makefile: Add missed PHONY targets
Message-ID<tvWEV-1Js-9@gated-at.bofh.it>
In reply to#1623382
On Fri, Apr 14, 2017 at 7:03 AM, Shuah Khan <shuah@kernel.org> wrote:
> On 04/13/2017 10:56 AM, SeongJae Park wrote:
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>>  tools/testing/selftests/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index 395ab296c084..26ce4f7168be 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -133,4 +133,4 @@ clean:
>>               make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
>>       done;
>>
>> -.PHONY: install
>> +.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
>>
>
> Missing changelog - please add and resend.

Ok, I will send it as a reply to this.


Thanks,
SeongJae Park

>
> thanks,
> -- Shuah

[toc] | [prev] | [next] | [standalone]

#1623191 — [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment

FromSeongJae Park <sj38.park@gmail.com>
Date2017-04-13 19:00 +0200
Subject[PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
Message-ID<tvQga-5H7-25@gated-at.bofh.it>
In reply to#1623185
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index d8593f1251ec..395ab296c084 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -39,7 +39,7 @@ TARGETS += x86
 TARGETS += zram
 #Please keep the TARGETS list alphabetically sorted
 # Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
 
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug
-- 
2.12.0

[toc] | [prev] | [next] | [standalone]

#1623374 — Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment

FromShuah Khan <shuah@kernel.org>
Date2017-04-14 00:10 +0200
SubjectRe: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
Message-ID<tvV69-P8-1@gated-at.bofh.it>
In reply to#1623191
On 04/13/2017 10:56 AM, SeongJae Park wrote:
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
>  tools/testing/selftests/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index d8593f1251ec..395ab296c084 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -39,7 +39,7 @@ TARGETS += x86
>  TARGETS += zram
>  #Please keep the TARGETS list alphabetically sorted
>  # Run "make quicktest=1 run_tests" or
> -# "make quicktest=1 kselftest from top level Makefile
> +# "make quicktest=1 kselftest" from top level Makefile
>  
>  TARGETS_HOTPLUG = cpu-hotplug
>  TARGETS_HOTPLUG += memory-hotplug
> 

This patch is missing changelog - please add and resend.

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1623427 — Re: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment

FromSeongJae Park <sj38.park@gmail.com>
Date2017-04-14 01:40 +0200
SubjectRe: [PATCH 1/4] selftests/Makefile: Add missed closing `"` in comment
Message-ID<tvWvf-1Fj-5@gated-at.bofh.it>
In reply to#1623374
On Fri, Apr 14, 2017 at 7:02 AM, Shuah Khan <shuah@kernel.org> wrote:
> On 04/13/2017 10:56 AM, SeongJae Park wrote:
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>>  tools/testing/selftests/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
>> index d8593f1251ec..395ab296c084 100644
>> --- a/tools/testing/selftests/Makefile
>> +++ b/tools/testing/selftests/Makefile
>> @@ -39,7 +39,7 @@ TARGETS += x86
>>  TARGETS += zram
>>  #Please keep the TARGETS list alphabetically sorted
>>  # Run "make quicktest=1 run_tests" or
>> -# "make quicktest=1 kselftest from top level Makefile
>> +# "make quicktest=1 kselftest" from top level Makefile
>>
>>  TARGETS_HOTPLUG = cpu-hotplug
>>  TARGETS_HOTPLUG += memory-hotplug
>>
>
> This patch is missing changelog - please add and resend.

OK, I will resend it as a reply to this.


Thanks,
SeongJae Park

>
> thanks,
> -- Shuah

[toc] | [prev] | [next] | [standalone]

#1623430 — [PATCH v2] selftests/Makefile: Add missed closing `"` in comment

FromSeongJae Park <sj38.park@gmail.com>
Date2017-04-14 01:50 +0200
Subject[PATCH v2] selftests/Makefile: Add missed closing `"` in comment
Message-ID<tvWEV-1Js-1@gated-at.bofh.it>
In reply to#1623427
A comment for make command usage in `selftets/Makefile` has opening `"`
but no closing `"`.  This commit adds the missed `"` in the comment.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index d8593f1251ec..395ab296c084 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -39,7 +39,7 @@ TARGETS += x86
 TARGETS += zram
 #Please keep the TARGETS list alphabetically sorted
 # Run "make quicktest=1 run_tests" or
-# "make quicktest=1 kselftest from top level Makefile
+# "make quicktest=1 kselftest" from top level Makefile
 
 TARGETS_HOTPLUG = cpu-hotplug
 TARGETS_HOTPLUG += memory-hotplug
-- 
2.12.0

[toc] | [prev] | [next] | [standalone]

#1623432 — [PATCH v2] selftests/Makefile: Add missed PHONY targets

FromSeongJae Park <sj38.park@gmail.com>
Date2017-04-14 01:50 +0200
Subject[PATCH v2] selftests/Makefile: Add missed PHONY targets
Message-ID<tvWEV-1Js-15@gated-at.bofh.it>
In reply to#1623427
`selftests/Makefile` is defining only `install` as entire PHONY target
though there are few more PHONY targets including `run_tests`.  This
commit defines them as the PHONY targets.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 395ab296c084..26ce4f7168be 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -133,4 +133,4 @@ clean:
 		make OUTPUT=$$BUILD_TARGET -C $$TARGET clean;\
 	done;
 
-.PHONY: install
+.PHONY: all run_tests hotplug run_hotplug clean_hotplug run_pstore_crash install clean
-- 
2.12.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web