Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1623210 > unrolled thread

[PATCH] x86/kbuild: Use cc-option to enable -falign-{jumps/loops}

Started byMatthias Kaehlcke <mka@chromium.org>
First post2017-04-13 19:30 +0200
Last post2017-04-18 09:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] x86/kbuild: Use cc-option to enable -falign-{jumps/loops} Matthias Kaehlcke <mka@chromium.org> - 2017-04-13 19:30 +0200
    [tip:x86/build] x86/kbuild: Use cc-option to enable  -falign-{jumps/loops} tip-bot for Matthias Kaehlcke <tipbot@zytor.com> - 2017-04-18 09:40 +0200

#1623210 — [PATCH] x86/kbuild: Use cc-option to enable -falign-{jumps/loops}

FromMatthias Kaehlcke <mka@chromium.org>
Date2017-04-13 19:30 +0200
Subject[PATCH] x86/kbuild: Use cc-option to enable -falign-{jumps/loops}
Message-ID<tvQJb-6ae-3@gated-at.bofh.it>
clang currently does not support these optimizations, only enable them
when they are available.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 arch/x86/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index a94a4d10f2df..73604e18447a 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -88,10 +88,10 @@ else
         KBUILD_CFLAGS += -m64
 
         # Align jump targets to 1 byte, not the default 16 bytes:
-        KBUILD_CFLAGS += -falign-jumps=1
+        KBUILD_CFLAGS += $(call cc-option,-falign-jumps=1)
 
         # Pack loops tightly as well:
-        KBUILD_CFLAGS += -falign-loops=1
+        KBUILD_CFLAGS += $(call cc-option,-falign-loops=1)
 
         # Don't autogenerate traditional x87 instructions
         KBUILD_CFLAGS += $(call cc-option,-mno-80387)
-- 
2.12.2.715.g7642488e1d-goog

[toc] | [next] | [standalone]


#1625102 — [tip:x86/build] x86/kbuild: Use cc-option to enable -falign-{jumps/loops}

Fromtip-bot for Matthias Kaehlcke <tipbot@zytor.com>
Date2017-04-18 09:40 +0200
Subject[tip:x86/build] x86/kbuild: Use cc-option to enable -falign-{jumps/loops}
Message-ID<txvTX-3om-9@gated-at.bofh.it>
In reply to#1623210
Commit-ID:  2c4fd1ac3ff167c91272dc43c7bfd2269ef61557
Gitweb:     http://git.kernel.org/tip/2c4fd1ac3ff167c91272dc43c7bfd2269ef61557
Author:     Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Thu, 13 Apr 2017 10:26:09 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 17 Apr 2017 12:39:37 +0200

x86/kbuild: Use cc-option to enable -falign-{jumps/loops}

clang currently does not support these optimizations, only enable them
when they are available.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Greg Hackmann <ghackmann@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michael Davidson <md@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: grundler@chromium.org
Link: http://lkml.kernel.org/r/20170413172609.118122-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index a94a4d1..73604e1 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -88,10 +88,10 @@ else
         KBUILD_CFLAGS += -m64
 
         # Align jump targets to 1 byte, not the default 16 bytes:
-        KBUILD_CFLAGS += -falign-jumps=1
+        KBUILD_CFLAGS += $(call cc-option,-falign-jumps=1)
 
         # Pack loops tightly as well:
-        KBUILD_CFLAGS += -falign-loops=1
+        KBUILD_CFLAGS += $(call cc-option,-falign-loops=1)
 
         # Don't autogenerate traditional x87 instructions
         KBUILD_CFLAGS += $(call cc-option,-mno-80387)

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web