Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1623057 > unrolled thread
| Started by | Alex Shi <alex.shi@linaro.org> |
|---|---|
| First post | 2017-04-13 16:10 +0200 |
| Last post | 2017-04-13 18:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi <alex.shi@linaro.org> - 2017-04-13 16:10 +0200
Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio Steven Rostedt <rostedt@goodmis.org> - 2017-04-13 18:20 +0200
| From | Alex Shi <alex.shi@linaro.org> |
|---|---|
| Date | 2017-04-13 16:10 +0200 |
| Subject | [PATCH 3/3] rtmutex: remove unnecessary adjust prio |
| Message-ID | <tvNBD-43N-7@gated-at.bofh.it> |
We don't need to adjust prio before new pi_waiter adding. The prio only need update after pi_waiter change or task normal_prio change. Signed-off-by: Alex Shi <alex.shi@linaro.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Sebastian Siewior <bigeasy@linutronix.de> To: linux-kernel@vger.kernel.org To: Ingo Molnar <mingo@redhat.com> To: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> --- kernel/locking/rtmutex.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index 05ff685..3ee8bc1 100644 --- a/kernel/locking/rtmutex.c +++ b/kernel/locking/rtmutex.c @@ -973,7 +973,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, return -EDEADLK; raw_spin_lock(&task->pi_lock); - __rt_mutex_adjust_prio(task); waiter->task = task; waiter->lock = lock; waiter->prio = task->prio; -- 1.9.1
[toc] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2017-04-13 18:20 +0200 |
| Message-ID | <tvPDs-5oA-7@gated-at.bofh.it> |
| In reply to | #1623057 |
On Thu, 13 Apr 2017 22:02:54 +0800 Alex Shi <alex.shi@linaro.org> wrote: > We don't need to adjust prio before new pi_waiter adding. The prio > only need update after pi_waiter change or task normal_prio change. > > Signed-off-by: Alex Shi <alex.shi@linaro.org> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Sebastian Siewior <bigeasy@linutronix.de> > To: linux-kernel@vger.kernel.org > To: Ingo Molnar <mingo@redhat.com> > To: Peter Zijlstra <peterz@infradead.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > --- > kernel/locking/rtmutex.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c > index 05ff685..3ee8bc1 100644 > --- a/kernel/locking/rtmutex.c > +++ b/kernel/locking/rtmutex.c > @@ -973,7 +973,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, > return -EDEADLK; > > raw_spin_lock(&task->pi_lock); > - __rt_mutex_adjust_prio(task); Yeah, I'm not sure why this is called here. -- Steve > waiter->task = task; > waiter->lock = lock; > waiter->prio = task->prio;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web