Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623008 > unrolled thread

Re: [PATCH] mwifiex: MAC randomization should not be persistent

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mwifiex: MAC randomization should not be persistent Kalle Valo <kvalo@codeaurora.org> - 2017-04-13 15:20 +0200

#1623008 — Re: [PATCH] mwifiex: MAC randomization should not be persistent

Brian Norris <briannorris@chromium.org> writes:

> On Thu, Apr 06, 2017 at 07:02:15AM +0300, Kalle Valo wrote:
>> Brian Norris <briannorris@chromium.org> writes:
>> 
>> > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan
>> > request that should be randomized; the absence of such a flag means we
>> > should not randomize. However, mwifiex was stashing the latest
>> > randomization request and *always* using it for future scans, even those
>> > that didn't set the flag.
>> >
>> > Let's zero out the randomization info whenever we get a scan request
>> > without NL80211_SCAN_FLAG_RANDOM_ADDR. I'd prefer to remove
>> > priv->random_mac entirely (and plumb the randomization MAC properly
>> > through the call sequence), but the spaghetti is a little difficult to
>> > unravel here for me.
>> >
>> > Fixes: c2a8f0ff9c6c ("mwifiex: support random MAC address for scanning")
>> 
>> So the first release with this was v4.9.
>> 
>> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>> > ---
>> > Should this be tagged for -stable?
>> 
>> IMHO yes.
>
> Sounds fine to me. I suppose you'll do this when applying? Or I can
> resend...

I can add this:

Cc: <stable@vger.kernel.org> # 4.9+

-- 
Kalle Valo

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web