Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1622947 > unrolled thread
| Started by | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| First post | 2017-04-13 13:50 +0200 |
| Last post | 2017-04-14 07:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] phy: qcom-usb-hs: Replace the extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-04-13 13:50 +0200
Re: [PATCH 1/2] phy: qcom-usb-hs: Replace the extcon API Chanwoo Choi <cw00.choi@samsung.com> - 2017-04-14 02:50 +0200
Re: [PATCH 1/2] phy: qcom-usb-hs: Replace the extcon API Kishon Vijay Abraham I <kishon@ti.com> - 2017-04-14 07:00 +0200
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-04-13 13:50 +0200 |
| Subject | Re: [PATCH 1/2] phy: qcom-usb-hs: Replace the extcon API |
| Message-ID | <tvLqa-2qX-3@gated-at.bofh.it> |
Hi Chanwoo,
On Tuesday 28 March 2017 10:08 AM, Chanwoo Choi wrote:
> This patch uses the resource-managed extcon API for extcon_register_notifier()
> and replaces the deprecated extcon API as following:
> - (deprecated) extcon_get_cable_state_() -> extcon_get_state()
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
I've missed merging this patch for the next merge window. If you want to take
this yourself.
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Thanks
Kishon
> ---
> drivers/phy/phy-qcom-usb-hs.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/phy/phy-qcom-usb-hs.c b/drivers/phy/phy-qcom-usb-hs.c
> index 94dfbfd739c3..f630fa553b7d 100644
> --- a/drivers/phy/phy-qcom-usb-hs.c
> +++ b/drivers/phy/phy-qcom-usb-hs.c
> @@ -156,12 +156,12 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
> }
>
> if (uphy->vbus_edev) {
> - state = extcon_get_cable_state_(uphy->vbus_edev, EXTCON_USB);
> + state = extcon_get_state(uphy->vbus_edev, EXTCON_USB);
> /* setup initial state */
> qcom_usb_hs_phy_vbus_notifier(&uphy->vbus_notify, state,
> uphy->vbus_edev);
> - ret = extcon_register_notifier(uphy->vbus_edev, EXTCON_USB,
> - &uphy->vbus_notify);
> + ret = devm_extcon_register_notifier(&ulpi->dev, uphy->vbus_edev,
> + EXTCON_USB, &uphy->vbus_notify);
> if (ret)
> goto err_ulpi;
> }
> @@ -180,16 +180,8 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
>
> static int qcom_usb_hs_phy_power_off(struct phy *phy)
> {
> - int ret;
> struct qcom_usb_hs_phy *uphy = phy_get_drvdata(phy);
>
> - if (uphy->vbus_edev) {
> - ret = extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB,
> - &uphy->vbus_notify);
> - if (ret)
> - return ret;
> - }
> -
> regulator_disable(uphy->v3p3);
> regulator_disable(uphy->v1p8);
> clk_disable_unprepare(uphy->sleep_clk);
>
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2017-04-14 02:50 +0200 |
| Message-ID | <tvXAZ-2mH-5@gated-at.bofh.it> |
| In reply to | #1622947 |
Hi Kishon,
On 2017년 04월 13일 20:47, Kishon Vijay Abraham I wrote:
> Hi Chanwoo,
>
> On Tuesday 28 March 2017 10:08 AM, Chanwoo Choi wrote:
>> This patch uses the resource-managed extcon API for extcon_register_notifier()
>> and replaces the deprecated extcon API as following:
>> - (deprecated) extcon_get_cable_state_() -> extcon_get_state()
>>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> I've missed merging this patch for the next merge window. If you want to take
> this yourself.
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
I already posted the pull-request to GregKH for extcon subsystem.
So, if possible, I hope you handle these patches.
Even if these patches are not merged to 4.12-rc1, I'm ok.
Just I want to handle them on your tree for next time.
>
> Thanks
> Kishon
>> ---
>> drivers/phy/phy-qcom-usb-hs.c | 14 +++-----------
>> 1 file changed, 3 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/phy/phy-qcom-usb-hs.c b/drivers/phy/phy-qcom-usb-hs.c
>> index 94dfbfd739c3..f630fa553b7d 100644
>> --- a/drivers/phy/phy-qcom-usb-hs.c
>> +++ b/drivers/phy/phy-qcom-usb-hs.c
>> @@ -156,12 +156,12 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
>> }
>>
>> if (uphy->vbus_edev) {
>> - state = extcon_get_cable_state_(uphy->vbus_edev, EXTCON_USB);
>> + state = extcon_get_state(uphy->vbus_edev, EXTCON_USB);
>> /* setup initial state */
>> qcom_usb_hs_phy_vbus_notifier(&uphy->vbus_notify, state,
>> uphy->vbus_edev);
>> - ret = extcon_register_notifier(uphy->vbus_edev, EXTCON_USB,
>> - &uphy->vbus_notify);
>> + ret = devm_extcon_register_notifier(&ulpi->dev, uphy->vbus_edev,
>> + EXTCON_USB, &uphy->vbus_notify);
>> if (ret)
>> goto err_ulpi;
>> }
>> @@ -180,16 +180,8 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
>>
>> static int qcom_usb_hs_phy_power_off(struct phy *phy)
>> {
>> - int ret;
>> struct qcom_usb_hs_phy *uphy = phy_get_drvdata(phy);
>>
>> - if (uphy->vbus_edev) {
>> - ret = extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB,
>> - &uphy->vbus_notify);
>> - if (ret)
>> - return ret;
>> - }
>> -
>> regulator_disable(uphy->v3p3);
>> regulator_disable(uphy->v1p8);
>> clk_disable_unprepare(uphy->sleep_clk);
>>
>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
[toc] | [prev] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-04-14 07:00 +0200 |
| Message-ID | <tw1uV-55U-1@gated-at.bofh.it> |
| In reply to | #1623447 |
hi Chanwoo,
On Friday 14 April 2017 06:13 AM, Chanwoo Choi wrote:
> Hi Kishon,
>
> On 2017년 04월 13일 20:47, Kishon Vijay Abraham I wrote:
>> Hi Chanwoo,
>>
>> On Tuesday 28 March 2017 10:08 AM, Chanwoo Choi wrote:
>>> This patch uses the resource-managed extcon API for extcon_register_notifier()
>>> and replaces the deprecated extcon API as following:
>>> - (deprecated) extcon_get_cable_state_() -> extcon_get_state()
>>>
>>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> I've missed merging this patch for the next merge window. If you want to take
>> this yourself.
>> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> I already posted the pull-request to GregKH for extcon subsystem.
> So, if possible, I hope you handle these patches.
> Even if these patches are not merged to 4.12-rc1, I'm ok.
> Just I want to handle them on your tree for next time.
Sure, I'll take them then.
Thanks
Kishon
>
>>
>> Thanks
>> Kishon
>>> ---
>>> drivers/phy/phy-qcom-usb-hs.c | 14 +++-----------
>>> 1 file changed, 3 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/drivers/phy/phy-qcom-usb-hs.c b/drivers/phy/phy-qcom-usb-hs.c
>>> index 94dfbfd739c3..f630fa553b7d 100644
>>> --- a/drivers/phy/phy-qcom-usb-hs.c
>>> +++ b/drivers/phy/phy-qcom-usb-hs.c
>>> @@ -156,12 +156,12 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
>>> }
>>>
>>> if (uphy->vbus_edev) {
>>> - state = extcon_get_cable_state_(uphy->vbus_edev, EXTCON_USB);
>>> + state = extcon_get_state(uphy->vbus_edev, EXTCON_USB);
>>> /* setup initial state */
>>> qcom_usb_hs_phy_vbus_notifier(&uphy->vbus_notify, state,
>>> uphy->vbus_edev);
>>> - ret = extcon_register_notifier(uphy->vbus_edev, EXTCON_USB,
>>> - &uphy->vbus_notify);
>>> + ret = devm_extcon_register_notifier(&ulpi->dev, uphy->vbus_edev,
>>> + EXTCON_USB, &uphy->vbus_notify);
>>> if (ret)
>>> goto err_ulpi;
>>> }
>>> @@ -180,16 +180,8 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy)
>>>
>>> static int qcom_usb_hs_phy_power_off(struct phy *phy)
>>> {
>>> - int ret;
>>> struct qcom_usb_hs_phy *uphy = phy_get_drvdata(phy);
>>>
>>> - if (uphy->vbus_edev) {
>>> - ret = extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB,
>>> - &uphy->vbus_notify);
>>> - if (ret)
>>> - return ret;
>>> - }
>>> -
>>> regulator_disable(uphy->v3p3);
>>> regulator_disable(uphy->v1p8);
>>> clk_disable_unprepare(uphy->sleep_clk);
>>>
>>
>>
>>
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web