Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1622135 > unrolled thread

Re: [PATCH v3] arm64: dts: rk3399: add support for firefly-rk3399 board

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3] arm64: dts: rk3399: add support for firefly-rk3399 board Heiko Stuebner <heiko@sntech.de> - 2017-04-12 15:30 +0200
    Re: [PATCH v3] arm64: dts: rk3399: add support for firefly-rk3399  board Kever Yang <kever.yang@rock-chips.com> - 2017-04-13 06:10 +0200
      Re: [PATCH v3] arm64: dts: rk3399: add support for firefly-rk3399 board Heiko Stübner <heiko@sntech.de> - 2017-04-13 10:30 +0200

#1622135 — Re: [PATCH v3] arm64: dts: rk3399: add support for firefly-rk3399 board

Hi Kever,

Am Montag, 10. April 2017, 11:50:13 CEST schrieb Kever Yang:
> Firefly-rk3399 is a bord from T-Firefly, you can find detail about
> it here:
> http://en.t-firefly.com/en/firenow/Firefly_RK3399/
> 
> This patch add basic node for the board and make it able to bring
> up.
> 
> Peripheral works:
> - usb hub which connect to ehci controller;
> - UART2 debug
> - eMMC
> - PCIe
> 
> Not work:
> - USB 3.0 HOST, type-C port
> - sdio, sd-card
> 
> Not test for other peripheral:
> - HDMI
> - Ethernet
> - OPTICAL
> - WiFi/BT
> - MIPI CSI/DSI
> - IR
> - EDP/DP
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

applied for 4.13, as we're a bit late for 4.12, with the following changes:
- commit subject
- dropped status from backlight (as there is no disabled common node
  and it's specific to the firefly itself)
- quite some reordering of properties
- reordered regulator nodes per their addresses: 0x1b < 0x40
- dropped obsolete regulator-compatible properties
- fixed gpio-irq on the mpu6500
- dropped out-of-tree orientation properties of mpu6500
  --> please provide the optional "mount-matrix" in a follow-up patch
      see bindings/iio/imu/inv_mpu6050.txt
- dropped rockchip,i2s-broken-burst-len;
  That change never made it into the mainline kernel
- fixed pcie pinctrl indentation
- dropped wireless-bluetooth uart-gpios pinctrl
- dropped supports-emmc property

Please try to be a bit more careful when porting stuff from device kernels
with respect to properties not found in the mainline kernel and please
also double-check in [0] that I didn't break anything.


Thanks
Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=495a3c891a696b62465d71b1a125e3424352028b

[toc] | [next] | [standalone]

#1622701 — Re: [PATCH v3] arm64: dts: rk3399: add support for firefly-rk3399 board

Hi Heiko,


On 04/12/2017 09:29 PM, Heiko Stuebner wrote:
> Hi Kever,
>
> Am Montag, 10. April 2017, 11:50:13 CEST schrieb Kever Yang:
>> Firefly-rk3399 is a bord from T-Firefly, you can find detail about
>> it here:
>> http://en.t-firefly.com/en/firenow/Firefly_RK3399/
>>
>> This patch add basic node for the board and make it able to bring
>> up.
>>
>> Peripheral works:
>> - usb hub which connect to ehci controller;
>> - UART2 debug
>> - eMMC
>> - PCIe
>>
>> Not work:
>> - USB 3.0 HOST, type-C port
>> - sdio, sd-card
>>
>> Not test for other peripheral:
>> - HDMI
>> - Ethernet
>> - OPTICAL
>> - WiFi/BT
>> - MIPI CSI/DSI
>> - IR
>> - EDP/DP
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> applied for 4.13, as we're a bit late for 4.12, with the following changes:

Thanks for your help, I'm not familiar with the devices status on upstream
because not working on kernel upstream for a long time.
> - commit subject
> - dropped status from backlight (as there is no disabled common node
>    and it's specific to the firefly itself)
> - quite some reordering of properties
> - reordered regulator nodes per their addresses: 0x1b < 0x40
> - dropped obsolete regulator-compatible properties
> - fixed gpio-irq on the mpu6500
> - dropped out-of-tree orientation properties of mpu6500
>    --> please provide the optional "mount-matrix" in a follow-up patch
>        see bindings/iio/imu/inv_mpu6050.txt

Maybe we can drop this mpu6050 node first? I can't find binding file for it.
> - dropped rockchip,i2s-broken-burst-len;
>    That change never made it into the mainline kernel
> - fixed pcie pinctrl indentation
> - dropped wireless-bluetooth uart-gpios pinctrl
> - dropped supports-emmc property
>
> Please try to be a bit more careful when porting stuff from device kernels
> with respect to properties not found in the mainline kernel and please
> also double-check in [0] that I didn't break anything.

I have test this patch on my firefly-rk3399, it works fine with pwm2 
regulator
init in U-Boot.

Thanks,
- Kever
>
>
> Thanks
> Heiko
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=495a3c891a696b62465d71b1a125e3424352028b
>
>

[toc] | [prev] | [next] | [standalone]

#1622811

Am Donnerstag, 13. April 2017, 12:00:19 CEST schrieb Kever Yang:
> Hi Heiko,
> 
> On 04/12/2017 09:29 PM, Heiko Stuebner wrote:
> > Hi Kever,
> > 
> > Am Montag, 10. April 2017, 11:50:13 CEST schrieb Kever Yang:
> >> Firefly-rk3399 is a bord from T-Firefly, you can find detail about
> >> it here:
> >> http://en.t-firefly.com/en/firenow/Firefly_RK3399/
> >> 
> >> This patch add basic node for the board and make it able to bring
> >> up.
> >> 
> >> Peripheral works:
> >> - usb hub which connect to ehci controller;
> >> - UART2 debug
> >> - eMMC
> >> - PCIe
> >> 
> >> Not work:
> >> - USB 3.0 HOST, type-C port
> >> - sdio, sd-card
> >> 
> >> Not test for other peripheral:
> >> - HDMI
> >> - Ethernet
> >> - OPTICAL
> >> - WiFi/BT
> >> - MIPI CSI/DSI
> >> - IR
> >> - EDP/DP
> >> 
> >> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> > 
> > applied for 4.13, as we're a bit late for 4.12, with the following 
changes:
> Thanks for your help, I'm not familiar with the devices status on upstream
> because not working on kernel upstream for a long time.
> 
> > - commit subject
> > - dropped status from backlight (as there is no disabled common node
> > 
> >    and it's specific to the firefly itself)
> > 
> > - quite some reordering of properties
> > - reordered regulator nodes per their addresses: 0x1b < 0x40
> > - dropped obsolete regulator-compatible properties
> > - fixed gpio-irq on the mpu6500
> > - dropped out-of-tree orientation properties of mpu6500
> > 
> >    --> please provide the optional "mount-matrix" in a follow-up patch
> >    
> >        see bindings/iio/imu/inv_mpu6050.txt
> 
> Maybe we can drop this mpu6050 node first? I can't find binding file for it.

The binding (and driver in the kernel) is the same as for the mpu6050.
So you can find the documentation in
Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt

Someone should add the other ids from 
drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
to the binding.

mount-matrix is optional, so the basic node itself can stay in the dt.


Heiko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web