Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1622637 > unrolled thread

Re: [PATCH v2] scsi/bfa: use designated initializers

Started byKees Cook <keescook@chromium.org>
First post2017-04-13 02:30 +0200
Last post2017-04-13 09:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2] scsi/bfa: use designated initializers Kees Cook <keescook@chromium.org> - 2017-04-13 02:30 +0200
    Re: [PATCH v2] scsi/bfa: use designated initializers Christoph Hellwig <hch@lst.de> - 2017-04-13 09:10 +0200

#1622637 — Re: [PATCH v2] scsi/bfa: use designated initializers

FromKees Cook <keescook@chromium.org>
Date2017-04-13 02:30 +0200
SubjectRe: [PATCH v2] scsi/bfa: use designated initializers
Message-ID<tvAO5-3w4-5@gated-at.bofh.it>
On Thu, Mar 30, 2017 at 1:18 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Mar 29, 2017 at 01:55:09PM -0700, Kees Cook wrote:
>> Prepare to mark sensitive kernel structures for randomization by making
>> sure they're using designated initializers. These were identified during
>> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
>> extracted from grsecurity.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> This has been updated now that struct bfa_fcs_mod_s was dropped.
>
> Can you also add designated array initializers for __port_action while
> you're at it?

Hrm? This is what the patch already does. It adds them for both
__port_action and struct bfa_module_s.

-Kees

-- 
Kees Cook
Pixel Security

[toc] | [next] | [standalone]


#1622765

FromChristoph Hellwig <hch@lst.de>
Date2017-04-13 09:10 +0200
Message-ID<tvH3c-7S2-17@gated-at.bofh.it>
In reply to#1622637
On Wed, Apr 12, 2017 at 05:21:20PM -0700, Kees Cook wrote:
> Hrm? This is what the patch already does. It adds them for both
> __port_action and struct bfa_module_s.

For __port_action it only uses designated initializers for the
structures in the array, not the array itself.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web