Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1621575 > unrolled thread
| Started by | Wei Wang <wvw@google.com> |
|---|---|
| First post | 2017-04-11 21:20 +0200 |
| Last post | 2017-04-11 21:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] checkpatch: special audit for revert commit line Wei Wang <wvw@google.com> - 2017-04-11 21:20 +0200
Re: [PATCH v2] checkpatch: special audit for revert commit line Joe Perches <joe@perches.com> - 2017-04-11 21:30 +0200
| From | Wei Wang <wvw@google.com> |
|---|---|
| Date | 2017-04-11 21:20 +0200 |
| Subject | [PATCH v2] checkpatch: special audit for revert commit line |
| Message-ID | <tv9uy-2HL-19@gated-at.bofh.it> |
From: Wei Wang <wvw@google.com>
Currently checkpatch.pl does not recognize git's default
commit revert message and will complain about the hash format.
Add special audit for revert commit message line to fix it.
Signed-off-by: Wei Wang <wvw@google.com>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index baa3c7be04ad..9570db236ba3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2539,6 +2539,7 @@ sub process {
# Check for git id commit length and improperly formed commit descriptions
if ($in_commit_log && !$commit_log_possible_stack_dump &&
$line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
+ $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
$line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
--
2.12.2.715.g7642488e1d-goog
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-04-11 21:30 +0200 |
| Message-ID | <tv9Ee-2L8-3@gated-at.bofh.it> |
| In reply to | #1621575 |
On Tue, 2017-04-11 at 12:15 -0700, Wei Wang wrote:
> From: Wei Wang <wvw@google.com>
>
> Currently checkpatch.pl does not recognize git's default
> commit revert message and will complain about the hash format.
> Add special audit for revert commit message line to fix it.
>
> Signed-off-by: Wei Wang <wvw@google.com>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index baa3c7be04ad..9570db236ba3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2539,6 +2539,7 @@ sub process {
> # Check for git id commit length and improperly formed commit descriptions
> if ($in_commit_log && !$commit_log_possible_stack_dump &&
> $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
> + $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
> ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
> ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
> $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web