Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621468 > unrolled thread

[PATCH] irqchip/irq-imx-gpcv2: Clear OF_POPULATED flag

Back to article view | Back to linux.kernel

Contents

  [PATCH] irqchip/irq-imx-gpcv2: Clear OF_POPULATED flag Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-04-11 18:50 +0200
    Re: [PATCH] irqchip/irq-imx-gpcv2: Clear OF_POPULATED flag Marc Zyngier <marc.zyngier@arm.com> - 2017-04-12 10:20 +0200

#1621468 — [PATCH] irqchip/irq-imx-gpcv2: Clear OF_POPULATED flag

Clear OF_POPULATED flag, so that GPC power domain driver[1] can be
bound to "gpc" node as well.

[1] https://lkml.org/lkml/2017/3/28/835

Cc: yurovsky@gmail.com
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---

Marc:

You've expressed you disagreement (in [thread]) for adding generic
infrastructure to perform this kind of trickery because of its
DT-specific nature. Any chance this, more contained version of it, is
acceptable?

Thanks,
Andrey Smirnov

[thread] https://lkml.org/lkml/2017/1/30/241

 drivers/irqchip/irq-imx-gpcv2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
index 15af9a9..e13236f 100644
--- a/drivers/irqchip/irq-imx-gpcv2.c
+++ b/drivers/irqchip/irq-imx-gpcv2.c
@@ -266,6 +266,11 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
 	imx_gpcv2_instance = cd;
 	register_syscore_ops(&imx_gpcv2_syscore_ops);
 
+	/*
+	 * Clear the OF_POPULATED flag set in of_irq_init so that
+	 * later the GPC power domain driver will not be skipped.
+	 */
+	of_node_clear_flag(node, OF_POPULATED);
 	return 0;
 }
 
-- 
2.9.3

[toc] | [next] | [standalone]

#1621912

On 11/04/17 17:48, Andrey Smirnov wrote:
> Clear OF_POPULATED flag, so that GPC power domain driver[1] can be
> bound to "gpc" node as well.
> 
> [1] https://lkml.org/lkml/2017/3/28/835
> 
> Cc: yurovsky@gmail.com
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> 
> Marc:
> 
> You've expressed you disagreement (in [thread]) for adding generic
> infrastructure to perform this kind of trickery because of its
> DT-specific nature. Any chance this, more contained version of it, is
> acceptable?
> 
> Thanks,
> Andrey Smirnov
> 
> [thread] https://lkml.org/lkml/2017/1/30/241
> 
>  drivers/irqchip/irq-imx-gpcv2.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 15af9a9..e13236f 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -266,6 +266,11 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>  	imx_gpcv2_instance = cd;
>  	register_syscore_ops(&imx_gpcv2_syscore_ops);
>  
> +	/*
> +	 * Clear the OF_POPULATED flag set in of_irq_init so that
> +	 * later the GPC power domain driver will not be skipped.
> +	 */
> +	of_node_clear_flag(node, OF_POPULATED);
>  	return 0;
>  }

Fair enough, I'll pick that one. It is still pretty horrible, but given
that this is an issue with the kernel at large, that's probably the best
we can do.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web