Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1621065 > unrolled thread

Re: [PATCH 6/6] KVM: perform a wake_up in kvm_make_all_cpus_request

Started byPaolo Bonzini <pbonzini@redhat.com>
First post2017-04-11 11:20 +0200
Last post2017-04-11 11:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 6/6] KVM: perform a wake_up in kvm_make_all_cpus_request Paolo Bonzini <pbonzini@redhat.com> - 2017-04-11 11:20 +0200

#1621065 — Re: [PATCH 6/6] KVM: perform a wake_up in kvm_make_all_cpus_request

FromPaolo Bonzini <pbonzini@redhat.com>
Date2017-04-11 11:20 +0200
SubjectRe: [PATCH 6/6] KVM: perform a wake_up in kvm_make_all_cpus_request
Message-ID<tv07V-50R-25@gated-at.bofh.it>

On 07/04/2017 04:20, Radim Krčmář wrote:
> I think that most requests do not need the wake up, so we would flip the
> bit then.

True.  I may need a bit more convincing, but let's see the patches:

- point against: on the other hand no wakeup is a bug, possibly hard to
find, while an extra wakeup is just annoying.

- point in favor: the same argument (multiplied by 9000) would apply to
a wait flag in the request number, but it would be obviously stupid to
add a no_wait flag to all requests except the couple that need it.

Thanks,

Paolo

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web