Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619520 > unrolled thread
| Started by | Moritz Fischer <mdf@kernel.org> |
|---|---|
| First post | 2017-04-09 19:20 +0200 |
| Last post | 2017-04-13 23:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler Moritz Fischer <mdf@kernel.org> - 2017-04-09 19:20 +0200
Re: [PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler Rob Herring <robh@kernel.org> - 2017-04-13 22:10 +0200
Re: [PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler Alan Tull <atull@kernel.org> - 2017-04-13 22:30 +0200
Re: [PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler Rob Herring <robh@kernel.org> - 2017-04-13 23:30 +0200
| From | Moritz Fischer <mdf@kernel.org> |
|---|---|
| Date | 2017-04-09 19:20 +0200 |
| Subject | [PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler |
| Message-ID | <tuoFk-5Py-3@gated-at.bofh.it> |
This adds the binding documentation for the Xilinx LogiCORE PR
Decoupler soft core.
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Alan Tull <atull@kernel.org>
Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
Cc: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org
---
Changes from v4:
- Ssubject line
- Replaced 'or' by 'followed by' as suggested by Rob
Changes from v3:
- Addressed Michal's comments
- Addressed Alan's Comments
- Added Alan's Acked-by
Changes from v2:
- Added refence to generic fpga-region bindings
- Fixed up reg property in example
- Added fallback to "xlnx,pr-decoupler" without version
Changes from v1:
- Added clock names & clock to example
- Merged some of the description from Michal's version
---
.../bindings/fpga/xilinx-pr-decoupler.txt | 36 ++++++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
new file mode 100644
index 0000000..b2c58fb
--- /dev/null
+++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
@@ -0,0 +1,36 @@
+Xilinx LogiCORE Partial Reconfig Decoupler Softcore
+
+The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more
+decouplers / fpga bridges.
+The controller can decouple/disable the bridges which prevents signal
+changes from passing through the bridge. The controller can also
+couple / enable the bridges which allows traffic to pass through the
+bridge normally.
+
+The Driver supports only MMIO handling. A PR region can have multiple
+PR Decouplers which can be handled independently or chained via decouple/
+decouple_status signals.
+
+Required properties:
+- compatible : Should contain "xlnx,pr-decoupler-1.00" followed by
+ "xlnx,pr-decoupler"
+- regs : base address and size for decoupler module
+- clocks : input clock to IP
+- clock-names : should contain "aclk"
+
+Optional properties:
+- bridge-enable : 0 if driver should disable bridge at startup
+ 1 if driver should enable bridge at startup
+ Default is to leave bridge in current state.
+
+See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings.
+
+Example:
+ fpga-bridge@100000450 {
+ compatible = "xlnx,pr-decoupler-1.00",
+ "xlnx-pr-decoupler";
+ regs = <0x10000045 0x10>;
+ clocks = <&clkc 15>;
+ clock-names = "aclk";
+ bridge-enable = <0>;
+ };
--
2.7.4
[toc] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-04-13 22:10 +0200 |
| Subject | Re: [PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler |
| Message-ID | <tvTe2-7YO-5@gated-at.bofh.it> |
| In reply to | #1619520 |
On Sun, Apr 09, 2017 at 10:10:31AM -0700, Moritz Fischer wrote: > This adds the binding documentation for the Xilinx LogiCORE PR > Decoupler soft core. > > Signed-off-by: Moritz Fischer <mdf@kernel.org> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Acked-by: Alan Tull <atull@kernel.org> > Cc: Sören Brinkmann <soren.brinkmann@xilinx.com> > Cc: linux-kernel@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > > Changes from v4: > - Ssubject line > - Replaced 'or' by 'followed by' as suggested by Rob > > Changes from v3: > - Addressed Michal's comments > - Addressed Alan's Comments > - Added Alan's Acked-by > > Changes from v2: > - Added refence to generic fpga-region bindings > - Fixed up reg property in example > - Added fallback to "xlnx,pr-decoupler" without version > > Changes from v1: > - Added clock names & clock to example > - Merged some of the description from Michal's version > > --- > .../bindings/fpga/xilinx-pr-decoupler.txt | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > new file mode 100644 > index 0000000..b2c58fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt > @@ -0,0 +1,36 @@ > +Xilinx LogiCORE Partial Reconfig Decoupler Softcore > + > +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more > +decouplers / fpga bridges. > +The controller can decouple/disable the bridges which prevents signal > +changes from passing through the bridge. The controller can also > +couple / enable the bridges which allows traffic to pass through the > +bridge normally. > + > +The Driver supports only MMIO handling. A PR region can have multiple > +PR Decouplers which can be handled independently or chained via decouple/ > +decouple_status signals. > + > +Required properties: > +- compatible : Should contain "xlnx,pr-decoupler-1.00" followed by > + "xlnx,pr-decoupler" > +- regs : base address and size for decoupler module > +- clocks : input clock to IP > +- clock-names : should contain "aclk" > + > +Optional properties: > +- bridge-enable : 0 if driver should disable bridge at startup > + 1 if driver should enable bridge at startup > + Default is to leave bridge in current state. Did this get into a common location? If so, then just "see .../?.txt" is enough of a description. Rob
[toc] | [prev] | [next] | [standalone]
| From | Alan Tull <atull@kernel.org> |
|---|---|
| Date | 2017-04-13 22:30 +0200 |
| Subject | Re: [PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler |
| Message-ID | <tvTxn-86R-3@gated-at.bofh.it> |
| In reply to | #1623319 |
On Thu, Apr 13, 2017 at 3:07 PM, Rob Herring <robh@kernel.org> wrote: > On Sun, Apr 09, 2017 at 10:10:31AM -0700, Moritz Fischer wrote: >> This adds the binding documentation for the Xilinx LogiCORE PR >> Decoupler soft core. >> >> Signed-off-by: Moritz Fischer <mdf@kernel.org> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> Acked-by: Alan Tull <atull@kernel.org> >> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com> >> Cc: linux-kernel@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> --- >> >> Changes from v4: >> - Ssubject line >> - Replaced 'or' by 'followed by' as suggested by Rob >> >> Changes from v3: >> - Addressed Michal's comments >> - Addressed Alan's Comments >> - Added Alan's Acked-by >> >> Changes from v2: >> - Added refence to generic fpga-region bindings >> - Fixed up reg property in example >> - Added fallback to "xlnx,pr-decoupler" without version >> >> Changes from v1: >> - Added clock names & clock to example >> - Merged some of the description from Michal's version >> >> --- >> .../bindings/fpga/xilinx-pr-decoupler.txt | 36 ++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> >> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> new file mode 100644 >> index 0000000..b2c58fb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> @@ -0,0 +1,36 @@ >> +Xilinx LogiCORE Partial Reconfig Decoupler Softcore >> + >> +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more >> +decouplers / fpga bridges. >> +The controller can decouple/disable the bridges which prevents signal >> +changes from passing through the bridge. The controller can also >> +couple / enable the bridges which allows traffic to pass through the >> +bridge normally. >> + >> +The Driver supports only MMIO handling. A PR region can have multiple >> +PR Decouplers which can be handled independently or chained via decouple/ >> +decouple_status signals. >> + >> +Required properties: >> +- compatible : Should contain "xlnx,pr-decoupler-1.00" followed by >> + "xlnx,pr-decoupler" >> +- regs : base address and size for decoupler module >> +- clocks : input clock to IP >> +- clock-names : should contain "aclk" >> + >> +Optional properties: >> +- bridge-enable : 0 if driver should disable bridge at startup >> + 1 if driver should enable bridge at startup >> + Default is to leave bridge in current state. > > Did this get into a common location? If so, then just "see .../?.txt" is > enough of a description. IIRC we went with this as is, with the intent of moving it to a common location in a separate patch. This binding shows up in a a few bindings docs, so one patch could move it from all of them at the same time. That hasn't happened yet. Alan > > Rob > -- > To unsubscribe from this list: send the line "unsubscribe linux-fpga" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-04-13 23:30 +0200 |
| Subject | Re: [PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler |
| Message-ID | <tvUts-jx-15@gated-at.bofh.it> |
| In reply to | #1623330 |
On Thu, Apr 13, 2017 at 3:25 PM, Alan Tull <atull@kernel.org> wrote: > On Thu, Apr 13, 2017 at 3:07 PM, Rob Herring <robh@kernel.org> wrote: >> On Sun, Apr 09, 2017 at 10:10:31AM -0700, Moritz Fischer wrote: >>> This adds the binding documentation for the Xilinx LogiCORE PR >>> Decoupler soft core. >>> >>> Signed-off-by: Moritz Fischer <mdf@kernel.org> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>> Acked-by: Alan Tull <atull@kernel.org> >>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com> >>> Cc: linux-kernel@vger.kernel.org >>> Cc: devicetree@vger.kernel.org >>> --- >>> >>> Changes from v4: >>> - Ssubject line >>> - Replaced 'or' by 'followed by' as suggested by Rob >>> >>> Changes from v3: >>> - Addressed Michal's comments >>> - Addressed Alan's Comments >>> - Added Alan's Acked-by >>> >>> Changes from v2: >>> - Added refence to generic fpga-region bindings >>> - Fixed up reg property in example >>> - Added fallback to "xlnx,pr-decoupler" without version >>> >>> Changes from v1: >>> - Added clock names & clock to example >>> - Merged some of the description from Michal's version >>> >>> --- >>> .../bindings/fpga/xilinx-pr-decoupler.txt | 36 ++++++++++++++++++++++ >>> 1 file changed, 36 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >>> >>> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >>> new file mode 100644 >>> index 0000000..b2c58fb >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >>> @@ -0,0 +1,36 @@ >>> +Xilinx LogiCORE Partial Reconfig Decoupler Softcore >>> + >>> +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more >>> +decouplers / fpga bridges. >>> +The controller can decouple/disable the bridges which prevents signal >>> +changes from passing through the bridge. The controller can also >>> +couple / enable the bridges which allows traffic to pass through the >>> +bridge normally. >>> + >>> +The Driver supports only MMIO handling. A PR region can have multiple >>> +PR Decouplers which can be handled independently or chained via decouple/ >>> +decouple_status signals. >>> + >>> +Required properties: >>> +- compatible : Should contain "xlnx,pr-decoupler-1.00" followed by >>> + "xlnx,pr-decoupler" >>> +- regs : base address and size for decoupler module >>> +- clocks : input clock to IP >>> +- clock-names : should contain "aclk" >>> + >>> +Optional properties: >>> +- bridge-enable : 0 if driver should disable bridge at startup >>> + 1 if driver should enable bridge at startup >>> + Default is to leave bridge in current state. >> >> Did this get into a common location? If so, then just "see .../?.txt" is >> enough of a description. > > IIRC we went with this as is, with the intent of moving it to > a common location in a separate patch. This binding shows > up in a a few bindings docs, so one patch could move it from all > of them at the same time. That hasn't happened yet. Okay, I'll trust you to do that. Acked-by: Rob Herring <robh@kernel.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web