Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619430 > unrolled thread
| Started by | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| First post | 2017-04-09 03:50 +0200 |
| Last post | 2017-04-09 20:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] dmaengine: ioat: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200
[PATCH] SGI-XP: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200
Re: [PATCH] dmaengine: ioat: use setup_timer Dan Williams <dan.j.williams@intel.com> - 2017-04-09 20:10 +0200
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2017-04-09 03:50 +0200 |
| Subject | [PATCH] dmaengine: ioat: use setup_timer |
| Message-ID | <tua9j-4Jh-3@gated-at.bofh.it> |
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang <geliangtang@gmail.com> --- drivers/dma/ioat/init.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index cc5259b..6ad4384 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma, dma_cookie_init(&ioat_chan->dma_chan); list_add_tail(&ioat_chan->dma_chan.device_node, &dma->channels); ioat_dma->idx[idx] = ioat_chan; - init_timer(&ioat_chan->timer); - ioat_chan->timer.function = ioat_timer_event; - ioat_chan->timer.data = data; + setup_timer(&ioat_chan->timer, ioat_timer_event, data); tasklet_init(&ioat_chan->cleanup_task, ioat_cleanup_event, data); } -- 2.9.3
[toc] | [next] | [standalone]
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2017-04-09 03:50 +0200 |
| Subject | [PATCH] SGI-XP: use setup_timer |
| Message-ID | <tua9k-4Jh-15@gated-at.bofh.it> |
| In reply to | #1619430 |
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang <geliangtang@gmail.com> --- drivers/misc/sgi-xp/xpc_main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c index 7f32712..a1b6f75 100644 --- a/drivers/misc/sgi-xp/xpc_main.c +++ b/drivers/misc/sgi-xp/xpc_main.c @@ -931,10 +931,9 @@ xpc_setup_partitions(void) part->act_state = XPC_P_AS_INACTIVE; XPC_SET_REASON(part, 0, 0); - init_timer(&part->disengage_timer); - part->disengage_timer.function = - xpc_timeout_partition_disengage; - part->disengage_timer.data = (unsigned long)part; + setup_timer(&part->disengage_timer, + xpc_timeout_partition_disengage, + (unsigned long)part); part->setup_state = XPC_P_SS_UNSET; init_waitqueue_head(&part->teardown_wq); -- 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Date | 2017-04-09 20:10 +0200 |
| Message-ID | <tuprH-6qM-13@gated-at.bofh.it> |
| In reply to | #1619430 |
On Sat, Apr 8, 2017 at 6:41 PM, Geliang Tang <geliangtang@gmail.com> wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> > --- > drivers/dma/ioat/init.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c > index cc5259b..6ad4384 100644 > --- a/drivers/dma/ioat/init.c > +++ b/drivers/dma/ioat/init.c > @@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma, > dma_cookie_init(&ioat_chan->dma_chan); > list_add_tail(&ioat_chan->dma_chan.device_node, &dma->channels); > ioat_dma->idx[idx] = ioat_chan; > - init_timer(&ioat_chan->timer); > - ioat_chan->timer.function = ioat_timer_event; > - ioat_chan->timer.data = data; > + setup_timer(&ioat_chan->timer, ioat_timer_event, data); > tasklet_init(&ioat_chan->cleanup_task, ioat_cleanup_event, data); > } > > -- > 2.9.3 > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web