Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1620804 > unrolled thread

Re: linux-next: build failure after merge of the rtc tree

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: linux-next: build failure after merge of the rtc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-11 02:30 +0200
    Re: linux-next: build failure after merge of the rtc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-11 08:00 +0200
      Re: linux-next: build failure after merge of the rtc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-11 10:00 +0200
        Re: linux-next: build failure after merge of the rtc tree Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-14 12:20 +0200
          Re: linux-next: build failure after merge of the rtc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-14 18:40 +0200

#1620804 — Re: linux-next: build failure after merge of the rtc tree

Hi Hans,

On Mon, 10 Apr 2017 09:45:45 +0200 Hans de Goede <hdegoede@redhat.com> wrote:
>
> On 10-04-17 08:04, Stephen Rothwell wrote:
> >
> > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
> >
> > Caused by commit
> >
> >   d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
> >
> > "legacy_pic" is not exported to modules.
> >
> > I have used the rtc tree from next-20170407 for today.  
> 
> I already send out a patch to fix this yesterday. I've attached a copy.

I will add that to linux-next today and will drop it when Alexandre
adds it (or some other fix).

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1620934

On 11/04/2017 at 10:22:38 +1000, Stephen Rothwell wrote:
> Hi Hans,
> 
> On Mon, 10 Apr 2017 09:45:45 +0200 Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > On 10-04-17 08:04, Stephen Rothwell wrote:
> > >
> > > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
> > >
> > > Caused by commit
> > >
> > >   d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
> > >
> > > "legacy_pic" is not exported to modules.
> > >
> > > I have used the rtc tree from next-20170407 for today.  
> > 
> > I already send out a patch to fix this yesterday. I've attached a copy.
> 
> I will add that to linux-next today and will drop it when Alexandre
> adds it (or some other fix).
> 

I think the x86 maintainers will take it as it is fairly independent.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1620994

Hi Alexandre,

On Tue, 11 Apr 2017 07:55:09 +0200 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>
> On 11/04/2017 at 10:22:38 +1000, Stephen Rothwell wrote:
> > 
> > On Mon, 10 Apr 2017 09:45:45 +0200 Hans de Goede <hdegoede@redhat.com> wrote:  
> > >
> > > On 10-04-17 08:04, Stephen Rothwell wrote:  
> > > >
> > > > After merging the rtc tree, today's linux-next build (x86_64 allmodconfig)
> > > > failed like this:
> > > >
> > > > ERROR: "legacy_pic" [drivers/rtc/rtc-cmos.ko] undefined!
> > > >
> > > > Caused by commit
> > > >
> > > >   d3e3a65c6a96 ("rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs")
> > > >
> > > > "legacy_pic" is not exported to modules.
> > > >
> > > > I have used the rtc tree from next-20170407 for today.    
> > > 
> > > I already send out a patch to fix this yesterday. I've attached a copy.  
> > 
> > I will add that to linux-next today and will drop it when Alexandre
> > adds it (or some other fix).
> 
> I think the x86 maintainers will take it as it is fairly independent.

But it is a fix for a build failure caused by a commit in your tree ...
so you should probably get an ack from the x86 maintainers and add it
to your tree.  Or do some other fix in your tree.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [next] | [standalone]

#1623632

On 11/04/2017 at 17:52:20 +1000, Stephen Rothwell wrote:
> But it is a fix for a build failure caused by a commit in your tree ...
> so you should probably get an ack from the x86 maintainers and add it
> to your tree.  Or do some other fix in your tree.
> 

It is now in my tree.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1623761

Hi Alexandre,

On Fri, 14 Apr 2017 12:09:47 +0200 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>
> On 11/04/2017 at 17:52:20 +1000, Stephen Rothwell wrote:
> > But it is a fix for a build failure caused by a commit in your tree ...
> > so you should probably get an ack from the x86 maintainers and add it
> > to your tree.  Or do some other fix in your tree.
> >   
> 
> It is now in my tree.

Thanks.

-- 
Cheers,
Stephen Rothwell

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web