Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1620811 > unrolled thread

[PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias

Started byJarod Wilson <jarod@redhat.com>
First post2017-04-11 03:10 +0200
Last post2017-04-12 19:40 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias Jarod Wilson <jarod@redhat.com> - 2017-04-11 03:10 +0200
    Re: [PATCH] pci/quirks: ITE 8893 needs  quirk_use_pcie_bridge_dma_alias Alex Williamson <alex.williamson@redhat.com> - 2017-04-11 06:50 +0200
    Re: [PATCH] pci/quirks: ITE 8893 needs  quirk_use_pcie_bridge_dma_alias Bjorn Helgaas <helgaas@kernel.org> - 2017-04-12 19:40 +0200

#1620811 — [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias

FromJarod Wilson <jarod@redhat.com>
Date2017-04-11 03:10 +0200
Subject[PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias
Message-ID<tuStH-6L-5@gated-at.bofh.it>
This bridge has the same problems as the ITE 8892, which were resulting in
crippling an older PCI 1Gbps NIC down to 45Mbps throughput with IOMMU and
VT-d enabled. With the patch, this old e1000 goes back up to ~900Mbps.

Suggested-by: Alex Williamson <alex.williamson@redhat.com>
CC: linux-pci@vger.kernel.org
CC: Alex Williamson <alex.williamson@redhat.com>
CC: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 drivers/pci/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 9236e40ac055..c95fbf2431f8 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3914,6 +3914,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1080,
 DECLARE_PCI_FIXUP_HEADER(0x10e3, 0x8113, quirk_use_pcie_bridge_dma_alias);
 /* ITE 8892, https://bugzilla.kernel.org/show_bug.cgi?id=73551 */
 DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8892, quirk_use_pcie_bridge_dma_alias);
+/* ITE 8893 has the same problem as the 8892 */
+DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8893, quirk_use_pcie_bridge_dma_alias);
 /* Intel 82801, https://bugzilla.kernel.org/show_bug.cgi?id=44881#c49 */
 DECLARE_PCI_FIXUP_HEADER(0x8086, 0x244e, quirk_use_pcie_bridge_dma_alias);
 
-- 
2.12.1

[toc] | [next] | [standalone]


#1620897 — Re: [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias

FromAlex Williamson <alex.williamson@redhat.com>
Date2017-04-11 06:50 +0200
SubjectRe: [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias
Message-ID<tuVUC-2g1-9@gated-at.bofh.it>
In reply to#1620811
On Mon, 10 Apr 2017 21:01:27 -0400
Jarod Wilson <jarod@redhat.com> wrote:

> This bridge has the same problems as the ITE 8892, which were resulting in
> crippling an older PCI 1Gbps NIC down to 45Mbps throughput with IOMMU and
> VT-d enabled. With the patch, this old e1000 goes back up to ~900Mbps.
> 
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> CC: linux-pci@vger.kernel.org
> CC: Alex Williamson <alex.williamson@redhat.com>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
>  drivers/pci/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 9236e40ac055..c95fbf2431f8 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3914,6 +3914,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1080,
>  DECLARE_PCI_FIXUP_HEADER(0x10e3, 0x8113, quirk_use_pcie_bridge_dma_alias);
>  /* ITE 8892, https://bugzilla.kernel.org/show_bug.cgi?id=73551 */
>  DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8892, quirk_use_pcie_bridge_dma_alias);
> +/* ITE 8893 has the same problem as the 8892 */
> +DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8893, quirk_use_pcie_bridge_dma_alias);
>  /* Intel 82801, https://bugzilla.kernel.org/show_bug.cgi?id=44881#c49 */
>  DECLARE_PCI_FIXUP_HEADER(0x8086, 0x244e, quirk_use_pcie_bridge_dma_alias);


Reviewed-by: Alex Williamson <alex.williamson@redhat.com>

[toc] | [prev] | [next] | [standalone]


#1622415 — Re: [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias

FromBjorn Helgaas <helgaas@kernel.org>
Date2017-04-12 19:40 +0200
SubjectRe: [PATCH] pci/quirks: ITE 8893 needs quirk_use_pcie_bridge_dma_alias
Message-ID<tvupk-7nO-19@gated-at.bofh.it>
In reply to#1620811
On Mon, Apr 10, 2017 at 09:01:27PM -0400, Jarod Wilson wrote:
> This bridge has the same problems as the ITE 8892, which were resulting in
> crippling an older PCI 1Gbps NIC down to 45Mbps throughput with IOMMU and
> VT-d enabled. With the patch, this old e1000 goes back up to ~900Mbps.
> 
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> CC: linux-pci@vger.kernel.org
> CC: Alex Williamson <alex.williamson@redhat.com>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Jarod Wilson <jarod@redhat.com>

Applied with Alex's reviewed-by to pci/iommu for v4.12, thanks!

> ---
>  drivers/pci/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 9236e40ac055..c95fbf2431f8 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3914,6 +3914,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1080,
>  DECLARE_PCI_FIXUP_HEADER(0x10e3, 0x8113, quirk_use_pcie_bridge_dma_alias);
>  /* ITE 8892, https://bugzilla.kernel.org/show_bug.cgi?id=73551 */
>  DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8892, quirk_use_pcie_bridge_dma_alias);
> +/* ITE 8893 has the same problem as the 8892 */
> +DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8893, quirk_use_pcie_bridge_dma_alias);
>  /* Intel 82801, https://bugzilla.kernel.org/show_bug.cgi?id=44881#c49 */
>  DECLARE_PCI_FIXUP_HEADER(0x8086, 0x244e, quirk_use_pcie_bridge_dma_alias);
>  
> -- 
> 2.12.1
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web