Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1620736 > unrolled thread
| Started by | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| First post | 2017-04-10 23:10 +0200 |
| Last post | 2017-04-11 02:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: linux-next: build failure after merge of the akpm-current tree Andrew Morton <akpm@linux-foundation.org> - 2017-04-10 23:10 +0200
Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-10 23:40 +0200
Re: linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-11 02:00 +0200
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2017-04-10 23:10 +0200 |
| Subject | Re: linux-next: build failure after merge of the akpm-current tree |
| Message-ID | <tuOJs-69c-23@gated-at.bofh.it> |
On Mon, 10 Apr 2017 16:45:57 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andrew,
>
> After merging the akpm-current tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> mm/swap_slots.c: In function 'alloc_swap_slot_cache':
> mm/swap_slots.c:126:10: error: implicit declaration of function 'kvzalloc' [-Werror=implicit-function-declaration]
> slots = kvzalloc(sizeof(swp_entry_t) * SWAP_SLOTS_CACHE_SIZE,
> ^
> mm/swap_slots.c:126:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> slots = kvzalloc(sizeof(swp_entry_t) * SWAP_SLOTS_CACHE_SIZE,
> ^
> mm/swap_slots.c:131:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> slots_ret = kvzalloc(sizeof(swp_entry_t) * SWAP_SLOTS_CACHE_SIZE,
> ^
>
> Caused by commit
>
> 22cf2f4616c6 ("mm, swap: U=use kvzalloc to allocate some swap data structure")
>
> The patches adding kvzalloc seem to have vanished :-(
>
> I have reverted that commit for today.
>
No, mm-introduce-kvalloc-helpers.patch is still in there but I had it
staged after
mm-swap-use-kvzalloc-to-allocate-some-swap-data-structure.patch. ANd
after linux-next.patch which is presumably what tricked you.
[toc] | [next] | [standalone]
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-04-10 23:40 +0200 |
| Message-ID | <tuPcu-6jI-7@gated-at.bofh.it> |
| In reply to | #1620736 |
Hi Andrew, On Mon, 10 Apr 2017 14:06:06 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > > No, mm-introduce-kvalloc-helpers.patch is still in there but I had it > staged after > mm-swap-use-kvzalloc-to-allocate-some-swap-data-structure.patch. ANd > after linux-next.patch which is presumably what tricked you. Yeah, I noticed that later. So presumably patch "mm, swap: U=use kvzalloc to allocate some swap data structure" needs to be moved to after mm-introduce-kvalloc-helpers.patch -- Cheers, Stephen Rothwell
[toc] | [prev] | [next] | [standalone]
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-04-11 02:00 +0200 |
| Message-ID | <tuRnY-7Fz-11@gated-at.bofh.it> |
| In reply to | #1620747 |
Hi Andrew, On Tue, 11 Apr 2017 07:33:09 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Mon, 10 Apr 2017 14:06:06 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > > > > No, mm-introduce-kvalloc-helpers.patch is still in there but I had it > > staged after > > mm-swap-use-kvzalloc-to-allocate-some-swap-data-structure.patch. ANd > > after linux-next.patch which is presumably what tricked you. > > Yeah, I noticed that later. So presumably patch > > "mm, swap: U=use kvzalloc to allocate some swap data structure" > > needs to be moved to after > > mm-introduce-kvalloc-helpers.patch I have done that in linux-next today. -- Cheers, Stephen Rothwell
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web