Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1619712 > unrolled thread

[PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref

Started byLudovic Desroches <ludovic.desroches@microchip.com>
First post2017-04-10 10:30 +0200
Last post2017-04-10 12:30 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-04-10 10:30 +0200
    [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-04-10 10:30 +0200
      Re: [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC  channels are available Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-04-10 11:10 +0200
      Re: [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC  channels are available Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-10 12:30 +0200
    Re: [PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-04-10 11:10 +0200
    Re: [PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-04-10 12:30 +0200

#1619712 — [PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref

FromLudovic Desroches <ludovic.desroches@microchip.com>
Date2017-04-10 10:30 +0200
Subject[PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref
Message-ID<tuCRY-6Gd-11@gated-at.bofh.it>
The voltage reference for the ADC is not 3V but 3.3V since it is connected to
VDDANA.

Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: <stable@vger.kernel.org> # 3.16+
---
 arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
index c51fc65..7a0fa1a 100644
--- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
@@ -162,6 +162,7 @@
 			};
 
 			adc0: adc@f8018000 {
+				atmel,adc-vref = <3300>;
 				pinctrl-0 = <
 					&pinctrl_adc0_adtrg
 					&pinctrl_adc0_ad0
-- 
2.9.0

[toc] | [next] | [standalone]


#1619716 — [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available

FromLudovic Desroches <ludovic.desroches@microchip.com>
Date2017-04-10 10:30 +0200
Subject[PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available
Message-ID<tuCRY-6Gd-19@gated-at.bofh.it>
In reply to#1619712
Remove ADC channels that are not available by default on the sama5d3_xplained
board (resistor not populated) in order to not create confusion.

Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: <stable@vger.kernel.org> # 3.16+
---
 arch/arm/boot/dts/at91-sama5d3_xplained.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
index 7a0fa1a..5a53fcf 100644
--- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
@@ -163,9 +163,9 @@
 
 			adc0: adc@f8018000 {
 				atmel,adc-vref = <3300>;
+				atmel,adc-channels-used = <0xfe>;
 				pinctrl-0 = <
 					&pinctrl_adc0_adtrg
-					&pinctrl_adc0_ad0
 					&pinctrl_adc0_ad1
 					&pinctrl_adc0_ad2
 					&pinctrl_adc0_ad3
@@ -173,8 +173,6 @@
 					&pinctrl_adc0_ad5
 					&pinctrl_adc0_ad6
 					&pinctrl_adc0_ad7
-					&pinctrl_adc0_ad8
-					&pinctrl_adc0_ad9
 					>;
 				status = "okay";
 			};
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]


#1619738 — Re: [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available

FromNicolas Ferre <nicolas.ferre@microchip.com>
Date2017-04-10 11:10 +0200
SubjectRe: [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available
Message-ID<tuDuG-788-5@gated-at.bofh.it>
In reply to#1619716
Le 10/04/2017 à 10:25, Ludovic Desroches a écrit :
> Remove ADC channels that are not available by default on the sama5d3_xplained
> board (resistor not populated) in order to not create confusion.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: <stable@vger.kernel.org> # 3.16+

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> index 7a0fa1a..5a53fcf 100644
> --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -163,9 +163,9 @@
>  
>  			adc0: adc@f8018000 {
>  				atmel,adc-vref = <3300>;
> +				atmel,adc-channels-used = <0xfe>;
>  				pinctrl-0 = <
>  					&pinctrl_adc0_adtrg
> -					&pinctrl_adc0_ad0
>  					&pinctrl_adc0_ad1
>  					&pinctrl_adc0_ad2
>  					&pinctrl_adc0_ad3
> @@ -173,8 +173,6 @@
>  					&pinctrl_adc0_ad5
>  					&pinctrl_adc0_ad6
>  					&pinctrl_adc0_ad7
> -					&pinctrl_adc0_ad8
> -					&pinctrl_adc0_ad9
>  					>;
>  				status = "okay";
>  			};
> 


-- 
Nicolas Ferre

[toc] | [prev] | [next] | [standalone]


#1619789 — Re: [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-04-10 12:30 +0200
SubjectRe: [PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available
Message-ID<tuEK5-7QB-15@gated-at.bofh.it>
In reply to#1619716
On 10/04/2017 at 10:25:17 +0200, Ludovic Desroches wrote:
> Remove ADC channels that are not available by default on the sama5d3_xplained
> board (resistor not populated) in order to not create confusion.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: <stable@vger.kernel.org> # 3.16+
> ---
>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1619740

FromNicolas Ferre <nicolas.ferre@microchip.com>
Date2017-04-10 11:10 +0200
Message-ID<tuDuG-788-9@gated-at.bofh.it>
In reply to#1619712
Le 10/04/2017 à 10:25, Ludovic Desroches a écrit :
> The voltage reference for the ADC is not 3V but 3.3V since it is connected to
> VDDANA.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: <stable@vger.kernel.org> # 3.16+

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> index c51fc65..7a0fa1a 100644
> --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -162,6 +162,7 @@
>  			};
>  
>  			adc0: adc@f8018000 {
> +				atmel,adc-vref = <3300>;
>  				pinctrl-0 = <
>  					&pinctrl_adc0_adtrg
>  					&pinctrl_adc0_ad0
> 


-- 
Nicolas Ferre

[toc] | [prev] | [next] | [standalone]


#1619788

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-04-10 12:30 +0200
Message-ID<tuEK5-7QB-11@gated-at.bofh.it>
In reply to#1619712
On 10/04/2017 at 10:25:16 +0200, Ludovic Desroches wrote:
> The voltage reference for the ADC is not 3V but 3.3V since it is connected to
> VDDANA.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: <stable@vger.kernel.org> # 3.16+
> ---
>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web