Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619687 > unrolled thread
| Started by | Niklas Cassel <niklas.cassel@axis.com> |
|---|---|
| First post | 2017-04-10 09:50 +0200 |
| Last post | 2017-04-11 08:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt Niklas Cassel <niklas.cassel@axis.com> - 2017-04-10 09:50 +0200
Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-04-11 08:10 +0200
| From | Niklas Cassel <niklas.cassel@axis.com> |
|---|---|
| Date | 2017-04-10 09:50 +0200 |
| Subject | [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt |
| Message-ID | <tuCff-6dm-1@gated-at.bofh.it> |
From: Niklas Cassel <niklas.cassel@axis.com> The hardware has a LPI interrupt. There is already code in the stmmac driver to parse and handle the interrupt. However, this information was missing from the DT binding. Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> --- Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt index f652b0c384ce..84e4cbfd3b0f 100644 --- a/Documentation/devicetree/bindings/net/stmmac.txt +++ b/Documentation/devicetree/bindings/net/stmmac.txt @@ -8,8 +8,8 @@ Required properties: that services interrupts for this device - interrupts: Should contain the STMMAC interrupts - interrupt-names: Should contain the interrupt names "macirq" - "eth_wake_irq" if this interrupt is supported in the "interrupts" - property + "eth_wake_irq" if this interrupt is supported in the "interrupts" property + "eth_lpi" if this interrupt is supported in the "interrupts" property - phy-mode: See ethernet.txt file in the same directory. - snps,reset-gpio gpio number for phy reset. - snps,reset-active-low boolean flag to indicate if phy reset is active low. @@ -152,8 +152,8 @@ Examples: compatible = "st,spear600-gmac"; reg = <0xe0800000 0x8000>; interrupt-parent = <&vic1>; - interrupts = <24 23>; - interrupt-names = "macirq", "eth_wake_irq"; + interrupts = <24 23 22>; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; mac-address = [000000000000]; /* Filled in by U-Boot */ max-frame-size = <3800>; phy-mode = "gmii"; -- 2.11.0
[toc] | [next] | [standalone]
| From | Giuseppe CAVALLARO <peppe.cavallaro@st.com> |
|---|---|
| Date | 2017-04-11 08:10 +0200 |
| Subject | Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt |
| Message-ID | <tuXa1-3ga-3@gated-at.bofh.it> |
| In reply to | #1619687 |
Hi Niklas On 4/10/2017 9:43 AM, Niklas Cassel wrote: > From: Niklas Cassel <niklas.cassel@axis.com> > > The hardware has a LPI interrupt. > There is already code in the stmmac driver to parse and handle the > interrupt. However, this information was missing from the DT binding. i wonder if we could improve the comments in this patch too > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> > --- > Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index f652b0c384ce..84e4cbfd3b0f 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -8,8 +8,8 @@ Required properties: > that services interrupts for this device > - interrupts: Should contain the STMMAC interrupts > - interrupt-names: Should contain the interrupt names "macirq" > - "eth_wake_irq" if this interrupt is supported in the "interrupts" > - property > + "eth_wake_irq" if this interrupt is supported in the "interrupts" property this is the PMT interrupt to manage the remote wake-up packet detection > + "eth_lpi" if this interrupt is supported in the "interrupts" property This is the interrupt that occurs when Tx or Rx enter/exit from LPI state Regards Peppe > - phy-mode: See ethernet.txt file in the same directory. > - snps,reset-gpio gpio number for phy reset. > - snps,reset-active-low boolean flag to indicate if phy reset is active low. > @@ -152,8 +152,8 @@ Examples: > compatible = "st,spear600-gmac"; > reg = <0xe0800000 0x8000>; > interrupt-parent = <&vic1>; > - interrupts = <24 23>; > - interrupt-names = "macirq", "eth_wake_irq"; > + interrupts = <24 23 22>; > + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; > mac-address = [000000000000]; /* Filled in by U-Boot */ > max-frame-size = <3800>; > phy-mode = "gmii";
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web