Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610050 > unrolled thread
| Started by | Mike Galbraith <efault@gmx.de> |
|---|---|
| First post | 2017-03-27 20:30 +0200 |
| Last post | 2017-03-30 06:00 +0200 |
| Articles | 20 on this page of 48 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-27 20:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-29 08:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 22:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-30 09:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-31 05:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-03-31 10:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-31 18:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-04-03 16:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-03 17:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-03 18:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-04-05 08:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-03 20:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-03 20:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 06:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 15:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 16:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 16:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 17:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 19:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 20:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 20:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-04 20:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 23:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-04 21:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 05:20 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 05:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 06:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 06:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Christoph Hellwig <hch@lst.de> - 2017-04-05 08:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-05 09:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 23:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 08:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 08:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 08:50 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 09:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 09:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 09:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 15:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 15:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-07 16:40 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-07 21:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-04-08 07:10 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-05 06:00 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 22:30 +0200
Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Mike Galbraith <efault@gmx.de> - 2017-03-30 06:00 +0200
Page 2 of 3 — ← Prev page 1 [2] 3 Next page →
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-04 20:10 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tsB3Z-8pK-45@gated-at.bofh.it> |
| In reply to | #1616271 |
On Tue, Apr 04, 2017 at 07:54:36PM +0200, Mike Galbraith wrote: > On Tue, 2017-04-04 at 19:40 +0200, Mike Galbraith wrote: > > On Tue, 2017-04-04 at 18:30 +0300, Michael S. Tsirkin wrote: > > > > > I couldn't reproduce it - let's make sure we are using the > > > same tree. Could you pls try > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux > > > -next > > > > > > It's currently at cc79d42a7d7e57ff64f406a1fd3740afebac0b44 > > > > Things that make ya go hmm... > > Making double sure we're on the same page... > > git@homer:..git/vhost> git branch > * linux-next > master > git@homer:..git/vhost> git describe > warning: tag 'for_linus' is really 'tags_for_linus' here > for_linus-220128-gcc79d42a7d7e > git@homer:..git/vhost> git status > On branch linux-next > Your branch is up-to-date with 'origin/linux-next'. > Changes not staged for commit: > (use "git add <file>..." to update what will be committed) > (use "git checkout -- <file>..." to discard changes in working directory) > > modified: Makefile > modified: scripts/setlocalversion > > no changes added to commit (use "git add" and/or "git commit -a") > git@homer:..git/vhost> > > Modifications are me whacking '+' sign and -rc5.. I don't do those. And just making double sure, the 1st version that has the issue is 5c34d002dcc7, isn't it? I'm asking because subject says so but then goes on to list subject from another commit. This one is: virtio_pci: remove struct virtio_pci_vq_info -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-04 20:40 +0200 |
| Message-ID | <tsBx0-ao-19@gated-at.bofh.it> |
| In reply to | #1616292 |
On Tue, 2017-04-04 at 21:00 +0300, Michael S. Tsirkin wrote: > And just making double sure, the 1st version that has the issue > is 5c34d002dcc7, isn't it? I'm asking because subject says so > but then goes on to list subject from another commit. > This one is: > > virtio_pci: remove struct virtio_pci_vq_info When the hibernation related warnings started I don't know, I wasn't targeting that, those fell out of subsequent testing. I started out hunting console breakage point w. threaded irqs, which is 5c34d002dcc7. -Mike
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-04 23:40 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tsElb-1Yn-1@gated-at.bofh.it> |
| In reply to | #1616309 |
On Tue, Apr 04, 2017 at 08:38:35PM +0200, Mike Galbraith wrote: > On Tue, 2017-04-04 at 21:00 +0300, Michael S. Tsirkin wrote: > > > And just making double sure, the 1st version that has the issue > > is 5c34d002dcc7, isn't it? I'm asking because subject says so > > but then goes on to list subject from another commit. > > This one is: > > > virtio_pci: remove struct virtio_pci_vq_info > > When the hibernation related warnings started I don't know, I wasn't > targeting that, those fell out of subsequent testing. > I started out > hunting console breakage point w. threaded irqs, which is 5c34d002dcc7. OK but 5c34d002dcc7 isn't "virtio_pci: use shared interrupts for virtqueues". > > -Mike I'm confused at this point. I would appreciate the summary of which versions were tested and what did you see. Testing a revert might also help. Thanks a lot for your testing! -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-05 05:00 +0200 |
| Message-ID | <tsJkR-59o-5@gated-at.bofh.it> |
| In reply to | #1616385 |
On Wed, 2017-04-05 at 00:31 +0300, Michael S. Tsirkin wrote: > On Tue, Apr 04, 2017 at 08:38:35PM +0200, Mike Galbraith wrote: > > On Tue, 2017-04-04 at 21:00 +0300, Michael S. Tsirkin wrote: > > > > > And just making double sure, the 1st version that has the issue > > > is 5c34d002dcc7, isn't it? I'm asking because subject says so > > > but then goes on to list subject from another commit. > > > This one is: > > > > virtio_pci: remove struct virtio_pci_vq_info > > > > When the hibernation related warnings started I don't know, I > > wasn't > > targeting that, those fell out of subsequent testing. > > I started out > > hunting console breakage point w. threaded irqs, which is > > 5c34d002dcc7. > > OK but 5c34d002dcc7 isn't "virtio_pci: use shared > interrupts for virtqueues". Heh, wrong sha.. $subject does however correctly identify in quotes the origin of the threaded irq woes. > I'm confused at this point. I would appreciate the summary of > which versions were tested and what did you see. Testing > a revert might also help. I already tested full revert. I went looking for what busted kvm for RT kernels, extracted the virtio series and quilt bisected that to use shared interrupts. I was going to just use my little turn off multiport hacklet to put spinning kworker on the back burner until the dust settled, but noticed that there was more going on, and none of it is RT specific (thus freeing up a back burner). From there, it's all test what you/Christoph post, as you post it, in virgin source. -Mike
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-04 21:10 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tsC02-Cw-13@gated-at.bofh.it> |
| In reply to | #1616271 |
On Tue, Apr 04, 2017 at 07:54:36PM +0200, Mike Galbraith wrote: > On Tue, 2017-04-04 at 19:40 +0200, Mike Galbraith wrote: > > On Tue, 2017-04-04 at 18:30 +0300, Michael S. Tsirkin wrote: > > > > > I couldn't reproduce it - let's make sure we are using the > > > same tree. Could you pls try > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux > > > -next > > > > > > It's currently at cc79d42a7d7e57ff64f406a1fd3740afebac0b44 > > > > Things that make ya go hmm... > > Making double sure we're on the same page... > > git@homer:..git/vhost> git branch > * linux-next > master > git@homer:..git/vhost> git describe > warning: tag 'for_linus' is really 'tags_for_linus' here > for_linus-220128-gcc79d42a7d7e > git@homer:..git/vhost> git status > On branch linux-next > Your branch is up-to-date with 'origin/linux-next'. > Changes not staged for commit: > (use "git add <file>..." to update what will be committed) > (use "git checkout -- <file>..." to discard changes in working directory) > > modified: Makefile > modified: scripts/setlocalversion > > no changes added to commit (use "git add" and/or "git commit -a") > git@homer:..git/vhost> > > Modifications are me whacking '+' sign and -rc5.. I don't do those. since I couldn't reproduce, I decided it's worth trying to see what happens if we revert back to before 5c34d002dcc7. Could you please test a tag "test" in my tree above? It should point at 6d88af1bf359417eb821370294ba489bdf7f5ab8 That has reverts for code refactorings since 5c34d002dcc7 inclusive. If this finally works, maybe you could go back and see which of the reverts helps? The idea is that this only has refactorings nicely isolated, if all else fails we can even do the reverts without losing functionality. -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-05 05:10 +0200 |
| Message-ID | <tsJuy-5ss-11@gated-at.bofh.it> |
| In reply to | #1616343 |
On Tue, 2017-04-04 at 22:03 +0300, Michael S. Tsirkin wrote: > since I couldn't reproduce, I decided it's worth trying to see > what happens if we revert back to before 5c34d002dcc7. > > > Could you please test a tag "test" in my tree above? > It should point at 6d88af1bf359417eb821370294ba489bdf7f5ab8 Nogo. git@homer:..git/vhost> git remote update Fetching origin git@homer:..git/vhost> git show 6d88af1bf359417eb821370294ba489bdf7f5ab8 fatal: bad object 6d88af1bf359417eb821370294ba489bdf7f5ab8
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-05 05:20 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tsJEd-5vt-1@gated-at.bofh.it> |
| In reply to | #1616538 |
On Wed, Apr 05, 2017 at 05:09:09AM +0200, Mike Galbraith wrote: > On Tue, 2017-04-04 at 22:03 +0300, Michael S. Tsirkin wrote: > > > since I couldn't reproduce, I decided it's worth trying to see > > what happens if we revert back to before 5c34d002dcc7. > > > > > > Could you please test a tag "test" in my tree above? > > It should point at 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > Nogo. > > git@homer:..git/vhost> git remote update > Fetching origin > git@homer:..git/vhost> git show 6d88af1bf359417eb821370294ba489bdf7f5ab8 > fatal: bad object 6d88af1bf359417eb821370294ba489bdf7f5ab8 Maybe because it's a tag not a head. Pls try git fetch git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git refs/tags/test -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-05 05:30 +0200 |
| Message-ID | <tsJNU-5yF-3@gated-at.bofh.it> |
| In reply to | #1616539 |
On Wed, 2017-04-05 at 06:13 +0300, Michael S. Tsirkin wrote: > On Wed, Apr 05, 2017 at 05:09:09AM +0200, Mike Galbraith wrote: > > On Tue, 2017-04-04 at 22:03 +0300, Michael S. Tsirkin wrote: > > > > > since I couldn't reproduce, I decided it's worth trying to see > > > what happens if we revert back to before 5c34d002dcc7. > > > > > > > > > Could you please test a tag "test" in my tree above? > > > It should point at 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > Nogo. > > > > git@homer:..git/vhost> git remote update > > Fetching origin > > git@homer:..git/vhost> git show > > 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > fatal: bad object 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > Maybe because it's a tag not a head. Pls try > git fetch git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > refs/tags/test That worked. Checked out/building.
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-05 05:50 +0200 |
| Message-ID | <tsK7f-5H7-3@gated-at.bofh.it> |
| In reply to | #1616542 |
On Wed, 2017-04-05 at 05:24 +0200, Mike Galbraith wrote: > On Wed, 2017-04-05 at 06:13 +0300, Michael S. Tsirkin wrote: > > On Wed, Apr 05, 2017 at 05:09:09AM +0200, Mike Galbraith wrote: > > > On Tue, 2017-04-04 at 22:03 +0300, Michael S. Tsirkin wrote: > > > > > > > since I couldn't reproduce, I decided it's worth trying to see > > > > what happens if we revert back to before 5c34d002dcc7. > > > > > > > > > > > > Could you please test a tag "test" in my tree above? > > > > It should point at 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > > > Nogo. > > > > > > git@homer:..git/vhost> git remote update > > > Fetching origin > > > git@homer:..git/vhost> git show > > > 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > fatal: bad object 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > Maybe because it's a tag not a head. Pls try > > git fetch > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > > refs/tags/test > > That worked. Checked out/building. vbox hibernated gripe free, w/wo threadirqs. -Mike
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-05 06:00 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tsKgV-5Kg-1@gated-at.bofh.it> |
| In reply to | #1616547 |
On Wed, Apr 05, 2017 at 05:40:06AM +0200, Mike Galbraith wrote: > On Wed, 2017-04-05 at 05:24 +0200, Mike Galbraith wrote: > > On Wed, 2017-04-05 at 06:13 +0300, Michael S. Tsirkin wrote: > > > On Wed, Apr 05, 2017 at 05:09:09AM +0200, Mike Galbraith wrote: > > > > On Tue, 2017-04-04 at 22:03 +0300, Michael S. Tsirkin wrote: > > > > > > > > > since I couldn't reproduce, I decided it's worth trying to see > > > > > what happens if we revert back to before 5c34d002dcc7. > > > > > > > > > > > > > > > Could you please test a tag "test" in my tree above? > > > > > It should point at 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > > > > > Nogo. > > > > > > > > git@homer:..git/vhost> git remote update > > > > Fetching origin > > > > git@homer:..git/vhost> git show > > > > 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > fatal: bad object 6d88af1bf359417eb821370294ba489bdf7f5ab8 > > > > > > Maybe because it's a tag not a head. Pls try > > > git fetch > > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > > > refs/tags/test > > > > That worked. Checked out/building. > > vbox hibernated gripe free, w/wo threadirqs. > > -Mike Any issues at all left with this tree? In particular any regressions? -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-05 06:30 +0200 |
| Message-ID | <tsKJY-6c1-7@gated-at.bofh.it> |
| In reply to | #1616552 |
On Wed, 2017-04-05 at 06:51 +0300, Michael S. Tsirkin wrote: > Any issues at all left with this tree? > In particular any regressions? Nothing blatantly obvious in a testdrive that lasted a couple minutes. I'd have to beat on it a bit to look for things beyond the reported, but can't afford to do that right now. -Mike
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-04-05 08:30 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tsMC6-7pf-19@gated-at.bofh.it> |
| In reply to | #1616564 |
On Wed, Apr 05, 2017 at 06:24:50AM +0200, Mike Galbraith wrote: > On Wed, 2017-04-05 at 06:51 +0300, Michael S. Tsirkin wrote: > > > Any issues at all left with this tree? > > In particular any regressions? > > Nothing blatantly obvious in a testdrive that lasted a couple minutes. > I'd have to beat on it a bit to look for things beyond the reported, > but can't afford to do that right now. Can you check where the issues appear? I'd like to do a pure revert of the shared interrupts, but that three has a lot more in it..
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-05 09:00 +0200 |
| Message-ID | <tsN58-7C6-33@gated-at.bofh.it> |
| In reply to | #1616606 |
On Wed, 2017-04-05 at 08:29 +0200, Christoph Hellwig wrote: > Can you check where the issues appear? I'd like to do a pure revert > of the shared interrupts, but that three has a lot more in it.. Not immediately, one of my several pots is emitting black smoke. -Mike
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-05 23:40 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <tt0OK-7VD-11@gated-at.bofh.it> |
| In reply to | #1616606 |
On Wed, Apr 05, 2017 at 08:29:34AM +0200, Christoph Hellwig wrote: > On Wed, Apr 05, 2017 at 06:24:50AM +0200, Mike Galbraith wrote: > > On Wed, 2017-04-05 at 06:51 +0300, Michael S. Tsirkin wrote: > > > > > Any issues at all left with this tree? > > > In particular any regressions? > > > > Nothing blatantly obvious in a testdrive that lasted a couple minutes. > > I'd have to beat on it a bit to look for things beyond the reported, > > but can't afford to do that right now. > > Can you check where the issues appear? I'd like to do a pure revert > of the shared interrupts, but that three has a lot more in it.. What I did is a revert the refactorings while keeping the affinity API - we can safely postpone them until the next release without loss of functionality. But that's on top of my testing tree so it has unrelated stuff as well. I'm rather confident they aren't fixing the issues but I'll prepare a bugfix-only tree now for testing. -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-07 08:10 +0200 |
| Message-ID | <ttvfP-3kY-5@gated-at.bofh.it> |
| In reply to | #1617387 |
On Thu, 2017-04-06 at 00:38 +0300, Michael S. Tsirkin wrote: > What I did is a revert the refactorings while keeping the affinity API - > we can safely postpone them until the next release without loss of > functionality. But that's on top of my testing tree so it has unrelated > stuff as well. I'm rather confident they aren't fixing the issues but > I'll prepare a bugfix-only tree now for testing. Test tag works fine here w/wo threadirqs, RT works as well. -Mike
[toc] | [prev] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2017-04-07 08:30 +0200 |
| Subject | Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") |
| Message-ID | <ttvzb-3um-3@gated-at.bofh.it> |
| In reply to | #1618490 |
On Fri, Apr 07, 2017 at 08:03:19AM +0200, Mike Galbraith wrote: > On Thu, 2017-04-06 at 00:38 +0300, Michael S. Tsirkin wrote: > > > What I did is a revert the refactorings while keeping the affinity API - > > we can safely postpone them until the next release without loss of > > functionality. But that's on top of my testing tree so it has unrelated > > stuff as well. I'm rather confident they aren't fixing the issues but > > I'll prepare a bugfix-only tree now for testing. > > Test tag works fine here w/wo threadirqs, RT works as well. > > -Mike Thanks a lot. OK I pushed out two new tags test1 with just the cleanup reverts test2 with a bugfix in this area I would very much appreciate your testing report on both - should be ok but better make sure. Unfortunately it's past 2am here so I don't have the time to test - and I'm at a conference so not a lot of time during the day either. Christoph, I still think your cleanups were a good idea, but we need get this release into a stable shape ASAP. Let's try again for the next release, OK? -- MST
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-07 08:50 +0200 |
| Message-ID | <ttvSx-3C4-5@gated-at.bofh.it> |
| In reply to | #1618498 |
On Fri, 2017-04-07 at 09:24 +0300, Michael S. Tsirkin wrote: > On Fri, Apr 07, 2017 at 08:03:19AM +0200, Mike Galbraith wrote: > > Test tag works fine here w/wo threadirqs, RT works as well. > > > > -Mike > > Thanks a lot. > OK I pushed out two new tags > test1 with just the cleanup reverts > test2 with a bugfix in this area > > > I would very much appreciate your testing report on both - > should be ok but better make sure. Ok, once it percolates out I'll do that. -Mike
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-07 09:10 +0200 |
| Message-ID | <ttwbT-3XD-9@gated-at.bofh.it> |
| In reply to | #1618504 |
On Fri, 2017-04-07 at 08:44 +0200, Mike Galbraith wrote: > On Fri, 2017-04-07 at 09:24 +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 07, 2017 at 08:03:19AM +0200, Mike Galbraith wrote: > > > > Test tag works fine here w/wo threadirqs, RT works as well. > > > > > > -Mike > > > > Thanks a lot. > > OK I pushed out two new tags > > test1 with just the cleanup reverts > > test2 with a bugfix in this area > > > > > > I would very much appreciate your testing report on both - > > should be ok but better make sure. > > Ok, once it percolates out I'll do that. for_linus-10-g960bef2a6172 contains a -ENOBUILD merge conflict. -Mike
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-07 09:30 +0200 |
| Message-ID | <ttwvg-43T-1@gated-at.bofh.it> |
| In reply to | #1618512 |
On Fri, 2017-04-07 at 09:05 +0200, Mike Galbraith wrote: > On Fri, 2017-04-07 at 08:44 +0200, Mike Galbraith wrote: > > On Fri, 2017-04-07 at 09:24 +0300, Michael S. Tsirkin wrote: > > > On Fri, Apr 07, 2017 at 08:03:19AM +0200, Mike Galbraith wrote: > > > > > > Test tag works fine here w/wo threadirqs, RT works as well. > > > > > > > > -Mike > > > > > > Thanks a lot. > > > OK I pushed out two new tags > > > test1 with just the cleanup reverts > > > test2 with a bugfix in this area > > > > > > > > > I would very much appreciate your testing report on both - > > > should be ok but better make sure. > > > > Ok, once it percolates out I'll do that. > > for_linus-10-g960bef2a6172 contains a -ENOBUILD merge conflict. But test2 works fine w/wo threadirqs.
[toc] | [prev] | [next] | [standalone]
| From | Mike Galbraith <efault@gmx.de> |
|---|---|
| Date | 2017-04-07 09:30 +0200 |
| Message-ID | <ttwvg-43T-23@gated-at.bofh.it> |
| In reply to | #1618518 |
On Fri, 2017-04-07 at 09:22 +0200, Mike Galbraith wrote: > On Fri, 2017-04-07 at 09:05 +0200, Mike Galbraith wrote: > > On Fri, 2017-04-07 at 08:44 +0200, Mike Galbraith wrote: > > > On Fri, 2017-04-07 at 09:24 +0300, Michael S. Tsirkin wrote: > > > > On Fri, Apr 07, 2017 at 08:03:19AM +0200, Mike Galbraith wrote: > > > > > > > > Test tag works fine here w/wo threadirqs, RT works as well. > > > > > > > > > > -Mike > > > > > > > > Thanks a lot. > > > > OK I pushed out two new tags > > > > test1 with just the cleanup reverts > > > > test2 with a bugfix in this area > > > > > > > > > > > > I would very much appreciate your testing report on both - > > > > should be ok but better make sure. > > > > > > Ok, once it percolates out I'll do that. > > > > for_linus-10-g960bef2a6172 contains a -ENOBUILD merge conflict. > > But test2 works fine w/wo threadirqs. (CONFIG_DEBUG_SHIRQ=y as well btw)
[toc] | [prev] | [next] | [standalone]
Page 2 of 3 — ← Prev page 1 [2] 3 Next page →
Back to top | Article view | linux.kernel
csiph-web