Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1618426 > unrolled thread

[PATCH] padata: free correct variable

Started by"Jason A. Donenfeld" <Jason@zx2c4.com>
First post2017-04-07 02:40 +0200
Last post2017-04-10 13:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] padata: free correct variable "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-04-07 02:40 +0200
    Re: [PATCH] padata: free correct variable Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-10 13:30 +0200

#1618426 — [PATCH] padata: free correct variable

From"Jason A. Donenfeld" <Jason@zx2c4.com>
Date2017-04-07 02:40 +0200
Subject[PATCH] padata: free correct variable
Message-ID<ttq6t-8ax-7@gated-at.bofh.it>
The author meant to free the variable that was just allocated, instead
of the one that failed to be allocated, but made a simple typo. This
patch rectifies that.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: stable@vger.kernel.org
---
 kernel/padata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index 05316c9f32da..1faa7d62d87d 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -353,7 +353,7 @@ static int padata_setup_cpumasks(struct parallel_data *pd,
 
 	cpumask_and(pd->cpumask.pcpu, pcpumask, cpu_online_mask);
 	if (!alloc_cpumask_var(&pd->cpumask.cbcpu, GFP_KERNEL)) {
-		free_cpumask_var(pd->cpumask.cbcpu);
+		free_cpumask_var(pd->cpumask.pcpu);
 		return -ENOMEM;
 	}
 
-- 
2.12.2

[toc] | [next] | [standalone]


#1619825

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2017-04-10 13:30 +0200
Message-ID<tuFG9-8rl-3@gated-at.bofh.it>
In reply to#1618426
Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> The author meant to free the variable that was just allocated, instead
> of the one that failed to be allocated, but made a simple typo. This
> patch rectifies that.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: stable@vger.kernel.org

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web