Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1614530 > unrolled thread
| Started by | simran singhal <singhalsimran0@gmail.com> |
|---|---|
| First post | 2017-04-01 15:40 +0200 |
| Last post | 2017-04-07 01:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net: ipv4: netfilter: Remove unused function nf_nat_need_gre() simran singhal <singhalsimran0@gmail.com> - 2017-04-01 15:40 +0200
Re: [PATCH] net: ipv4: netfilter: Remove unused function nf_nat_need_gre() Pablo Neira Ayuso <pablo@netfilter.org> - 2017-04-07 01:10 +0200
| From | simran singhal <singhalsimran0@gmail.com> |
|---|---|
| Date | 2017-04-01 15:40 +0200 |
| Subject | [PATCH] net: ipv4: netfilter: Remove unused function nf_nat_need_gre() |
| Message-ID | <trrq1-3jA-9@gated-at.bofh.it> |
The function nf_nat_need_gre() on being called, simply returns
back. The function doesn't have FIXME code around.
Hence, nf_nat_need_gre() and its calls have been removed.
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
net/ipv4/netfilter/nf_nat_pptp.c | 2 --
net/ipv4/netfilter/nf_nat_proto_gre.c | 6 ------
2 files changed, 8 deletions(-)
diff --git a/net/ipv4/netfilter/nf_nat_pptp.c b/net/ipv4/netfilter/nf_nat_pptp.c
index b3ca21b..747e737 100644
--- a/net/ipv4/netfilter/nf_nat_pptp.c
+++ b/net/ipv4/netfilter/nf_nat_pptp.c
@@ -282,8 +282,6 @@ pptp_inbound_pkt(struct sk_buff *skb,
static int __init nf_nat_helper_pptp_init(void)
{
- nf_nat_need_gre();
-
BUG_ON(nf_nat_pptp_hook_outbound != NULL);
RCU_INIT_POINTER(nf_nat_pptp_hook_outbound, pptp_outbound_pkt);
diff --git a/net/ipv4/netfilter/nf_nat_proto_gre.c b/net/ipv4/netfilter/nf_nat_proto_gre.c
index edf0500..c020a4d 100644
--- a/net/ipv4/netfilter/nf_nat_proto_gre.c
+++ b/net/ipv4/netfilter/nf_nat_proto_gre.c
@@ -142,9 +142,3 @@ static void __exit nf_nat_proto_gre_fini(void)
module_init(nf_nat_proto_gre_init);
module_exit(nf_nat_proto_gre_fini);
-
-void nf_nat_need_gre(void)
-{
- return;
-}
-EXPORT_SYMBOL_GPL(nf_nat_need_gre);
--
2.7.4
[toc] | [next] | [standalone]
| From | Pablo Neira Ayuso <pablo@netfilter.org> |
|---|---|
| Date | 2017-04-07 01:10 +0200 |
| Message-ID | <ttoHo-7pr-9@gated-at.bofh.it> |
| In reply to | #1614530 |
On Sat, Apr 01, 2017 at 07:06:33PM +0530, simran singhal wrote:
> The function nf_nat_need_gre() on being called, simply returns
> back. The function doesn't have FIXME code around.
> Hence, nf_nat_need_gre() and its calls have been removed.
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
> net/ipv4/netfilter/nf_nat_pptp.c | 2 --
> net/ipv4/netfilter/nf_nat_proto_gre.c | 6 ------
> 2 files changed, 8 deletions(-)
>
> diff --git a/net/ipv4/netfilter/nf_nat_pptp.c b/net/ipv4/netfilter/nf_nat_pptp.c
> index b3ca21b..747e737 100644
> --- a/net/ipv4/netfilter/nf_nat_pptp.c
> +++ b/net/ipv4/netfilter/nf_nat_pptp.c
> @@ -282,8 +282,6 @@ pptp_inbound_pkt(struct sk_buff *skb,
>
> static int __init nf_nat_helper_pptp_init(void)
> {
> - nf_nat_need_gre();
> -
> BUG_ON(nf_nat_pptp_hook_outbound != NULL);
> RCU_INIT_POINTER(nf_nat_pptp_hook_outbound, pptp_outbound_pkt);
>
> diff --git a/net/ipv4/netfilter/nf_nat_proto_gre.c b/net/ipv4/netfilter/nf_nat_proto_gre.c
> index edf0500..c020a4d 100644
> --- a/net/ipv4/netfilter/nf_nat_proto_gre.c
> +++ b/net/ipv4/netfilter/nf_nat_proto_gre.c
> @@ -142,9 +142,3 @@ static void __exit nf_nat_proto_gre_fini(void)
>
> module_init(nf_nat_proto_gre_init);
> module_exit(nf_nat_proto_gre_fini);
> -
> -void nf_nat_need_gre(void)
> -{
> - return;
> -}
> -EXPORT_SYMBOL_GPL(nf_nat_need_gre);
There is a good reason why we have this :)
By digging out and doing a bit of software archeology work via the
'git annotate' you know this triggers an explicit module dependency.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web