Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1617390 > unrolled thread

[PATCH] net: ethernet: wiznet: avoid format string exposure

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: ethernet: wiznet: avoid format string exposure Kees Cook <keescook@chromium.org> - 2017-04-05 23:50 +0200
    Re: [PATCH] net: ethernet: wiznet: avoid format string exposure David Miller <davem@davemloft.net> - 2017-04-06 22:40 +0200

#1617390 — [PATCH] net: ethernet: wiznet: avoid format string exposure

While unlikely, this makes sure any format strings in the device name
can't exposure information via the resulting workqueue name.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/net/ethernet/wiznet/w5100.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c
index f90267f0519f..2bdfb39215e9 100644
--- a/drivers/net/ethernet/wiznet/w5100.c
+++ b/drivers/net/ethernet/wiznet/w5100.c
@@ -1152,7 +1152,8 @@ int w5100_probe(struct device *dev, const struct w5100_ops *ops,
 	if (err < 0)
 		goto err_register;
 
-	priv->xfer_wq = alloc_workqueue(netdev_name(ndev), WQ_MEM_RECLAIM, 0);
+	priv->xfer_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0,
+					netdev_name(ndev));
 	if (!priv->xfer_wq) {
 		err = -ENOMEM;
 		goto err_wq;
-- 
2.7.4


-- 
Kees Cook
Pixel Security

[toc] | [next] | [standalone]

#1618340

From: Kees Cook <keescook@chromium.org>
Date: Wed, 5 Apr 2017 14:39:35 -0700

> While unlikely, this makes sure any format strings in the device name
> can't exposure information via the resulting workqueue name.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web