Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618317 > unrolled thread

[PATCH 0/2] IB/usnic: Fine-tuning for two function implementations

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] IB/usnic: Fine-tuning for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-06 22:20 +0200
    [PATCH 2/2] IB/usnic: Use kcalloc() in usnic_vnic_alloc_res_chunk() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-06 22:20 +0200
    [PATCH 1/2] IB/usnic: Use kcalloc() in alloc_res_chunk_list() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-06 22:20 +0200

#1618317 — [PATCH 0/2] IB/usnic: Fine-tuning for two function implementations

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 6 Apr 2017 22:00:10 +0200

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Use kcalloc() in alloc_res_chunk_list()
  Use kcalloc() in usnic_vnic_alloc_res_chunk()

 drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 4 ++--
 drivers/infiniband/hw/usnic/usnic_vnic.c      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.12.2

[toc] | [next] | [standalone]

#1618320 — [PATCH 2/2] IB/usnic: Use kcalloc() in usnic_vnic_alloc_res_chunk()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 6 Apr 2017 21:45:33 +0200

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/usnic/usnic_vnic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/usnic/usnic_vnic.c b/drivers/infiniband/hw/usnic/usnic_vnic.c
index e7b0030254da..a00bb9940cea 100644
--- a/drivers/infiniband/hw/usnic/usnic_vnic.c
+++ b/drivers/infiniband/hw/usnic/usnic_vnic.c
@@ -312,7 +312,7 @@ static int usnic_vnic_alloc_res_chunk(struct usnic_vnic *vnic,
 	}
 
 	chunk->cnt = chunk->free_cnt = cnt;
-	chunk->res = kzalloc(sizeof(*(chunk->res))*cnt, GFP_KERNEL);
+	chunk->res = kcalloc(cnt, sizeof(*chunk->res), GFP_KERNEL);
 	if (!chunk->res)
 		return -ENOMEM;
 
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1618321 — [PATCH 1/2] IB/usnic: Use kcalloc() in alloc_res_chunk_list()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 6 Apr 2017 20:32:39 +0200

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
index 092d4e11a633..817f0475d9fe 100644
--- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
+++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
@@ -545,8 +545,8 @@ alloc_res_chunk_list(struct usnic_vnic *vnic,
 		/* Do Nothing */
 	}
 
-	res_chunk_list = kzalloc(sizeof(*res_chunk_list)*(res_lst_sz+1),
-					GFP_ATOMIC);
+	res_chunk_list = kcalloc(res_lst_sz + 1, sizeof(*res_chunk_list),
+				 GFP_ATOMIC);
 	if (!res_chunk_list)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.12.2

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web