Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618305 > unrolled thread

[PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n

Back to article view | Back to linux.kernel

Contents

  [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n Florian Fainelli <f.fainelli@gmail.com> - 2017-04-06 21:40 +0200
    Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n Andrew Lunn <andrew@lunn.ch> - 2017-04-06 22:00 +0200
    Re: [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n kbuild test robot <lkp@intel.com> - 2017-04-07 10:00 +0200

#1618305 — [PATCH] of: Make of_match_node() an inline stub for CONFIG_OF=n

Make of_match_node() an inline function when CONFIG_OF=n which allows the
compiler to eliminate warnings about unused variables.

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 include/linux/of.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/linux/of.h b/include/linux/of.h
index 21e6323de0f3..2803a85e81ec 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -839,7 +839,11 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag
 }
 
 #define of_match_ptr(_ptr)	NULL
-#define of_match_node(_matches, _node)	NULL
+static inline const struct of_device_id *of_match_node(
+	const struct of_device_id *matches, const struct device_node *node)
+{
+	return NULL;
+}
 #endif /* CONFIG_OF */
 
 /* Default string compare functions, Allow arch asm/prom.h to override */
-- 
2.9.3

[toc] | [next] | [standalone]

#1618315

On Thu, Apr 06, 2017 at 12:32:24PM -0700, Florian Fainelli wrote:
> Make of_match_node() an inline function when CONFIG_OF=n which allows the
> compiler to eliminate warnings about unused variables.
> 
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks Florian,

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[toc] | [prev] | [next] | [standalone]

#1618556

[Multipart message — attachments visible in raw view] — view raw

Hi Florian,

[auto build test ERROR on v4.9-rc8]
[also build test ERROR on next-20170406]
[cannot apply to glikely/devicetree/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-Make-of_match_node-an-inline-stub-for-CONFIG_OF-n/20170407-111805
config: x86_64-randconfig-ne0-04071359 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers//mfd/max8998.c: In function 'max8998_i2c_get_driver_data':
>> drivers//mfd/max8998.c:174:25: error: 'max8998_dt_match' undeclared (first use in this function)
      match = of_match_node(max8998_dt_match, i2c->dev.of_node);
                            ^~~~~~~~~~~~~~~~
   drivers//mfd/max8998.c:174:25: note: each undeclared identifier is reported only once for each function it appears in

vim +/max8998_dt_match +174 drivers//mfd/max8998.c

ee999fb3 Tomasz Figa   2013-06-25  158  
ee999fb3 Tomasz Figa   2013-06-25  159  	pd->ono = irq_of_parse_and_map(dev->of_node, 1);
ee999fb3 Tomasz Figa   2013-06-25  160  
ee999fb3 Tomasz Figa   2013-06-25  161  	/*
ee999fb3 Tomasz Figa   2013-06-25  162  	 * ToDo: the 'wakeup' member in the platform data is more of a linux
ee999fb3 Tomasz Figa   2013-06-25  163  	 * specfic information. Hence, there is no binding for that yet and
ee999fb3 Tomasz Figa   2013-06-25  164  	 * not parsed here.
ee999fb3 Tomasz Figa   2013-06-25  165  	 */
ee999fb3 Tomasz Figa   2013-06-25  166  	return pd;
ee999fb3 Tomasz Figa   2013-06-25  167  }
ee999fb3 Tomasz Figa   2013-06-25  168  
8bace2d5 Lee Jones     2014-02-03  169  static inline unsigned long max8998_i2c_get_driver_data(struct i2c_client *i2c,
ee999fb3 Tomasz Figa   2013-06-25  170  						const struct i2c_device_id *id)
ee999fb3 Tomasz Figa   2013-06-25  171  {
ee999fb3 Tomasz Figa   2013-06-25  172  	if (IS_ENABLED(CONFIG_OF) && i2c->dev.of_node) {
ee999fb3 Tomasz Figa   2013-06-25  173  		const struct of_device_id *match;
ee999fb3 Tomasz Figa   2013-06-25 @174  		match = of_match_node(max8998_dt_match, i2c->dev.of_node);
8bace2d5 Lee Jones     2014-02-03  175  		return (unsigned long)match->data;
ee999fb3 Tomasz Figa   2013-06-25  176  	}
ee999fb3 Tomasz Figa   2013-06-25  177  
8bace2d5 Lee Jones     2014-02-03  178  	return id->driver_data;
ee999fb3 Tomasz Figa   2013-06-25  179  }
ee999fb3 Tomasz Figa   2013-06-25  180  
156f2528 Kyungmin Park 2010-06-16  181  static int max8998_i2c_probe(struct i2c_client *i2c,
156f2528 Kyungmin Park 2010-06-16  182  			    const struct i2c_device_id *id)

:::::: The code at line 174 was first introduced by commit
:::::: ee999fb3f17faa3af6028bf7130707fe0d4157a4 mfd: max8998: Add support for Device Tree

:::::: TO: Tomasz Figa <t.figa@samsung.com>
:::::: CC: Samuel Ortiz <sameo@linux.intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web