Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618212 > unrolled thread

Re: [PATCH] format-security: move static strings to const

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] format-security: move static strings to const Jes Sorensen <jes.sorensen@gmail.com> - 2017-04-06 19:30 +0200

#1618212 — Re: [PATCH] format-security: move static strings to const

On 04/05/2017 05:47 PM, Kees Cook wrote:
> While examining output from trial builds with -Wformat-security enabled,
> many strings were found that should be defined as "const", or as a char
> array instead of char pointer. This makes some static analysis easier,
> by producing fewer false positives.
>
> As these are all trivial changes, it seemed best to put them all in
> a single patch rather than chopping them up per maintainer.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  arch/arm/mach-omap2/board-n8x0.c                  |  2 +-
>  arch/mips/dec/prom/init.c                         |  6 +++---
>  arch/mips/kernel/traps.c                          |  4 ++--
>  drivers/char/dsp56k.c                             |  2 +-
>  drivers/cpufreq/powernow-k8.c                     |  3 ++-
>  drivers/gpu/drm/drm_fb_helper.c                   |  2 +-
>  drivers/net/ethernet/amd/atarilance.c             |  4 ++--
>  drivers/net/ethernet/amd/declance.c               |  2 +-
>  drivers/net/ethernet/amd/sun3lance.c              |  3 ++-
>  drivers/net/ethernet/cirrus/mac89x0.c             |  2 +-
>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h |  2 +-
>  drivers/net/ethernet/natsemi/sonic.h              |  2 +-
>  drivers/net/ethernet/toshiba/tc35815.c            |  2 +-
>  drivers/net/fddi/defxx.c                          |  2 +-
>  drivers/net/hippi/rrunner.c                       |  3 ++-
>  drivers/staging/most/mostcore/core.c              |  2 +-
>  drivers/tty/n_hdlc.c                              | 10 +++++-----
>  drivers/tty/serial/st-asc.c                       |  2 +-
>  net/decnet/af_decnet.c                            |  3 ++-
>  19 files changed, 31 insertions(+), 27 deletions(-)

rrunner.c changes look fine to me.

Jes

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web