Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1618748 > unrolled thread
| Started by | Maciek Borzecki <maciek.borzecki@gmail.com> |
|---|---|
| First post | 2017-04-07 14:50 +0200 |
| Last post | 2017-04-08 15:30 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging wlan-ng: mark PDA buf as __le16 Maciek Borzecki <maciek.borzecki@gmail.com> - 2017-04-07 14:50 +0200
Re: [PATCH] staging wlan-ng: mark PDA buf as __le16 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-08 13:10 +0200
Re: [PATCH] staging wlan-ng: mark PDA buf as __le16 Maciek Borzecki <maciek.borzecki@gmail.com> - 2017-04-08 15:20 +0200
Re: [PATCH] staging wlan-ng: mark PDA buf as __le16 Maciek Borzecki <maciek.borzecki@gmail.com> - 2017-04-08 15:30 +0200
| From | Maciek Borzecki <maciek.borzecki@gmail.com> |
|---|---|
| Date | 2017-04-07 14:50 +0200 |
| Subject | [PATCH] staging wlan-ng: mark PDA buf as __le16 |
| Message-ID | <ttBuW-78a-25@gated-at.bofh.it> |
PDA buffer contains little-endian data, clearly mark it as such.
Fixes sparse warnings:
drivers/staging/wlan-ng/hfa384x_usb.c:2359:34: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:2360:35: warning: cast to restricted __le16
drivers/staging/wlan-ng/hfa384x_usb.c:2382:44: warning: cast to restricted __le16
Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6134eba5cad4693997faf8d2d77947ff7e8b0713..64848778834cae1d341c59ecce756d11b218b4c8 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -2316,7 +2316,7 @@ int hfa384x_drvr_ramdl_write(struct hfa384x *hw, u32 daddr, void *buf, u32 len)
int hfa384x_drvr_readpda(struct hfa384x *hw, void *buf, unsigned int len)
{
int result = 0;
- u16 *pda = buf;
+ __le16 *pda = buf;
int pdaok = 0;
int morepdrs = 1;
int currpdr = 0; /* word offset of the current pdr */
--
2.9.3
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-04-08 13:10 +0200 |
| Message-ID | <ttWpH-4vu-5@gated-at.bofh.it> |
| In reply to | #1618748 |
On Fri, Apr 07, 2017 at 02:47:55PM +0200, Maciek Borzecki wrote: > PDA buffer contains little-endian data, clearly mark it as such. > > Fixes sparse warnings: > drivers/staging/wlan-ng/hfa384x_usb.c:2359:34: warning: cast to restricted __le16 > drivers/staging/wlan-ng/hfa384x_usb.c:2360:35: warning: cast to restricted __le16 > drivers/staging/wlan-ng/hfa384x_usb.c:2382:44: warning: cast to restricted __le16 > > Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com> > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch does not apply to my tree at all, what did you make it against? thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Maciek Borzecki <maciek.borzecki@gmail.com> |
|---|---|
| Date | 2017-04-08 15:20 +0200 |
| Message-ID | <ttYrv-5IU-5@gated-at.bofh.it> |
| In reply to | #1619266 |
On Sat, Apr 8, 2017 at 1:01 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Apr 07, 2017 at 02:47:55PM +0200, Maciek Borzecki wrote:
>> PDA buffer contains little-endian data, clearly mark it as such.
>>
>> Fixes sparse warnings:
>> drivers/staging/wlan-ng/hfa384x_usb.c:2359:34: warning: cast to restricted __le16
>> drivers/staging/wlan-ng/hfa384x_usb.c:2360:35: warning: cast to restricted __le16
>> drivers/staging/wlan-ng/hfa384x_usb.c:2382:44: warning: cast to restricted __le16
>>
>> Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
>> ---
>> drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch does not apply to my tree at all, what did you make it
> against?
>
It was made on top of:
commit c02ed2e75ef4c74e41e421acb4ef1494671585e8
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun Mar 26 14:15:16 2017 -0700
Linux 4.11-rc4
Let me rebase on top of staging-next and resend.
--
Maciek Borzecki
[toc] | [prev] | [next] | [standalone]
| From | Maciek Borzecki <maciek.borzecki@gmail.com> |
|---|---|
| Date | 2017-04-08 15:30 +0200 |
| Message-ID | <ttYBb-5On-5@gated-at.bofh.it> |
| In reply to | #1619276 |
On Sat, Apr 8, 2017 at 3:18 PM, Maciek Borzecki <maciek.borzecki@gmail.com> wrote: > On Sat, Apr 8, 2017 at 1:01 PM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: >> On Fri, Apr 07, 2017 at 02:47:55PM +0200, Maciek Borzecki wrote: >>> PDA buffer contains little-endian data, clearly mark it as such. >>> >>> Fixes sparse warnings: >>> drivers/staging/wlan-ng/hfa384x_usb.c:2359:34: warning: cast to restricted __le16 >>> drivers/staging/wlan-ng/hfa384x_usb.c:2360:35: warning: cast to restricted __le16 >>> drivers/staging/wlan-ng/hfa384x_usb.c:2382:44: warning: cast to restricted __le16 >>> >>> Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com> >>> --- >>> drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> This patch does not apply to my tree at all, what did you make it >> against? >> > > It was made on top of: > > commit c02ed2e75ef4c74e41e421acb4ef1494671585e8 > Author: Linus Torvalds <torvalds@linux-foundation.org> > Date: Sun Mar 26 14:15:16 2017 -0700 > > Linux 4.11-rc4 > > Let me rebase on top of staging-next and resend. Please ignore this patch. Turns out there's a similar patch already applied in staging-next. Cheers, -- Maciek Borzecki
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web