Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619002 > unrolled thread
| Started by | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| First post | 2017-04-07 19:50 +0200 |
| Last post | 2017-04-08 00:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/1] memory: tegra: fix fdc test bug Thierry Reding <thierry.reding@gmail.com> - 2017-04-07 19:50 +0200
Re: [PATCH 1/1] memory: tegra: fix fdc test bug Ben Dooks <ben.dooks@codethink.co.uk> - 2017-04-08 00:00 +0200
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2017-04-07 19:50 +0200 |
| Subject | Re: [PATCH 1/1] memory: tegra: fix fdc test bug |
| Message-ID | <ttGbg-21h-9@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Apr 07, 2017 at 06:28:20PM +0100, Ben Dooks wrote: > The fdc variable is a bool, taking the address of this will generally > produce true, thus skewing any users of the tegra_mc_set_latency_allowance > code. > > Note, this does not seem to be producing a compiler warning. This was only > spotted as it meant a caller was seeing 3 times higher than expected > register results. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > drivers/memory/tegra/mc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) What tree is this based on? I don't see this code anywhere in mainline. Thierry
[toc] | [next] | [standalone]
| From | Ben Dooks <ben.dooks@codethink.co.uk> |
|---|---|
| Date | 2017-04-08 00:00 +0200 |
| Message-ID | <ttK5b-4R7-13@gated-at.bofh.it> |
| In reply to | #1619002 |
On 2017-04-07 18:43, Thierry Reding wrote: > On Fri, Apr 07, 2017 at 06:28:20PM +0100, Ben Dooks wrote: >> The fdc variable is a bool, taking the address of this will generally >> produce true, thus skewing any users of the >> tegra_mc_set_latency_allowance >> code. >> >> Note, this does not seem to be producing a compiler warning. This was >> only >> spotted as it meant a caller was seeing 3 times higher than expected >> register results. >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> drivers/memory/tegra/mc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > What tree is this based on? I don't see this code anywhere in mainline. Apologies, turns out this a vendor added function. -- Ben
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web