Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1617546 > unrolled thread
| Started by | Michał Kępień <kernel@kempniu.pl> |
|---|---|
| First post | 2017-04-06 08:50 +0200 |
| Last post | 2017-04-07 20:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] platform/x86: fujitsu-laptop: update debug message logged by call_fext_func() Michał Kępień <kernel@kempniu.pl> - 2017-04-06 08:50 +0200
Re: [PATCH] platform/x86: fujitsu-laptop: update debug message logged by call_fext_func() Jonathan Woithe <jwoithe@just42.net> - 2017-04-07 13:50 +0200
Re: [PATCH] platform/x86: fujitsu-laptop: update debug message logged by call_fext_func() Darren Hart <dvhart@infradead.org> - 2017-04-07 20:00 +0200
| From | Michał Kępień <kernel@kempniu.pl> |
|---|---|
| Date | 2017-04-06 08:50 +0200 |
| Subject | [PATCH] platform/x86: fujitsu-laptop: update debug message logged by call_fext_func() |
| Message-ID | <tt9p0-4Yc-13@gated-at.bofh.it> |
Update debug message logged when the acpi_evaluate_integer() call inside
call_fext_func() fails so that it covers a broader set of possible
errors.
Signed-off-by: Michał Kępień <kernel@kempniu.pl>
---
This patch is a follow-up to v1 of the call_fext_func() cleanup series
and as such, it should be applied to for-next.
drivers/platform/x86/fujitsu-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 26149f58dba7..928778ccc4c1 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -232,7 +232,7 @@ static int call_fext_func(int func, int op, int feature, int state)
status = acpi_evaluate_integer(fujitsu_laptop->acpi_handle, "FUNC",
&arg_list, &value);
if (ACPI_FAILURE(status)) {
- vdbg_printk(FUJLAPTOP_DBG_ERROR, "FUNC interface is not present\n");
+ vdbg_printk(FUJLAPTOP_DBG_ERROR, "Failed to evaluate FUNC\n");
return -ENODEV;
}
--
2.12.2
[toc] | [next] | [standalone]
| From | Jonathan Woithe <jwoithe@just42.net> |
|---|---|
| Date | 2017-04-07 13:50 +0200 |
| Subject | Re: [PATCH] platform/x86: fujitsu-laptop: update debug message logged by call_fext_func() |
| Message-ID | <ttAyR-6wY-7@gated-at.bofh.it> |
| In reply to | #1617546 |
On Thu, Apr 06, 2017 at 08:46:10AM +0200, Micha?? K??pie?? wrote:
> Update debug message logged when the acpi_evaluate_integer() call inside
> call_fext_func() fails so that it covers a broader set of possible
> errors.
>
> Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl>
> ---
> This patch is a follow-up to v1 of the call_fext_func() cleanup series
> and as such, it should be applied to for-next.
>
> drivers/platform/x86/fujitsu-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 26149f58dba7..928778ccc4c1 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -232,7 +232,7 @@ static int call_fext_func(int func, int op, int feature, int state)
> status = acpi_evaluate_integer(fujitsu_laptop->acpi_handle, "FUNC",
> &arg_list, &value);
> if (ACPI_FAILURE(status)) {
> - vdbg_printk(FUJLAPTOP_DBG_ERROR, "FUNC interface is not present\n");
> + vdbg_printk(FUJLAPTOP_DBG_ERROR, "Failed to evaluate FUNC\n");
> return -ENODEV;
> }
As per discussions on the list, this change is fine, is consistent with the
generic nature of possible failure modes and makes sense in the context of
the other recent changes.
Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
Regards
jonathan
[toc] | [prev] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2017-04-07 20:00 +0200 |
| Subject | Re: [PATCH] platform/x86: fujitsu-laptop: update debug message logged by call_fext_func() |
| Message-ID | <ttGkW-28n-19@gated-at.bofh.it> |
| In reply to | #1618707 |
On Fri, Apr 07, 2017 at 09:10:19PM +0930, Jonathan Woithe wrote:
> On Thu, Apr 06, 2017 at 08:46:10AM +0200, Micha?? K??pie?? wrote:
> > Update debug message logged when the acpi_evaluate_integer() call inside
> > call_fext_func() fails so that it covers a broader set of possible
> > errors.
> >
> > Signed-off-by: Micha?? K??pie?? <kernel@kempniu.pl>
> > ---
> > This patch is a follow-up to v1 of the call_fext_func() cleanup series
> > and as such, it should be applied to for-next.
> >
> > drivers/platform/x86/fujitsu-laptop.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> > index 26149f58dba7..928778ccc4c1 100644
> > --- a/drivers/platform/x86/fujitsu-laptop.c
> > +++ b/drivers/platform/x86/fujitsu-laptop.c
> > @@ -232,7 +232,7 @@ static int call_fext_func(int func, int op, int feature, int state)
> > status = acpi_evaluate_integer(fujitsu_laptop->acpi_handle, "FUNC",
> > &arg_list, &value);
> > if (ACPI_FAILURE(status)) {
> > - vdbg_printk(FUJLAPTOP_DBG_ERROR, "FUNC interface is not present\n");
> > + vdbg_printk(FUJLAPTOP_DBG_ERROR, "Failed to evaluate FUNC\n");
> > return -ENODEV;
> > }
>
> As per discussions on the list, this change is fine, is consistent with the
> generic nature of possible failure modes and makes sense in the context of
> the other recent changes.
>
> Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
Queued to testing, thanks.
--
Darren Hart
VMware Open Source Technology Center
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web