Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1611596 > unrolled thread

[PATCH] net: netfilter: Use list_{next/prev}_entry instead of list_entry

Started bysimran singhal <singhalsimran0@gmail.com>
First post2017-03-29 07:50 +0200
Last post2017-04-07 17:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] net: netfilter: Use list_{next/prev}_entry instead of  list_entry simran singhal <singhalsimran0@gmail.com> - 2017-03-29 07:50 +0200
    Re: [PATCH] net: netfilter: Use list_{next/prev}_entry instead of  list_entry Pablo Neira Ayuso <pablo@netfilter.org> - 2017-04-07 17:40 +0200

#1611596 — [PATCH] net: netfilter: Use list_{next/prev}_entry instead of list_entry

Fromsimran singhal <singhalsimran0@gmail.com>
Date2017-03-29 07:50 +0200
Subject[PATCH] net: netfilter: Use list_{next/prev}_entry instead of list_entry
Message-ID<tqeEy-2pZ-19@gated-at.bofh.it>
This patch replace list_entry with list_prev_entry as it makes the
code more clear to read.

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 net/netfilter/nf_tables_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index b7645d7..a341eaf 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -1895,7 +1895,7 @@ static int nf_tables_fill_rule_info(struct sk_buff *skb, struct net *net,
 		goto nla_put_failure;
 
 	if ((event != NFT_MSG_DELRULE) && (rule->list.prev != &chain->rules)) {
-		prule = list_entry(rule->list.prev, struct nft_rule, list);
+		prule = list_prev_entry(rule, list);
 		if (nla_put_be64(skb, NFTA_RULE_POSITION,
 				 cpu_to_be64(prule->handle),
 				 NFTA_RULE_PAD))
-- 
2.7.4

[toc] | [next] | [standalone]


#1618910

FromPablo Neira Ayuso <pablo@netfilter.org>
Date2017-04-07 17:40 +0200
Message-ID<ttE9r-A7-1@gated-at.bofh.it>
In reply to#1611596
On Wed, Mar 29, 2017 at 11:15:40AM +0530, simran singhal wrote:
> This patch replace list_entry with list_prev_entry as it makes the
> code more clear to read.

Also applied, thanks.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web