Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1615007 > unrolled thread

[PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

Started byCorentin Labbe <clabbe.montjoie@gmail.com>
First post2017-04-03 11:20 +0200
Last post2017-04-07 14:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64 Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-03 11:20 +0200
    Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on  pine64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 13:40 +0200
      Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on  pine64 Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-07 14:50 +0200

#1615007 — [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

FromCorentin Labbe <clabbe.montjoie@gmail.com>
Date2017-04-03 11:20 +0200
Subject[PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64
Message-ID<ts6jx-4Wo-23@gated-at.bofh.it>
The dwmac-sun8i hardware is present on the pine64
It uses an external PHY via RMII.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index c680ed3..6aee3d5 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -109,3 +109,19 @@
 &usbphy {
 	status = "okay";
 };
+
+&mdio {
+	ext_rmii_phy1: ethernet-phy@1 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <1>;
+	};
+};
+
+&emac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&rmii_pins>;
+	phy-mode = "rmii";
+	phy-handle = <&ext_rmii_phy1>;
+	status = "okay";
+
+};
-- 
2.10.2

[toc] | [next] | [standalone]


#1615126 — Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-04-03 13:40 +0200
SubjectRe: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64
Message-ID<ts8uZ-6fU-17@gated-at.bofh.it>
In reply to#1615007

[Multipart message — attachments visible in raw view] — view raw

On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote:
> The dwmac-sun8i hardware is present on the pine64
> It uses an external PHY via RMII.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Looks fine, but please use "arm64: allwinner: pine64: " as your title
prefix. It applies to all your other patches (and the arm ones should
be "arm: <family>: <soc-or-board>:".

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1618740 — Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

FromCorentin Labbe <clabbe.montjoie@gmail.com>
Date2017-04-07 14:50 +0200
SubjectRe: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64
Message-ID<ttBuW-78a-15@gated-at.bofh.it>
In reply to#1615126
On Mon, Apr 03, 2017 at 01:38:47PM +0200, Maxime Ripard wrote:
> On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote:
> > The dwmac-sun8i hardware is present on the pine64
> > It uses an external PHY via RMII.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> 
> Looks fine, but please use "arm64: allwinner: pine64: " as your title
> prefix. It applies to all your other patches (and the arm ones should
> be "arm: <family>: <soc-or-board>:".
> 

Will fix them

Thanks
Corentin Labbe

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web