Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1616027 > unrolled thread
| Started by | Tobias Regnery <tobias.regnery@gmail.com> |
|---|---|
| First post | 2017-04-04 15:40 +0200 |
| Last post | 2017-04-05 23:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] IB/hns: include linux/of.h to fix build failure Tobias Regnery <tobias.regnery@gmail.com> - 2017-04-04 15:40 +0200
Re: [PATCH] IB/hns: include linux/of.h to fix build failure Doug Ledford <dledford@redhat.com> - 2017-04-05 23:30 +0200
| From | Tobias Regnery <tobias.regnery@gmail.com> |
|---|---|
| Date | 2017-04-04 15:40 +0200 |
| Subject | [PATCH] IB/hns: include linux/of.h to fix build failure |
| Message-ID | <tswQG-5tl-19@gated-at.bofh.it> |
I see the following build error in an arm64 randconfig build: drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_reset': drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1384:15: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration] Fix this by including linux/of.h directly. Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com> --- This is against next-20170404 drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c index ec68f56e8ee5..0f7e85c7b70b 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c @@ -33,6 +33,7 @@ #include <linux/platform_device.h> #include <linux/acpi.h> #include <linux/etherdevice.h> +#include <linux/of.h> #include <rdma/ib_umem.h> #include "hns_roce_common.h" #include "hns_roce_device.h" -- 2.11.0
[toc] | [next] | [standalone]
| From | Doug Ledford <dledford@redhat.com> |
|---|---|
| Date | 2017-04-05 23:30 +0200 |
| Message-ID | <tt0F4-7SK-3@gated-at.bofh.it> |
| In reply to | #1616027 |
[Multipart message — attachments visible in raw view] — view raw
On 4/4/2017 9:36 AM, Tobias Regnery wrote:
> I see the following build error in an arm64 randconfig build:
>
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_reset':
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1384:15: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]
>
> Fix this by including linux/of.h directly.
>
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
> ---
> This is against next-20170404
>
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index ec68f56e8ee5..0f7e85c7b70b 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -33,6 +33,7 @@
> #include <linux/platform_device.h>
> #include <linux/acpi.h>
> #include <linux/etherdevice.h>
> +#include <linux/of.h>
> #include <rdma/ib_umem.h>
> #include "hns_roce_common.h"
> #include "hns_roce_device.h"
>
Hi Tobias, I already picked up this same change from another person.
Thanks.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web