Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1615506 > unrolled thread

Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Started byRitesh Raj Sarraf <rrs@researchut.com>
First post2017-04-03 21:20 +0200
Last post2017-04-05 07:00 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 Ritesh Raj Sarraf <rrs@researchut.com> - 2017-04-03 21:20 +0200
    Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-04-05 02:50 +0200
      RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 "Song, Hongyan" <hongyan.song@intel.com> - 2017-04-05 03:20 +0200
      Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 Ritesh Raj Sarraf <rrs@researchut.com> - 2017-04-05 13:00 +0200
        Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-04-05 17:40 +0200
          RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 "Song, Hongyan" <hongyan.song@intel.com> - 2017-04-06 07:00 +0200
            Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2017-04-06 07:20 +0200
    RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll  value function order to avoid sensor properties losing after resume from S3 "Song, Hongyan" <hongyan.song@intel.com> - 2017-04-05 07:00 +0200

#1615506 — Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

FromRitesh Raj Sarraf <rrs@researchut.com>
Date2017-04-03 21:20 +0200
SubjectRe: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3
Message-ID<tsfG9-2BB-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Adding Stable, LKML and IIO MLs.

Hello Hongyan,

Do you have any feedback ? With the bisected commit reverted, I've been
successfully running the machine without any issues.

Ritesh


On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> Hello Hongyan,
> 
> Can you check the findings of Ritesh?
> 
> Thanks,
> Srinivas
> 
> On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > Hello Srinivas,
> > 
> > With the Linux 4.10.7 release, I have encountered a regression
> > introduced on my
> > Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > 
> > 
> > rrs@learner:~$ lsusb 
> > Bus 001 Device 002: ID 8087:8000 Intel Corp. 
> > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > Bus 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> > Bus 002 Device 006: ID 048d:8350 Integrated Technology Express, Inc. 
> > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. 
> > Bus 002 Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd 
> > Bus 002 Device 003: ID 04f3:0303 Elan Microelectronics Corp. 
> > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129
> > Card Reader
> > Controller
> > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > 2017-04-01 / 14:04:49 ♒♒♒  ☺  
> > 
> > 
> > The ITE sensors do not feed any data on the 4.10.7 kernel. Reverting
> > back to
> > 4.10.5, everything works back.
> > 
> > 
> > After a git bisect, the culprit reported is:
> > 
> > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-trigger:
> > Change get
> > poll value function order to avoid sensor properties losing after
> > resume from S3
> > 1
> > 
> > Can you please review my findings to confirm that it really is a
> > regression bug
> > ?
> > 
> > 
> > Thanks,
> > Ritesh
> > 
-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[toc] | [next] | [standalone]


#1616476

FromSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date2017-04-05 02:50 +0200
Message-ID<tsHj3-3Oe-7@gated-at.bofh.it>
In reply to#1615506

[Multipart message — attachments visible in raw view] — view raw

Hi Ritesh,

Does the attached patch helps?

Thanks,
Srinivas

On Tue, 2017-04-04 at 00:44 +0530, Ritesh Raj Sarraf wrote:
> Adding Stable, LKML and IIO MLs.
> 
> Hello Hongyan,
> 
> Do you have any feedback ? With the bisected commit reverted, I've
> been
> successfully running the machine without any issues.
> 
> Ritesh
> 
> 
> On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> > Hello Hongyan,
> > 
> > Can you check the findings of Ritesh?
> > 
> > Thanks,
> > Srinivas
> > 
> > On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > > Hello Srinivas,
> > > 
> > > With the Linux 4.10.7 release, I have encountered a regression
> > > introduced on my
> > > Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > > 
> > > 
> > > rrs@learner:~$ lsusb 
> > > Bus 001 Device 002: ID 8087:8000 Intel Corp. 
> > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > > Bus 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> > > Bus 002 Device 006: ID 048d:8350 Integrated Technology Express,
> > > Inc. 
> > > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. 
> > > Bus 002 Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd 
> > > Bus 002 Device 003: ID 04f3:0303 Elan Microelectronics Corp. 
> > > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp.
> > > RTS5129
> > > Card Reader
> > > Controller
> > > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > > 2017-04-01 / 14:04:49 ♒♒♒  ☺  
> > > 
> > > 
> > > The ITE sensors do not feed any data on the 4.10.7 kernel.
> > > Reverting
> > > back to
> > > 4.10.5, everything works back.
> > > 
> > > 
> > > After a git bisect, the culprit reported is:
> > > 
> > > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-
> > > trigger:
> > > Change get
> > > poll value function order to avoid sensor properties losing after
> > > resume from S3
> > > 1
> > > 
> > > Can you please review my findings to confirm that it really is a
> > > regression bug
> > > ?
> > > 
> > > 
> > > Thanks,
> > > Ritesh
> > > 

[toc] | [prev] | [next] | [standalone]


#1616488

From"Song, Hongyan" <hongyan.song@intel.com>
Date2017-04-05 03:20 +0200
Message-ID<tsHM6-4f4-13@gated-at.bofh.it>
In reply to#1616476
Hi All,
	Sorry for the late response, for I am on Qingming Festival for the last 3 days.
I noticed Ritesh has tried a USB sensor, I do not have that kind of sensor at hand and have not tried it yet. My patch worked well for ISH but I am not sure whether it is fine for USB sensor. Sorry for not much information can provide. I will try to see if I can find one device and try.



BR
Song Hongyan

-----Original Message-----
From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com]
Sent: Wednesday, April 5, 2017 8:45 AM
To: rrs@researchut.com; Song, Hongyan <hongyan.song@intel.com>; linux-iio <linux-iio@vger.kernel.org>
Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Hi Ritesh,

Does the attached patch helps?

Thanks,
Srinivas

On Tue, 2017-04-04 at 00:44 +0530, Ritesh Raj Sarraf wrote:
> Adding Stable, LKML and IIO MLs.
> 
> Hello Hongyan,
> 
> Do you have any feedback ? With the bisected commit reverted, I've 
> been successfully running the machine without any issues.
> 
> Ritesh
> 
> 
> On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> > Hello Hongyan,
> > 
> > Can you check the findings of Ritesh?
> > 
> > Thanks,
> > Srinivas
> > 
> > On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > > Hello Srinivas,
> > > 
> > > With the Linux 4.10.7 release, I have encountered a regression 
> > > introduced on my Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > > 
> > > 
> > > rrs@learner:~$ lsusb
> > > Bus 001 Device 002: ID 8087:8000 Intel Corp. Bus 001 Device 001: 
> > > ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 003 Device 001: ID
> > > 1d6b:0003 Linux Foundation 3.0 root hub Bus 002 Device 006: ID
> > > 048d:8350 Integrated Technology Express, Inc.
> > > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. Bus
> > > 002 Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd Bus 002 
> > > Device 003: ID 04f3:0303 Elan Microelectronics Corp.
> > > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp.
> > > RTS5129
> > > Card Reader
> > > Controller
> > > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > > 2017-04-01 / 14:04:49 ♒♒♒  ☺
> > > 
> > > 
> > > The ITE sensors do not feed any data on the 4.10.7 kernel.
> > > Reverting
> > > back to
> > > 4.10.5, everything works back.
> > > 
> > > 
> > > After a git bisect, the culprit reported is:
> > > 
> > > Bisecting: 0 revisions left to test after this (roughly 0 steps) 
> > > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-
> > > trigger:
> > > Change get
> > > poll value function order to avoid sensor properties losing after 
> > > resume from S3
> > > 1
> > > 
> > > Can you please review my findings to confirm that it really is a 
> > > regression bug ?
> > > 
> > > 
> > > Thanks,
> > > Ritesh
> > > 

[toc] | [prev] | [next] | [standalone]


#1616838

FromRitesh Raj Sarraf <rrs@researchut.com>
Date2017-04-05 13:00 +0200
Message-ID<tsQPo-1yL-27@gated-at.bofh.it>
In reply to#1616476

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> Hi Ritesh,
> 
> Does the attached patch helps?

Thank you Srinivas. I tested your patch on top of 4.10.8 and it is working
perfect.

Ritesh

-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[toc] | [prev] | [next] | [standalone]


#1617066

FromSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date2017-04-05 17:40 +0200
Message-ID<tsVcl-4qr-9@gated-at.bofh.it>
In reply to#1616838
Hi Hongyan,

Can you check if the patch meets your requirement/needs for ISH?

Thanks,
Srinivas

On Wed, 2017-04-05 at 16:21 +0530, Ritesh Raj Sarraf wrote:
> On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> > 
> > Hi Ritesh,
> > 
> > Does the attached patch helps?
> 
> Thank you Srinivas. I tested your patch on top of 4.10.8 and it is
> working
> perfect.
> 
> Ritesh
> 

[toc] | [prev] | [next] | [standalone]


#1617502

From"Song, Hongyan" <hongyan.song@intel.com>
Date2017-04-06 07:00 +0200
Message-ID<tt7Gy-3Q1-3@gated-at.bofh.it>
In reply to#1617066
Hi Srinivas,
	I have checked the patch dose not meets my requirement for ISH.
With this patch sensor properties still losing after resume from S3.

BR
Song Hongyan

-----Original Message-----
From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com] 
Sent: Wednesday, April 5, 2017 11:36 PM
To: rrs@researchut.com; Song, Hongyan <hongyan.song@intel.com>; linux-iio <linux-iio@vger.kernel.org>
Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Hi Hongyan,

Can you check if the patch meets your requirement/needs for ISH?

Thanks,
Srinivas

On Wed, 2017-04-05 at 16:21 +0530, Ritesh Raj Sarraf wrote:
> On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> > 
> > Hi Ritesh,
> > 
> > Does the attached patch helps?
> 
> Thank you Srinivas. I tested your patch on top of 4.10.8 and it is 
> working perfect.
> 
> Ritesh
> 

[toc] | [prev] | [next] | [standalone]


#1617504

FromSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date2017-04-06 07:20 +0200
Message-ID<tt7ZT-4cz-1@gated-at.bofh.it>
In reply to#1617502
On Thu, 2017-04-06 at 04:58 +0000, Song, Hongyan wrote:
> Hi Srinivas,
> 	I have checked the patch dose not meets my requirement for ISH.
> With this patch sensor properties still losing after resume from S3.
What is your test case? I want to try.

Thanks,
Srinivas

> 
> BR
> Song Hongyan
> 
> -----Original Message-----
> From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com
> ] 
> Sent: Wednesday, April 5, 2017 11:36 PM
> To: rrs@researchut.com; Song, Hongyan <hongyan.song@intel.com>;
> linux-iio <linux-iio@vger.kernel.org>
> Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get
> poll value function order to avoid sensor properties losing after
> resume from S3
> 
> Hi Hongyan,
> 
> Can you check if the patch meets your requirement/needs for ISH?
> 
> Thanks,
> Srinivas
> 
> On Wed, 2017-04-05 at 16:21 +0530, Ritesh Raj Sarraf wrote:
> > 
> > On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> > > 
> > > 
> > > Hi Ritesh,
> > > 
> > > Does the attached patch helps?
> > Thank you Srinivas. I tested your patch on top of 4.10.8 and it is 
> > working perfect.
> > 
> > Ritesh
> > 

[toc] | [prev] | [next] | [standalone]


#1616570

From"Song, Hongyan" <hongyan.song@intel.com>
Date2017-04-05 07:00 +0200
Message-ID<tsLd0-6ng-5@gated-at.bofh.it>
In reply to#1615506
Hi Ritesh,
	I do not have the environment so should not have a try but I think Srinivas's patch should be Ok for your platform.
Please have a try.

Thanks a lot!


BR
Song Hongyan

-----Original Message-----
From: Ritesh Raj Sarraf [mailto:rrs@researchut.com] 
Sent: Tuesday, April 4, 2017 3:14 AM
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>; Song, Hongyan <hongyan.song@intel.com>; linux-iio <linux-iio@vger.kernel.org>
Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Adding Stable, LKML and IIO MLs.

Hello Hongyan,

Do you have any feedback ? With the bisected commit reverted, I've been successfully running the machine without any issues.

Ritesh


On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> Hello Hongyan,
> 
> Can you check the findings of Ritesh?
> 
> Thanks,
> Srinivas
> 
> On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > Hello Srinivas,
> > 
> > With the Linux 4.10.7 release, I have encountered a regression 
> > introduced on my Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > 
> > 
> > rrs@learner:~$ lsusb
> > Bus 001 Device 002: ID 8087:8000 Intel Corp. Bus 001 Device 001: ID 
> > 1d6b:0002 Linux Foundation 2.0 root hub Bus 003 Device 001: ID 
> > 1d6b:0003 Linux Foundation 3.0 root hub Bus 002 Device 006: ID 
> > 048d:8350 Integrated Technology Express, Inc.
> > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. Bus 002 
> > Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd Bus 002 Device 
> > 003: ID 04f3:0303 Elan Microelectronics Corp.
> > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129 
> > Card Reader Controller Bus 002 Device 001: ID 1d6b:0002 Linux 
> > Foundation 2.0 root hub
> > 2017-04-01 / 14:04:49 ♒♒♒  ☺
> > 
> > 
> > The ITE sensors do not feed any data on the 4.10.7 kernel. Reverting
> > back to
> > 4.10.5, everything works back.
> > 
> > 
> > After a git bisect, the culprit reported is:
> > 
> > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-trigger:
> > Change get
> > poll value function order to avoid sensor properties losing after
> > resume from S3
> > 1
> > 
> > Can you please review my findings to confirm that it really is a
> > regression bug
> > ?
> > 
> > 
> > Thanks,
> > Ritesh
> > 
-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web