Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615360 > unrolled thread

[PATCH] of: irq: Export of_irq_count()

Back to article view | Back to linux.kernel

Contents

  [PATCH] of: irq: Export of_irq_count() Thierry Reding <thierry.reding@gmail.com> - 2017-04-03 18:00 +0200
    Re: [PATCH] of: irq: Export of_irq_count() Rob Herring <robh+dt@kernel.org> - 2017-04-03 18:20 +0200
      Re: [PATCH] of: irq: Export of_irq_count() Thierry Reding <thierry.reding@gmail.com> - 2017-04-03 18:30 +0200

#1615360 — [PATCH] of: irq: Export of_irq_count()

From: Thierry Reding <treding@nvidia.com>

of_irq_count() is handy for obtaining the number of interrupts assigned
to a device tree node. It is reasonable to want to access this function
from loadable modules, so export the symbol to allow that.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Hi Rob, Frank,

This patch is required for the new Tegra186 GPIO driver I'm trying to
get merged for v4.12. It'd be great if I could get an Acked-by from you
so that the patch can be merged through the GPIO tree along with a few
other prerequisites for the new driver.

Potential for conflicts is rather minimal given the line count.

Thanks,
Thierry

 drivers/of/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 7c56b72d1dc6..3deaada2ff29 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -458,6 +458,7 @@ int of_irq_count(struct device_node *dev)
 
 	return nr;
 }
+EXPORT_SYMBOL_GPL(of_irq_count);
 
 /**
  * of_irq_to_resource_table - Fill in resource table with node's IRQ info
-- 
2.12.0

[toc] | [next] | [standalone]

#1615379

On Mon, Apr 3, 2017 at 10:55 AM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> of_irq_count() is handy for obtaining the number of interrupts assigned
> to a device tree node. It is reasonable to want to access this function
> from loadable modules, so export the symbol to allow that.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi Rob, Frank,
>
> This patch is required for the new Tegra186 GPIO driver I'm trying to
> get merged for v4.12. It'd be great if I could get an Acked-by from you
> so that the patch can be merged through the GPIO tree along with a few
> other prerequisites for the new driver.

Use platform_irq_count instead.

Rob

[toc] | [prev] | [next] | [standalone]

#1615391

[Multipart message — attachments visible in raw view] — view raw

On Mon, Apr 03, 2017 at 11:13:43AM -0500, Rob Herring wrote:
> On Mon, Apr 3, 2017 at 10:55 AM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > of_irq_count() is handy for obtaining the number of interrupts assigned
> > to a device tree node. It is reasonable to want to access this function
> > from loadable modules, so export the symbol to allow that.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > Hi Rob, Frank,
> >
> > This patch is required for the new Tegra186 GPIO driver I'm trying to
> > get merged for v4.12. It'd be great if I could get an Acked-by from you
> > so that the patch can be merged through the GPIO tree along with a few
> > other prerequisites for the new driver.
> 
> Use platform_irq_count instead.

Nice, that's much better.

Thanks,
Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web