Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1617259 > unrolled thread

Re: [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function  implementations Doug Ledford <dledford@redhat.com> - 2017-04-05 20:20 +0200
    Re: [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function  implementations Leon Romanovsky <leon@kernel.org> - 2017-04-09 08:40 +0200

#1617259 — Re: [PATCH 00/14] RDMA/cxgb: Fine-tuning for several function implementations

On Wed, 2017-02-08 at 22:10 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 8 Feb 2017 22:00:10 +0100
> 
> Several update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (14):
>   Use kcalloc() in cxio_create_qp()
>   Rename jump labels in cxio_create_qp()
>   Use kcalloc() in two functions
>   Use common error handling code in recover_queues()
>   Return an error code only as a constant in ep_open()
>   Return an error code only as a constant in stag_open()
>   Adjust three checks for null pointers
>   Adjust construction of two error messages in recover_lost_dbs()
>   Use common error handling code in recover_lost_dbs()
>   Use kmalloc_array() in c4iw_id_table_alloc()
>   Use kcalloc() in create_qp()
>   Delete an unnecessary variable initialisation in create_qp()
>   Rename jump labels in c4iw_create_qp()
>   Rename jump labels in rdma_init()
> 
>  drivers/infiniband/hw/cxgb3/cxio_hal.c | 20 ++++----
>  drivers/infiniband/hw/cxgb4/device.c   | 83 +++++++++++++++---------
> ----------
>  drivers/infiniband/hw/cxgb4/id_table.c |  5 +-
>  drivers/infiniband/hw/cxgb4/qp.c       | 48 ++++++++++----------
>  4 files changed, 75 insertions(+), 81 deletions(-)

I didn't see enough value in this series to bother picking it up.
 Steve, if there are any patches out of this series you actually want,
please collect them and forward them on to me.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[toc] | [next] | [standalone]

#1619446

[Multipart message — attachments visible in raw view] — view raw

On Wed, Apr 05, 2017 at 02:16:14PM -0400, Doug Ledford wrote:
> On Wed, 2017-02-08 at 22:10 +0100, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Wed, 8 Feb 2017 22:00:10 +0100
> >
> > Several update suggestions were taken into account
> > from static source code analysis.
> >
> > Markus Elfring (14):
> >   Use kcalloc() in cxio_create_qp()
> >   Rename jump labels in cxio_create_qp()
> >   Use kcalloc() in two functions
> >   Use common error handling code in recover_queues()
> >   Return an error code only as a constant in ep_open()
> >   Return an error code only as a constant in stag_open()
> >   Adjust three checks for null pointers
> >   Adjust construction of two error messages in recover_lost_dbs()
> >   Use common error handling code in recover_lost_dbs()
> >   Use kmalloc_array() in c4iw_id_table_alloc()
> >   Use kcalloc() in create_qp()
> >   Delete an unnecessary variable initialisation in create_qp()
> >   Rename jump labels in c4iw_create_qp()
> >   Rename jump labels in rdma_init()
> >
> >  drivers/infiniband/hw/cxgb3/cxio_hal.c | 20 ++++----
> >  drivers/infiniband/hw/cxgb4/device.c   | 83 +++++++++++++++---------
> > ----------
> >  drivers/infiniband/hw/cxgb4/id_table.c |  5 +-
> >  drivers/infiniband/hw/cxgb4/qp.c       | 48 ++++++++++----------
> >  4 files changed, 75 insertions(+), 81 deletions(-)
>
> I didn't see enough value in this series to bother picking it up.
>  Steve, if there are any patches out of this series you actually want,
> please collect them and forward them on to me.

Hi Doug,

Can you please use the same pattern for ALL Markus's patches?

It is too time consuming to review his changes and it gives a very little
actual value.

Thanks

>
> --
> Doug Ledford <dledford@redhat.com>
>     GPG KeyID: B826A3330E572FDD
>    
> Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web