Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1616675 > unrolled thread
| Started by | Juergen Gross <jgross@suse.com> |
|---|---|
| First post | 2017-04-05 10:20 +0200 |
| Last post | 2017-04-05 16:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] xen, fbfront: add support for specifying size via xenstore Juergen Gross <jgross@suse.com> - 2017-04-05 10:20 +0200
Re: [PATCH] xen, fbfront: add support for specifying size via xenstore Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-04-05 16:50 +0200
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2017-04-05 10:20 +0200 |
| Subject | Re: [PATCH] xen, fbfront: add support for specifying size via xenstore |
| Message-ID | <tsOkx-8y-5@gated-at.bofh.it> |
On 23/03/17 13:53, Juergen Gross wrote:
> Today xen-fbfront supports specifying the display size via module
> parameters only. Add support for specifying the size via Xenstore in
> order to enable doing this easily via the domain's Xen configuration.
>
> Add an error message in case the configured display size conflicts
> with video memory size.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Bartlomiej, any comments? Can you please take this patch or should I
carry it through the Xen tree?
Juergen
> ---
> drivers/video/fbdev/xen-fbfront.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 3ee309c..46f6396 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -18,6 +18,8 @@
> * frame buffer.
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> #include <linux/console.h>
> #include <linux/kernel.h>
> #include <linux/errno.h>
> @@ -380,10 +382,18 @@ static int xenfb_probe(struct xenbus_device *dev,
> video[KPARAM_MEM] = val;
> }
>
> + video[KPARAM_WIDTH] = xenbus_read_unsigned(dev->otherend, "width",
> + video[KPARAM_WIDTH]);
> + video[KPARAM_HEIGHT] = xenbus_read_unsigned(dev->otherend, "height",
> + video[KPARAM_HEIGHT]);
> +
> /* If requested res does not fit in available memory, use default */
> fb_size = video[KPARAM_MEM] * 1024 * 1024;
> if (video[KPARAM_WIDTH] * video[KPARAM_HEIGHT] * XENFB_DEPTH / 8
> > fb_size) {
> + pr_warn("display parameters %d,%d,%d invalid, use defaults\n",
> + video[KPARAM_MEM], video[KPARAM_WIDTH],
> + video[KPARAM_HEIGHT]);
> video[KPARAM_WIDTH] = XENFB_WIDTH;
> video[KPARAM_HEIGHT] = XENFB_HEIGHT;
> fb_size = XENFB_DEFAULT_FB_LEN;
>
[toc] | [next] | [standalone]
| From | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| Date | 2017-04-05 16:50 +0200 |
| Subject | Re: [PATCH] xen, fbfront: add support for specifying size via xenstore |
| Message-ID | <tsUpY-3RS-17@gated-at.bofh.it> |
| In reply to | #1616675 |
On Wednesday, April 05, 2017 10:18:43 AM Juergen Gross wrote: > On 23/03/17 13:53, Juergen Gross wrote: > > Today xen-fbfront supports specifying the display size via module > > parameters only. Add support for specifying the size via Xenstore in > > order to enable doing this easily via the domain's Xen configuration. > > > > Add an error message in case the configured display size conflicts > > with video memory size. > > > > Signed-off-by: Juergen Gross <jgross@suse.com> > > Bartlomiej, any comments? Can you please take this patch or should I > carry it through the Xen tree? Looks fine to me, I will queue it for 4.12 on Friday. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web