Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1616346 > unrolled thread
| Started by | Thomas Jespersen <laumann.thomas@gmail.com> |
|---|---|
| First post | 2017-04-04 21:20 +0200 |
| Last post | 2017-04-05 14:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] unisys: visornic: Replace symbolic perms with octal Thomas Jespersen <laumann.thomas@gmail.com> - 2017-04-04 21:20 +0200
RE: [PATCH] unisys: visornic: Replace symbolic perms with octal "Kershner, David A" <David.Kershner@unisys.com> - 2017-04-05 14:50 +0200
| From | Thomas Jespersen <laumann.thomas@gmail.com> |
|---|---|
| Date | 2017-04-04 21:20 +0200 |
| Subject | [PATCH] unisys: visornic: Replace symbolic perms with octal |
| Message-ID | <tsC9I-G4-5@gated-at.bofh.it> |
Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
counterparts
Signed-off-by: Thomas Jespersen <laumann.thomas@gmail.com>
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index feece91..1008337 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -2146,11 +2146,11 @@ static int visornic_init(void)
if (!visornic_debugfs_dir)
return err;
- ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir, NULL,
+ ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
&debugfs_info_fops);
if (!ret)
goto cleanup_debugfs;
- ret = debugfs_create_file("enable_ints", S_IWUSR, visornic_debugfs_dir,
+ ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
NULL, &debugfs_enable_ints_fops);
if (!ret)
goto cleanup_debugfs;
--
2.10.2
[toc] | [next] | [standalone]
| From | "Kershner, David A" <David.Kershner@unisys.com> |
|---|---|
| Date | 2017-04-05 14:50 +0200 |
| Message-ID | <tsSxP-2F7-9@gated-at.bofh.it> |
| In reply to | #1616346 |
> -----Original Message-----
> From: Thomas Jespersen [mailto:laumann.thomas@gmail.com]
> Sent: Tuesday, April 4, 2017 3:15 PM
> To: Kershner, David A <David.Kershner@unisys.com>
> Cc: gregkh@linuxfoundation.org; Sell, Timothy C
> <Timothy.Sell@unisys.com>; Binder, David Anthony
> <David.Binder@unisys.com>; Frisch, Jon <Jon.Frisch@unisys.com>;
> erik.arfvidson@unisys.com; *S-Par-Maintainer
> <SParMaintainer@unisys.com>; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] unisys: visornic: Replace symbolic perms with octal
>
Should the subject line say "staging: unisys: visornic" instead of just
"unisys: visornic:"?
Besides that, I'm fine with this patch and have tested it on s-Par.
David Kershner
> Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
> counterparts
>
> Signed-off-by: Thomas Jespersen <laumann.thomas@gmail.com>
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c
> b/drivers/staging/unisys/visornic/visornic_main.c
> index feece91..1008337 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -2146,11 +2146,11 @@ static int visornic_init(void)
> if (!visornic_debugfs_dir)
> return err;
>
> - ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir,
> NULL,
> + ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
> &debugfs_info_fops);
> if (!ret)
> goto cleanup_debugfs;
> - ret = debugfs_create_file("enable_ints", S_IWUSR,
> visornic_debugfs_dir,
> + ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
> NULL, &debugfs_enable_ints_fops);
> if (!ret)
> goto cleanup_debugfs;
> --
> 2.10.2
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web