Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1615782 > unrolled thread

Re: [PATCH v3 00/11] add thermal throttling to Allwinner A33 SoC

Started byLee Jones <lee.jones@linaro.org>
First post2017-04-04 10:40 +0200
Last post2017-04-05 13:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v3 00/11] add thermal throttling to Allwinner A33 SoC Lee Jones <lee.jones@linaro.org> - 2017-04-04 10:40 +0200
    Re: [PATCH v3 00/11] add thermal throttling to Allwinner A33 SoC Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-04-05 11:20 +0200
      Re: [PATCH v3 00/11] add thermal throttling to Allwinner A33 SoC Lee Jones <lee.jones@linaro.org> - 2017-04-05 12:10 +0200
        Re: [PATCH v3 00/11] add thermal throttling to Allwinner A33 SoC Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-04-05 13:30 +0200

#1615782 — Re: [PATCH v3 00/11] add thermal throttling to Allwinner A33 SoC

FromLee Jones <lee.jones@linaro.org>
Date2017-04-04 10:40 +0200
SubjectRe: [PATCH v3 00/11] add thermal throttling to Allwinner A33 SoC
Message-ID<tssam-2oD-7@gated-at.bofh.it>
On Tue, 21 Mar 2017, Quentin Schulz wrote:

> The Allwinner SoCs all have an ADC that can also act as a touchscreen
> controller and a thermal sensor. The first four channels can be used
> either for the ADC or the touchscreen and the fifth channel is used for
> the thermal sensor. We currently have a driver for the two latter
> functions in drivers/input/touchscreen/sun4i-ts.c but we don't have
> access to the ADC feature at all. It is meant to replace the current
> driver by using MFD and subdrivers for existing bindings.
> 
> The Allwinner A33 only has a thermal sensor present in the GPADC. In
> addition, there is not an existing DT binding for the GPADC. Thus, we do
> not need the sun4i-gpadc MFD driver which was made to keep DT compatibility
> and probe subdrivers without the need to add DT subnodes.
> 
> This series of patch adds the thermal sensor for the A33 and GPU/CPU
> thermal throttling. It also adds the cpu-supply property to the CPU node
> needed by the Sinlinx SinA33 and Olinuxino A33 to adapt their CPU regulator
> voltage depending on the currently used OPP. The other A33 boards all have
> their cpu-supply property set.
> 
> This series also fixes the missing operating-points-v2 property in cpu DT
> nodes. Finally, it also adds all remaining OPPs which can be found in
> Allwinner 3.4 linux and fex files of all A33 boards.
> 
> This series of patch is based on this[1] series of patch.
> 
> v3:
>   - fixed compatible name in DT and in documentation,
>   - fixed DT node name and label,
>   - added explanations in commit logs,
>   - moved frequencies that need overvolting to board DTS instead of A33 DTSI,
>   - fixed a typo in if is_enabled condition,
>   - removed all patches concerning Olimex Olinuxino (no HW to test on),

What is the plan for this series?

I'm guessing there are no hard dependencies on the ARM parts?

If not, I'm happy to take the changes to 'drivers/*'.

> [1] https://lkml.org/lkml/2016/12/13/298 : "[PATCH v9] add support for Allwinner
> SoCs ADC"
> 
> Thanks,
> Quentin
> 
> Maxime Ripard (1):
>   ARM: sun8i: a33: Add devfreq-based GPU cooling
> 
> Quentin Schulz (10):
>   ARM: sun8i: a33: add operating-points-v2 property to all nodes
>   ARM: sun8i: a33: add all operating points
>   ARM: dts: sun8i: sina33: add cpu-supply
>   Documentation: DT: bindings: mfd: add A33 GPADC binding
>   Documentation: DT: bindings: input: touschcreen: remove sun4i
>     documentation
>   iio: adc: sun4i-gpadc-iio: move code used in MFD probing to new
>     function
>   iio: adc: sun4i-gpadc-iio: add support for A33 thermal sensor
>   ARM: dtsi: sun8i: a33: add thermal sensor
>   ARM: dtsi: sun8i: a33: add CPU thermal throttling
>   ARM: sun8i: sina33: add highest OPP of CPUs
> 
>  .../touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt}  |  21 +++
>  arch/arm/boot/dts/sun8i-a23-a33.dtsi               |   1 +
>  arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts     |  18 +++
>  arch/arm/boot/dts/sun8i-a33.dtsi                   | 141 +++++++++++++++++
>  drivers/iio/adc/Kconfig                            |   2 +-
>  drivers/iio/adc/sun4i-gpadc-iio.c                  | 170 +++++++++++++++++----
>  include/linux/mfd/sun4i-gpadc.h                    |   4 +
>  7 files changed, 324 insertions(+), 33 deletions(-)
>  rename Documentation/devicetree/bindings/{input/touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt} (64%)
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]


#1616752

FromQuentin Schulz <quentin.schulz@free-electrons.com>
Date2017-04-05 11:20 +0200
Message-ID<tsPgB-IY-15@gated-at.bofh.it>
In reply to#1615782
Hi Lee,

On 04/04/2017 10:31, Lee Jones wrote:
> On Tue, 21 Mar 2017, Quentin Schulz wrote:
> 
>> The Allwinner SoCs all have an ADC that can also act as a touchscreen
>> controller and a thermal sensor. The first four channels can be used
>> either for the ADC or the touchscreen and the fifth channel is used for
>> the thermal sensor. We currently have a driver for the two latter
>> functions in drivers/input/touchscreen/sun4i-ts.c but we don't have
>> access to the ADC feature at all. It is meant to replace the current
>> driver by using MFD and subdrivers for existing bindings.
>>
>> The Allwinner A33 only has a thermal sensor present in the GPADC. In
>> addition, there is not an existing DT binding for the GPADC. Thus, we do
>> not need the sun4i-gpadc MFD driver which was made to keep DT compatibility
>> and probe subdrivers without the need to add DT subnodes.
>>
>> This series of patch adds the thermal sensor for the A33 and GPU/CPU
>> thermal throttling. It also adds the cpu-supply property to the CPU node
>> needed by the Sinlinx SinA33 and Olinuxino A33 to adapt their CPU regulator
>> voltage depending on the currently used OPP. The other A33 boards all have
>> their cpu-supply property set.
>>
>> This series also fixes the missing operating-points-v2 property in cpu DT
>> nodes. Finally, it also adds all remaining OPPs which can be found in
>> Allwinner 3.4 linux and fex files of all A33 boards.
>>
>> This series of patch is based on this[1] series of patch.
>>
>> v3:
>>   - fixed compatible name in DT and in documentation,
>>   - fixed DT node name and label,
>>   - added explanations in commit logs,
>>   - moved frequencies that need overvolting to board DTS instead of A33 DTSI,
>>   - fixed a typo in if is_enabled condition,
>>   - removed all patches concerning Olimex Olinuxino (no HW to test on),
> 
> What is the plan for this series?
> 
> I'm guessing there are no hard dependencies on the ARM parts?
> 
> If not, I'm happy to take the changes to 'drivers/*'.
> 

I've sent a v4 to add some Acked-by and change a few commit "titles".
It's ready to be merged with only the following patch required (which
Jonathan asked if you could merge it through the mfd tree): "[RESEND
PATCH v4] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs
ADCs" (https://patchwork.kernel.org/patch/9660879/)

Thanks,
Quentin

>> [1] https://lkml.org/lkml/2016/12/13/298 : "[PATCH v9] add support for Allwinner
>> SoCs ADC"
>>
>> Thanks,
>> Quentin
>>
>> Maxime Ripard (1):
>>   ARM: sun8i: a33: Add devfreq-based GPU cooling
>>
>> Quentin Schulz (10):
>>   ARM: sun8i: a33: add operating-points-v2 property to all nodes
>>   ARM: sun8i: a33: add all operating points
>>   ARM: dts: sun8i: sina33: add cpu-supply
>>   Documentation: DT: bindings: mfd: add A33 GPADC binding
>>   Documentation: DT: bindings: input: touschcreen: remove sun4i
>>     documentation
>>   iio: adc: sun4i-gpadc-iio: move code used in MFD probing to new
>>     function
>>   iio: adc: sun4i-gpadc-iio: add support for A33 thermal sensor
>>   ARM: dtsi: sun8i: a33: add thermal sensor
>>   ARM: dtsi: sun8i: a33: add CPU thermal throttling
>>   ARM: sun8i: sina33: add highest OPP of CPUs
>>
>>  .../touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt}  |  21 +++
>>  arch/arm/boot/dts/sun8i-a23-a33.dtsi               |   1 +
>>  arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts     |  18 +++
>>  arch/arm/boot/dts/sun8i-a33.dtsi                   | 141 +++++++++++++++++
>>  drivers/iio/adc/Kconfig                            |   2 +-
>>  drivers/iio/adc/sun4i-gpadc-iio.c                  | 170 +++++++++++++++++----
>>  include/linux/mfd/sun4i-gpadc.h                    |   4 +
>>  7 files changed, 324 insertions(+), 33 deletions(-)
>>  rename Documentation/devicetree/bindings/{input/touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt} (64%)
>>
> 

-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1616779

FromLee Jones <lee.jones@linaro.org>
Date2017-04-05 12:10 +0200
Message-ID<tsQ30-1gj-23@gated-at.bofh.it>
In reply to#1616752
On Wed, 05 Apr 2017, Quentin Schulz wrote:
> On 04/04/2017 10:31, Lee Jones wrote:
> > On Tue, 21 Mar 2017, Quentin Schulz wrote:
> >> v3:
> >>   - fixed compatible name in DT and in documentation,
> >>   - fixed DT node name and label,
> >>   - added explanations in commit logs,
> >>   - moved frequencies that need overvolting to board DTS instead of A33 DTSI,
> >>   - fixed a typo in if is_enabled condition,
> >>   - removed all patches concerning Olimex Olinuxino (no HW to test on),
> > 
> > What is the plan for this series?
> > 
> > I'm guessing there are no hard dependencies on the ARM parts?
> > 
> > If not, I'm happy to take the changes to 'drivers/*'.
> > 
> 
> I've sent a v4 to add some Acked-by and change a few commit "titles".
> It's ready to be merged with only the following patch required (which
> Jonathan asked if you could merge it through the mfd tree): "[RESEND
> PATCH v4] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs
> ADCs" (https://patchwork.kernel.org/patch/9660879/)

Right, but how would you like *this* patch-set applied?

I'm guessing the ARM patches need to go in via ARM-SoC.

What about the drivers/{input,iio,mfd} patches?

I'm guessing they're to all go in via my tree?

> >> [1] https://lkml.org/lkml/2016/12/13/298 : "[PATCH v9] add support for Allwinner
> >> SoCs ADC"
> >>
> >> Thanks,
> >> Quentin
> >>
> >> Maxime Ripard (1):
> >>   ARM: sun8i: a33: Add devfreq-based GPU cooling
> >>
> >> Quentin Schulz (10):
> >>   ARM: sun8i: a33: add operating-points-v2 property to all nodes
> >>   ARM: sun8i: a33: add all operating points
> >>   ARM: dts: sun8i: sina33: add cpu-supply
> >>   Documentation: DT: bindings: mfd: add A33 GPADC binding
> >>   Documentation: DT: bindings: input: touschcreen: remove sun4i
> >>     documentation
> >>   iio: adc: sun4i-gpadc-iio: move code used in MFD probing to new
> >>     function
> >>   iio: adc: sun4i-gpadc-iio: add support for A33 thermal sensor
> >>   ARM: dtsi: sun8i: a33: add thermal sensor
> >>   ARM: dtsi: sun8i: a33: add CPU thermal throttling
> >>   ARM: sun8i: sina33: add highest OPP of CPUs
> >>
> >>  .../touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt}  |  21 +++
> >>  arch/arm/boot/dts/sun8i-a23-a33.dtsi               |   1 +
> >>  arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts     |  18 +++
> >>  arch/arm/boot/dts/sun8i-a33.dtsi                   | 141 +++++++++++++++++
> >>  drivers/iio/adc/Kconfig                            |   2 +-
> >>  drivers/iio/adc/sun4i-gpadc-iio.c                  | 170 +++++++++++++++++----
> >>  include/linux/mfd/sun4i-gpadc.h                    |   4 +
> >>  7 files changed, 324 insertions(+), 33 deletions(-)
> >>  rename Documentation/devicetree/bindings/{input/touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt} (64%)
> >>
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]


#1616851

FromQuentin Schulz <quentin.schulz@free-electrons.com>
Date2017-04-05 13:30 +0200
Message-ID<tsRip-1Ze-13@gated-at.bofh.it>
In reply to#1616779
Hi Lee,

On 05/04/2017 11:57, Lee Jones wrote:
> On Wed, 05 Apr 2017, Quentin Schulz wrote:
>> On 04/04/2017 10:31, Lee Jones wrote:
>>> On Tue, 21 Mar 2017, Quentin Schulz wrote:
>>>> v3:
>>>>   - fixed compatible name in DT and in documentation,
>>>>   - fixed DT node name and label,
>>>>   - added explanations in commit logs,
>>>>   - moved frequencies that need overvolting to board DTS instead of A33 DTSI,
>>>>   - fixed a typo in if is_enabled condition,
>>>>   - removed all patches concerning Olimex Olinuxino (no HW to test on),
>>>
>>> What is the plan for this series?
>>>
>>> I'm guessing there are no hard dependencies on the ARM parts?
>>>
>>> If not, I'm happy to take the changes to 'drivers/*'.
>>>
>>
>> I've sent a v4 to add some Acked-by and change a few commit "titles".
>> It's ready to be merged with only the following patch required (which
>> Jonathan asked if you could merge it through the mfd tree): "[RESEND
>> PATCH v4] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs
>> ADCs" (https://patchwork.kernel.org/patch/9660879/)

I got things mixed up between the two different IIO/ADC drivers I'm
trying to get merge. Forget about this dependency, that's not for this
patch series. Sorry for that.

> 
> Right, but how would you like *this* patch-set applied?
> 
> I'm guessing the ARM patches need to go in via ARM-SoC.
> 
> What about the drivers/{input,iio,mfd} patches?
> 
> I'm guessing they're to all go in via my tree?
> 

Patches 1-2 - MFD maintainer I guess? (Lee)
Patches 3-4 - IIO maintainer (Jonathan)
Patches 5-8 - SUNXI maintainer (Maxime)

I think that should do it.

Quentin

>>>> [1] https://lkml.org/lkml/2016/12/13/298 : "[PATCH v9] add support for Allwinner
>>>> SoCs ADC"
>>>>
>>>> Thanks,
>>>> Quentin
>>>>
>>>> Maxime Ripard (1):
>>>>   ARM: sun8i: a33: Add devfreq-based GPU cooling
>>>>
>>>> Quentin Schulz (10):
>>>>   ARM: sun8i: a33: add operating-points-v2 property to all nodes
>>>>   ARM: sun8i: a33: add all operating points
>>>>   ARM: dts: sun8i: sina33: add cpu-supply
>>>>   Documentation: DT: bindings: mfd: add A33 GPADC binding
>>>>   Documentation: DT: bindings: input: touschcreen: remove sun4i
>>>>     documentation
>>>>   iio: adc: sun4i-gpadc-iio: move code used in MFD probing to new
>>>>     function
>>>>   iio: adc: sun4i-gpadc-iio: add support for A33 thermal sensor
>>>>   ARM: dtsi: sun8i: a33: add thermal sensor
>>>>   ARM: dtsi: sun8i: a33: add CPU thermal throttling
>>>>   ARM: sun8i: sina33: add highest OPP of CPUs
>>>>
>>>>  .../touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt}  |  21 +++
>>>>  arch/arm/boot/dts/sun8i-a23-a33.dtsi               |   1 +
>>>>  arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts     |  18 +++
>>>>  arch/arm/boot/dts/sun8i-a33.dtsi                   | 141 +++++++++++++++++
>>>>  drivers/iio/adc/Kconfig                            |   2 +-
>>>>  drivers/iio/adc/sun4i-gpadc-iio.c                  | 170 +++++++++++++++++----
>>>>  include/linux/mfd/sun4i-gpadc.h                    |   4 +
>>>>  7 files changed, 324 insertions(+), 33 deletions(-)
>>>>  rename Documentation/devicetree/bindings/{input/touchscreen/sun4i.txt => mfd/sun4i-gpadc.txt} (64%)
>>>>
>>>
>>
> 

-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web