Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1616342 > unrolled thread

Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes Bjorn Helgaas <helgaas@kernel.org> - 2017-04-04 21:10 +0200
    RE: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes KY Srinivasan <kys@microsoft.com> - 2017-04-04 22:00 +0200
      Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes Bjorn Helgaas <helgaas@kernel.org> - 2017-04-04 22:40 +0200
        RE: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes KY Srinivasan <kys@microsoft.com> - 2017-04-04 23:50 +0200

#1616342 — Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes

On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan <kys@microsoft.com>
> 
> Some miscellaneous fixes.
> 
> K. Y. Srinivasan (2):
>   pci-hyperv: Fix a bug in specifying CPU affinity
>   pci-hyperv: Fix an atomic bug
> 
>  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
>  1 files changed, 9 insertions(+), 4 deletions(-)

I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
following subject lines:

  PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
  PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC

There were two copies of [1/2], which makes this error-prone.  I applied
the second one that defines CPU_AFFINITY_ALL.

They're both marked for stable, but without any clue about when the
problems were introduced or how serious they are, I did not queue them for
v4.11.  If you want them in v4.11, please supply those additional details.

Bjorn

[toc] | [next] | [standalone]

#1616366

> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 4, 2017 12:04 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> 
> On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> wrote:
> > From: K. Y. Srinivasan <kys@microsoft.com>
> >
> > Some miscellaneous fixes.
> >
> > K. Y. Srinivasan (2):
> >   pci-hyperv: Fix a bug in specifying CPU affinity
> >   pci-hyperv: Fix an atomic bug
> >
> >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> >  1 files changed, 9 insertions(+), 4 deletions(-)
> 
> I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> following subject lines:
> 
>   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
>   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> 
Thank you.

> There were two copies of [1/2], which makes this error-prone.  I applied
> the second one that defines CPU_AFFINITY_ALL.

Thanks again; sorry for the confusion.

> 
> They're both marked for stable, but without any clue about when the
> problems were introduced or how serious they are, I did not queue them for
> v4.11.  If you want them in v4.11, please supply those additional details.

I think these issues have been there since   the driver got merged upstream.
I would want this to be applied against 4.11 as well. Let me know if I should resend
these patches.

Thanks,

K. Y 
> 
> Bjorn

[toc] | [prev] | [next] | [standalone]

#1616377

On Tue, Apr 04, 2017 at 07:54:33PM +0000, KY Srinivasan wrote:
> > -----Original Message-----
> > From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> > Sent: Tuesday, April 4, 2017 12:04 PM
> > To: KY Srinivasan <kys@microsoft.com>
> > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > vkuznets@redhat.com; jasowang@redhat.com;
> > leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> > Hemminger <sthemmin@microsoft.com>
> > Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> > 
> > On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> > wrote:
> > > From: K. Y. Srinivasan <kys@microsoft.com>
> > >
> > > Some miscellaneous fixes.
> > >
> > > K. Y. Srinivasan (2):
> > >   pci-hyperv: Fix a bug in specifying CPU affinity
> > >   pci-hyperv: Fix an atomic bug
> > >
> > >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> > >  1 files changed, 9 insertions(+), 4 deletions(-)
> > 
> > I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> > following subject lines:
> > 
> >   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
> >   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> > 
> Thank you.
> 
> > There were two copies of [1/2], which makes this error-prone.  I applied
> > the second one that defines CPU_AFFINITY_ALL.
> 
> Thanks again; sorry for the confusion.
> 
> > 
> > They're both marked for stable, but without any clue about when the
> > problems were introduced or how serious they are, I did not queue them for
> > v4.11.  If you want them in v4.11, please supply those additional details.
> 
> I think these issues have been there since   the driver got merged upstream.
> I would want this to be applied against 4.11 as well. Let me know if I should resend
> these patches.

No need to resend, but I do need more details about what issues these fix
and why they're more urgent than garden-variety bug fixes that are planned
for v4.12.  In general for-linus is for fixing problems we added during the
merge window, or other high-priority, low-risk changes.

Bjorn

[toc] | [prev] | [next] | [standalone]

#1616396

> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 4, 2017 1:39 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> 
> On Tue, Apr 04, 2017 at 07:54:33PM +0000, KY Srinivasan wrote:
> > > -----Original Message-----
> > > From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> > > Sent: Tuesday, April 4, 2017 12:04 PM
> > > To: KY Srinivasan <kys@microsoft.com>
> > > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > > vkuznets@redhat.com; jasowang@redhat.com;
> > > leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> > > Hemminger <sthemmin@microsoft.com>
> > > Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> > >
> > > On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> > > wrote:
> > > > From: K. Y. Srinivasan <kys@microsoft.com>
> > > >
> > > > Some miscellaneous fixes.
> > > >
> > > > K. Y. Srinivasan (2):
> > > >   pci-hyperv: Fix a bug in specifying CPU affinity
> > > >   pci-hyperv: Fix an atomic bug
> > > >
> > > >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> > > >  1 files changed, 9 insertions(+), 4 deletions(-)
> > >
> > > I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> > > following subject lines:
> > >
> > >   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
> > >   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> > >
> > Thank you.
> >
> > > There were two copies of [1/2], which makes this error-prone.  I applied
> > > the second one that defines CPU_AFFINITY_ALL.
> >
> > Thanks again; sorry for the confusion.
> >
> > >
> > > They're both marked for stable, but without any clue about when the
> > > problems were introduced or how serious they are, I did not queue them
> for
> > > v4.11.  If you want them in v4.11, please supply those additional details.
> >
> > I think these issues have been there since   the driver got merged
> upstream.
> > I would want this to be applied against 4.11 as well. Let me know if I should
> resend
> > these patches.
> 
> No need to resend, but I do need more details about what issues these fix
> and why they're more urgent than garden-variety bug fixes that are planned
> for v4.12.  In general for-linus is for fixing problems we added during the
> merge window, or other high-priority, low-risk changes.

For sure I want to get this into 4.12. Since it fixes issues that have been there for a long time,
(including 4.11), it would be good to get it into 4.11 as well. 

Regards,

K. Y
> 
> Bjorn

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web